Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename private and public transactions everywhere to just transaction #870

Closed
benesjan opened this issue Jun 16, 2023 · 0 comments · Fixed by #942
Closed

Rename private and public transactions everywhere to just transaction #870

benesjan opened this issue Jun 16, 2023 · 0 comments · Fixed by #942
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Jun 16, 2023 •
edited
Loading

Since PR #852 all txs contain at least 1 private function call.

Hence there is not a purely public tx anymore. Rename txs everywhere to avoid confusion in the future.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 16, 2023
@benesjan benesjan self-assigned this Jun 30, 2023
@benesjan benesjan mentioned this issue Jun 30, 2023
Merged
6 tasks
@benesjan benesjan moved this from Todo to In Review in A3 Jul 3, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jul 6, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Not calling tx private or public AztecProtocol/aztec-packages
1 participant
@benesjan