refactor: simplify sequencer and l1 communication

[LHerskind]

Fixes #7821.

Looking to combine some of the components where there are interfaces that don't really seem to be useful as there would likely be only one implementation. When makes sense, I have joined the "wrapper" and the thing it wrapped because extra wrapping is just confusing.

Starting with changing the global variables builder, since that was low hanging. When looking at the viem-tx-sender it is more tedious as the tests are heavily abusing that had two separate components.

Getting rid of the gasEstimate steps as viem seems to perform that estimate step if no gas amount is provided, so might as well make it less verbose, https://viem.sh/docs/contract/writeContract#gas-optional.

• Removes the viem-reader
• Removes the viem-tx-sender
• Removes the receiver
• Alter the GlobalVariableBuilder to directly read values
• Alter the L1Publisher to interact directly with the rollup and availability oracle.
• Updates the tests

[LHerskind]

• refactor: simplify sequencer and l1 communication #7989 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,780	1,561	708 (-1%)	757 (-2%)	767 (-3%)
proof_construction_time_sha256_30_ms	11,877	3,193	1,422 (-1%)	1,452 (-1%)	1,471 (-1%)
proof_construction_time_sha256_100_ms	45,472	12,020 (-2%)	5,461 (-1%)	5,436 (-1%)	5,367 (-1%)
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	35.0	34.0	59.0 (+2%)	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,536	426	202 (-1%)	225 (-5%)	267
proof_construction_time_poseidon_hash_100_ms	5,658 (-1%)	1,514	682	739 (+2%)	750 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,720	92,512	177,536
l1_rollup_execution_gas	1,383,214	2,130,974	3,958,037
l2_block_processing_time_in_ms	256 (-2%)	443 (-2%)	805
l2_block_building_time_in_ms	9,292	18,209	36,246
l2_block_rollup_simulation_time_in_ms	9,291	18,209	36,246
l2_block_public_tx_process_time_in_ms	7,847	16,654	34,662

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,918 (-2%)	3,868
node_database_size_in_bytes	12,648,528	16,769,104
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	97.3 (+7%)	397 (-1%)	21,673	44,858	N/A
private-kernel-inner	164 (-2%)	700 (-2%)	72,309	45,005	N/A
private-kernel-reset-tiny	513 (+3%)	877 (-3%)	65,974	44,844	N/A
private-kernel-tail	209	161 (-4%)	50,728	52,256	N/A
base-parity	5.56 (-1%)	N/A	160	96.0	N/A
root-parity	33.3	N/A	69,084	96.0	N/A
base-rollup	2,858	N/A	187,817	664	N/A
root-rollup	38.6 (-1%)	N/A	54,525	716	N/A
public-kernel-setup	96.5 (-2%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	104	N/A	103,599	71,222	N/A
public-kernel-tail	575 (-1%)	N/A	409,190	16,414	N/A
private-kernel-reset-small	490 (-1%)	N/A	66,085	45,629	N/A
private-kernel-tail-to-public	1,048 (+3%)	672 (+2%)	492,960	1,697	N/A
public-kernel-teardown	91.9 (-1%)	N/A	104,005	71,222	N/A
merge-rollup	19.3 (+1%)	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	68,767 (+4%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	423 (-1%)
FeeJuice:deploy	1,376	11,731	391 (-1%)
SchnorrAccount:constructor	1,312	11,731	105
SchnorrAccount:entrypoint	2,304	11,731	431
Token:privately_mint_private_note	1,280	11,731	142 (+2%)
FPC:fee_entrypoint_public	1,344	11,731	29.3 (+8%)
Token:transfer	1,312	11,731	271
Benchmarking:create_note	1,344	11,731	100
SchnorrAccount:verify_private_authwit	1,280	11,731	27.6
Token:unshield	1,376	11,731	552 (-2%)
FPC:fee_entrypoint_private	1,376	11,731	754 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	54.9 (-5%)	8,139
FeeJuice:set_portal	11.0 (+2%)	2,362
Token:constructor	90.3 (+12%)	31,107
FPC:constructor	54.1 (+2%)	22,380
FeeJuice:mint_public	38.6 (+1%)	6,150
Token:mint_public	42.8 (-5%)	11,720
Token:assert_minter_and_mint	68.2 (-1%)	8,028
AuthRegistry:set_authorized	36.6 (-11%)	4,537
FPC:prepare_fee	236 (-5%)	8,812
Token:transfer_public	30.9 (+9%)	47,358
FPC:pay_refund	56.3 (-4%)	12,082
Benchmarking:increment_balance	974	7,450
Token:_increase_public_balance	38.4 (-3%)	8,960
FPC:pay_refund_with_shielded_rebate	68.5 (+3%)	12,631

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.162 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.21	3.88 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (-1%)	0.109 (-3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5	17.6 (-5%)	30.7 (-3%)	59.0 (-4%)	113
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110 (-1%)	0.102 (-4%)	0.100 (-3%)	0.101 (-4%)	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4 (-2%)	25.9 (-1%)	43.4 (-2%)	82.8 (-2%)	161
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (-3%)	0.104 (-1%)	0.105 (-2%)	0.102 (-2%)	0.102
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.4 (-2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105 (-3%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[Maddiaa0]

good riddance

[Maddiaa0]

the doc comments have been lost, as part of the deletion of the interface

[LHerskind]

Can you elaborate a bit more?

The comments are gone because they were on the interface and you would like them to be added here? I did not move those as I thought the comments were not needed as the functions in here were already undocumented 🤷

[Maddiaa0]

Overall looks great, only comment is the loss of some of the doc comments

[just-mitch]

Is there an issue to fix this?

[LHerskind]

What do you mean fix it? There is a tiny "diff" when slots are missed, but you don't really know if it will be missed or not before anything have even been broadcast so not sure how you would fix it.

The case where it is missed could likely handle the timing slightly better to compute the next potential block, but as long as there are plenty other issues it seems like a very tiny thing but can create an issue for it 🤷