fix: cli l1-chain-id option #7490

spypsy · 2024-07-16T10:30:16Z

Please read contributing guidelines and remove this line.

alexghr · 2024-07-16T10:55:50Z

yarn-project/cli/src/cmds/infrastructure/index.ts

    .action(async options => {
      const { bootstrap } = await import('./bootstrap.js');
-      await bootstrap(options.rpcUrl, log);
+      await bootstrap(options.rpcUrl, options.chainId, log);


I think this should be options.l1ChainId, but I might be wrong

PhilWindle

Just the comment left by @alexghr

github-actions · 2024-07-16T12:22:03Z

Changes to circuit sizes

Generated at commit: b03f652c800607b4b31f7605b7532f8a3f2b5306, compared to commit: 0c7459b77b772f0868ba0216ad249cbf2fe4e1ef

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init	+1 ❌	+0.00%	+1 ❌	+0.00%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init	26,091 (+1)	+0.00%	45,263 (+1)	+0.00%

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.7</summary> ## [0.46.7](aztec-package-v0.46.6...aztec-package-v0.46.7) (2024-07-16) ### Features * Devnet updates ([#7421](#7421)) ([103f099](103f099)) ### Bug Fixes * Cli l1-chain-id option ([#7490](#7490)) ([307bc57](307bc57)) ### Miscellaneous * Turn on elaborator ([#7451](#7451)) ([0599500](0599500)) </details> <details><summary>barretenberg.js: 0.46.7</summary> ## [0.46.7](barretenberg.js-v0.46.6...barretenberg.js-v0.46.7) (2024-07-16) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.7</summary> ## [0.46.7](aztec-packages-v0.46.6...aztec-packages-v0.46.7) (2024-07-16) ### Features * Add unconstrained context to txe ([#7448](#7448)) ([699fb79](699fb79)) * Add unconstrained getters to sharedmutable ([#7429](#7429)) ([c0ff566](c0ff566)) * Devnet updates ([#7421](#7421)) ([103f099](103f099)) * Point::fromXandSign(...) ([#7455](#7455)) ([225c6f6](225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](#7492)) ([f1216a7](f1216a7)) * Cli l1-chain-id option ([#7490](#7490)) ([307bc57](307bc57)) * Don't pass secrets to earthly-ci 'publish docs' command ([#7481](#7481)) ([a3f6feb](a3f6feb)) * Fix msg_sender direct call exploit ([#7404](#7404)) ([1dcae45](1dcae45)) * Missing NoteSelector from JSON RPC proxies ([#7493](#7493)) ([b209fad](b209fad)) * **pxe:** Best effort noir call stack generation ([#7336](#7336)) ([0c7459b](0c7459b)) * Validate gas used ([#7459](#7459)) ([6dc7598](6dc7598)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](#7475)) ([1a6c7f2](1a6c7f2)) * Checking compute_encrypted_note_log against TS impl ([#7491](#7491)) ([1e8a597](1e8a597)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](#7479)) ([457a115](457a115)) * Replace relative paths to noir-protocol-circuits ([71960d4](71960d4)) * Turn on elaborator ([#7451](#7451)) ([0599500](0599500)) </details> <details><summary>barretenberg: 0.46.7</summary> ## [0.46.7](barretenberg-v0.46.6...barretenberg-v0.46.7) (2024-07-16) ### Features * Point::fromXandSign(...) ([#7455](#7455)) ([225c6f6](225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](#7492)) ([f1216a7](f1216a7)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](#7475)) ([1a6c7f2](1a6c7f2)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](#7479)) ([457a115](457a115)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@aztec-package-v0.46.6...aztec-package-v0.46.7) (2024-07-16) ### Features * Devnet updates ([#7421](AztecProtocol/aztec-packages#7421)) ([103f099](AztecProtocol/aztec-packages@103f099)) ### Bug Fixes * Cli l1-chain-id option ([#7490](AztecProtocol/aztec-packages#7490)) ([307bc57](AztecProtocol/aztec-packages@307bc57)) ### Miscellaneous * Turn on elaborator ([#7451](AztecProtocol/aztec-packages#7451)) ([0599500](AztecProtocol/aztec-packages@0599500)) </details> <details><summary>barretenberg.js: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@barretenberg.js-v0.46.6...barretenberg.js-v0.46.7) (2024-07-16) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@aztec-packages-v0.46.6...aztec-packages-v0.46.7) (2024-07-16) ### Features * Add unconstrained context to txe ([#7448](AztecProtocol/aztec-packages#7448)) ([699fb79](AztecProtocol/aztec-packages@699fb79)) * Add unconstrained getters to sharedmutable ([#7429](AztecProtocol/aztec-packages#7429)) ([c0ff566](AztecProtocol/aztec-packages@c0ff566)) * Devnet updates ([#7421](AztecProtocol/aztec-packages#7421)) ([103f099](AztecProtocol/aztec-packages@103f099)) * Point::fromXandSign(...) ([#7455](AztecProtocol/aztec-packages#7455)) ([225c6f6](AztecProtocol/aztec-packages@225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](AztecProtocol/aztec-packages#7492)) ([f1216a7](AztecProtocol/aztec-packages@f1216a7)) * Cli l1-chain-id option ([#7490](AztecProtocol/aztec-packages#7490)) ([307bc57](AztecProtocol/aztec-packages@307bc57)) * Don't pass secrets to earthly-ci 'publish docs' command ([#7481](AztecProtocol/aztec-packages#7481)) ([a3f6feb](AztecProtocol/aztec-packages@a3f6feb)) * Fix msg_sender direct call exploit ([#7404](AztecProtocol/aztec-packages#7404)) ([1dcae45](AztecProtocol/aztec-packages@1dcae45)) * Missing NoteSelector from JSON RPC proxies ([#7493](AztecProtocol/aztec-packages#7493)) ([b209fad](AztecProtocol/aztec-packages@b209fad)) * **pxe:** Best effort noir call stack generation ([#7336](AztecProtocol/aztec-packages#7336)) ([0c7459b](AztecProtocol/aztec-packages@0c7459b)) * Validate gas used ([#7459](AztecProtocol/aztec-packages#7459)) ([6dc7598](AztecProtocol/aztec-packages@6dc7598)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](AztecProtocol/aztec-packages#7475)) ([1a6c7f2](AztecProtocol/aztec-packages@1a6c7f2)) * Checking compute_encrypted_note_log against TS impl ([#7491](AztecProtocol/aztec-packages#7491)) ([1e8a597](AztecProtocol/aztec-packages@1e8a597)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](AztecProtocol/aztec-packages#7479)) ([457a115](AztecProtocol/aztec-packages@457a115)) * Replace relative paths to noir-protocol-circuits ([71960d4](AztecProtocol/aztec-packages@71960d4)) * Turn on elaborator ([#7451](AztecProtocol/aztec-packages#7451)) ([0599500](AztecProtocol/aztec-packages@0599500)) </details> <details><summary>barretenberg: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@barretenberg-v0.46.6...barretenberg-v0.46.7) (2024-07-16) ### Features * Point::fromXandSign(...) ([#7455](AztecProtocol/aztec-packages#7455)) ([225c6f6](AztecProtocol/aztec-packages@225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](AztecProtocol/aztec-packages#7492)) ([f1216a7](AztecProtocol/aztec-packages@f1216a7)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](AztecProtocol/aztec-packages#7475)) ([1a6c7f2](AztecProtocol/aztec-packages@1a6c7f2)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](AztecProtocol/aztec-packages#7479)) ([457a115](AztecProtocol/aztec-packages@457a115)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

spypsy and others added 30 commits June 20, 2024 18:53

chore: 1st attempt at automatic devnet deployment

acc1c8f

fix FULL_IMAGE var

d3b6a29

fix missing vars

e214015

rm contract address vars

1a45de7

fix deploy p2p

368cb6e

fix ecs name

d38fe6e

hardcode fork url

26fd7e6

force new deployments

80253eb

hardcode aztec-dev in tf file

16fe39b

separate node - prover terraforms

4ed2e5b

add data resources

cdfd127

add provider block

7e20a58

merge with master

b88a3ea

Merge branch 'master' into devnet

a5d45bf

undo formatting

c19aae1

undo formatting again

38bc061

cancel-in-progress

a04678a

fix ecs task def name

cf32b29

fix aws_ecs_service name ref

2aa4eb0

fix container names

b400d3b

PR fixes

bf8c939

remove ref from main.tf

543f660

use deploy_tag again for fork url

898388c

feat: deploy L1 contracts on GA (#7262)

ce09a75

chore: redeploy L1 contracts (#7263)

e1a9b5d

fix: fetch-depth 0 (#7264)

2bd87c1

chore: redeploy devnet (#7265)

7afe0d6

chore: redeploy & log (#7266)

987ba1a

fix: use result key (#7267)

1227447

fix: setup-action (#7268)

49170e4

spypsy and others added 13 commits July 11, 2024 15:00

Merge branch 'master' into devnet

c715472

PR Fixes

ad33b3a

merge with master

4804493

Remove old index.ts

55c88fb

clarify L1 chain ID

5fe445b

Merge branch 'master' into devnet

13e2f22

don't pass secrets

a76cb2d

pass chainId in bootstrap

0910078

redeploy fork, contracts

04a57ee

build & deploy fork image

2c982d6

merge with master

39450a9

fix chain-id arg

770fe02

Merge branch 'master' into devnet

95a0230

spypsy marked this pull request as ready for review July 16, 2024 10:39

redeploy

1c300ac

spypsy changed the title ~~fix: cli l1-chain-id cli option~~ fix: cli l1-chain-id option Jul 16, 2024

alexghr reviewed Jul 16, 2024

View reviewed changes

PhilWindle approved these changes Jul 16, 2024

View reviewed changes

spypsy and others added 5 commits July 16, 2024 11:08

fix options.l1ChainId

d1b7029

ensure number chainId

e165800

fix req chainId

9ec7eee

missing config val

cd61415

Merge branch 'master' into devnet

85c4063

PhilWindle merged commit 307bc57 into master Jul 16, 2024
95 checks passed

PhilWindle deleted the devnet branch July 16, 2024 13:25

AztecBot mentioned this pull request Jul 16, 2024

chore(master): Release 0.46.7 #7480

Merged

spypsy restored the devnet branch July 16, 2024 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cli l1-chain-id option #7490

fix: cli l1-chain-id option #7490

spypsy commented Jul 16, 2024

alexghr Jul 16, 2024 •

edited

Loading

PhilWindle left a comment

github-actions bot commented Jul 16, 2024

fix: cli l1-chain-id option #7490

fix: cli l1-chain-id option #7490

Conversation

spypsy commented Jul 16, 2024

alexghr Jul 16, 2024 • edited Loading

Choose a reason for hiding this comment

PhilWindle left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 16, 2024

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

alexghr Jul 16, 2024 •

edited

Loading