feat: add unconstrained getters to sharedmutable #7429

sklppy88 · 2024-07-10T17:17:05Z

No description provided.

sklppy88 · 2024-07-10T17:17:21Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

AztecBot · 2024-07-10T17:51:40Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:assert_minter_and_mint): 86.0 (+75%)
protocol_circuit_proving_time_in_ms (base-parity): 1,412 (-29%)
protocol_circuit_proving_time_in_ms (root-parity): 31,294 (-38%)
protocol_circuit_proving_time_in_ms (public-kernel-teardown): 18,317 (-19%)
protocol_circuit_proving_time_in_ms (root-rollup): 28,957 (-29%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,578 (+3%)	1,483 (+1%)	672 (+1%)	719 (-1%)	731
proof_construction_time_sha256_30_ms	10,994 (+1%)	2,973	1,305	1,372	1,403 (+1%)
proof_construction_time_sha256_100_ms	41,778	11,445 (+1%)	5,317 (+5%)	5,588 (-2%)	5,092
proof_construction_time_poseidon_hash_ms	75.0	34.0	34.0	56.0 (-2%)	90.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,452 (+1%)	407 (+1%)	195 (+1%)	214	259 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,378 (+1%)	1,483 (+2%)	646 (+1%)	718 (+4%)	707

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,600 (+1%)	6,592	6,600
l1_rollup_execution_gas	583,062	583,205	583,364
l2_block_processing_time_in_ms	814 (+1%)	1,494 (-1%)	2,907
l2_block_building_time_in_ms	13,567 (-2%)	26,723 (-1%)	52,492 (-1%)
l2_block_rollup_simulation_time_in_ms	13,567 (-2%)	26,722 (-1%)	52,492 (-1%)
l2_block_public_tx_process_time_in_ms	11,398 (-2%)	24,322 (-1%)	50,046 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,414 (-1%)	10,379 (-1%)
node_database_size_in_bytes	12,456,016	16,478,288
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	119 (-2%)	402 (+1%)	21,732	54,085	N/A	N/A	N/A	N/A
private-kernel-inner	234 (-1%)	724 (+2%)	81,199	54,264	N/A	N/A	N/A	N/A
private-kernel-tail	1,128 (-1%)	2,559 (+2%)	61,808	61,554	N/A	N/A	N/A	N/A
base-parity	6.86 (+1%)	823 (-5%)	160	96.0	⚠️ 1,412 (-29%)	12,676	3.00	131,072
root-parity	111	122 (+4%)	64,860	96.0	⚠️ 31,294 (-38%)	12,676	3.00	4,194,304
base-rollup	4,323 (-1%)	4,918	180,315	632	44,604 (-8%)	13,476	28.0	4,194,304
root-rollup	160 (-1%)	125 (+3%)	51,261	652	⚠️ 28,957 (-29%)	13,412	26.0	4,194,304
public-kernel-setup	195 (-4%)	2,447 (+1%)	112,536	80,310	18,768 (-15%)	118,916	3,323	2,097,152
public-kernel-app-logic	153 (-1%)	3,368 (+3%)	112,536	80,310	10,241 (+2%)	118,916	3,323	1,048,576
public-kernel-tail	914 (-1%)	26,641 (-2%)	409,413	10,046	68,729 (-6%)	24,868	384	8,388,608
private-kernel-reset-tiny	308 (-1%)	1,012 (+1%)	77,007	53,954	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	6,893 (+1%)	2,905 (+3%)	777,415	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	140 (-3%)	3,326 (+2%)	112,536	80,310	⚠️ 18,317 (-19%)	118,916	3,323	2,097,152
merge-rollup	59.6 (-2%)	N/A	33,566	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	164,123 (+2%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	9,344	414 (+1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	26.3 (+1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	661 (+1%)	N/A	N/A
GasToken:deploy	1,344	9,344	585 (-1%)	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	462	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	813	N/A	N/A
Token:privately_mint_private_note	1,248	9,344	533 (+1%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	104 (+1%)	N/A	N/A
Token:transfer	1,280	9,344	1,536	N/A	N/A
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	2,157 (+2%)
FPC:prepare_fee (avm)	26,664	N/A	N/A	95,456	2,891 (+2%)
Token:transfer_public (avm)	42,914	N/A	N/A	95,456	3,303 (+3%)
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,856 (+2%)
FPC:pay_refund (avm)	36,829	N/A	N/A	95,424	11,134 (+1%)
Benchmarking:create_note	1,312	9,344	463 (-1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	44.7 (-3%)	N/A	N/A
Token:unshield	1,344	9,344	1,258 (-2%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,644 (-1%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	103 (+4%)	13,790
GasToken:set_portal	15.3 (+19%)	3,339
Token:constructor	126 (-2%)	23,692
FPC:constructor	94.7 (+4%)	13,592
GasToken:mint_public	83.1 (+1%)	10,158
Token:mint_public	335 (-4%)	19,034
Token:assert_minter_and_mint	⚠️ 86.0 (+75%)	12,925
AuthRegistry:set_authorized	46.5 (-3%)	7,812
FPC:prepare_fee	107 (-12%)	15,062
Token:transfer_public	46.2 (+7%)	31,218
FPC:pay_refund	136 (+6%)	25,260
Benchmarking:increment_balance	1,377 (-1%)	15,267
Token:_increase_public_balance	16.7 (-9%)	15,006
FPC:pay_refund_with_shielded_rebate	188 (-7%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.162 (+6%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.8	17.6 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.626	0.540	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	50.5	80.2	140	260	505
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.517	0.494	0.481	0.471 (-1%)	0.471
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	62.4	118 (-1%)	196	373 (-1%)	744
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.528	0.530	0.511	0.506	0.509
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	76.7	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.546	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	76,837	667,838

Transaction size based on fee payment method

| Metric | |
| - | |

nventuro

In order to properly close #7326, shouldn't we also update the private token so that it can perform the balance read in an unconstrained context instead of privately? I think that'll require that we also add these fns to the SharedMutablePrivateGetter, since iirc the issue had to do with inspection of the key registry.

nventuro · 2024-07-11T15:02:58Z

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/shared_mutable.nr

+    pub fn get_current_value_in_unconstrained(self) -> T {
+        let block_number = self.context.block_number() as u32;
+        self.read_value_change().get_current_at(block_number)
+    }
+
+    pub fn get_current_delay_in_unconstrained(self) -> u32 {
+        let block_number = self.context.block_number() as u32;
+        self.read_delay_change().get_current(block_number)
+    }
+
+    pub fn get_scheduled_value_in_unconstrained(self) -> (T, u32) {
+        self.read_value_change().get_scheduled()
+    }
+
+    pub fn get_scheduled_delay_in_unconstrained(self) -> (u32, u32) {
+        self.read_delay_change().get_scheduled()
+    }
+
+    fn read_value_change(self) -> ScheduledValueChange<T> {
+        self.context.storage_read(self.get_value_change_storage_slot())
+    }
+
+    fn read_delay_change(self) -> ScheduledDelayChange<INITIAL_DELAY> {
+        self.context.storage_read(self.get_delay_change_storage_slot())
+    }
+}


These fns should be unconstrained, both to flag that the execution is not constrained, and to avoid issues that might arise if we end up passing mut& here.

In the future this will be more obvious because noir-lang/noir#4442 would require that you place this in an unsafe block, and you'd go 'oh i don't actually want to do that'.

Good shout, thanks for the heads up !

nventuro · 2024-07-11T15:05:09Z

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/shared_mutable.nr

+    pub fn get_current_value_in_unconstrained(self) -> T {
+        let block_number = self.context.block_number() as u32;
+        self.read_value_change().get_current_at(block_number)
+    }
+
+    pub fn get_current_delay_in_unconstrained(self) -> u32 {
+        let block_number = self.context.block_number() as u32;
+        self.read_delay_change().get_current(block_number)
+    }
+
+    pub fn get_scheduled_value_in_unconstrained(self) -> (T, u32) {
+        self.read_value_change().get_scheduled()
+    }
+
+    pub fn get_scheduled_delay_in_unconstrained(self) -> (u32, u32) {
+        self.read_delay_change().get_scheduled()
+    }
+
+    fn read_value_change(self) -> ScheduledValueChange<T> {
+        self.context.storage_read(self.get_value_change_storage_slot())
+    }
+
+    fn read_delay_change(self) -> ScheduledDelayChange<INITIAL_DELAY> {
+        self.context.storage_read(self.get_delay_change_storage_slot())
+    }


I don't think we have proper support in txe to create an unconstrained context and therefore test these that way, but that might make sense.

Yep when I first did this, I looked at adding txe tests, but it seems like it doesn't support unconstrained yet. I'll add another issue for adding unconstrained support to the TXE.

benesjan · 2024-07-13T09:01:38Z

@nventuro I plan on nuking basically all of private token and replace it with the normal token and just extend it by the 2 special refund functions so it doesn't make sense to invest time in it.

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/shared_mutable.nr

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/test.nr

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/shared_mutable.nr

…red_mutable.nr Co-authored-by: Nicolás Venturo <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.7</summary> ## [0.46.7](aztec-package-v0.46.6...aztec-package-v0.46.7) (2024-07-16) ### Features * Devnet updates ([#7421](#7421)) ([103f099](103f099)) ### Bug Fixes * Cli l1-chain-id option ([#7490](#7490)) ([307bc57](307bc57)) ### Miscellaneous * Turn on elaborator ([#7451](#7451)) ([0599500](0599500)) </details> <details><summary>barretenberg.js: 0.46.7</summary> ## [0.46.7](barretenberg.js-v0.46.6...barretenberg.js-v0.46.7) (2024-07-16) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.7</summary> ## [0.46.7](aztec-packages-v0.46.6...aztec-packages-v0.46.7) (2024-07-16) ### Features * Add unconstrained context to txe ([#7448](#7448)) ([699fb79](699fb79)) * Add unconstrained getters to sharedmutable ([#7429](#7429)) ([c0ff566](c0ff566)) * Devnet updates ([#7421](#7421)) ([103f099](103f099)) * Point::fromXandSign(...) ([#7455](#7455)) ([225c6f6](225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](#7492)) ([f1216a7](f1216a7)) * Cli l1-chain-id option ([#7490](#7490)) ([307bc57](307bc57)) * Don't pass secrets to earthly-ci 'publish docs' command ([#7481](#7481)) ([a3f6feb](a3f6feb)) * Fix msg_sender direct call exploit ([#7404](#7404)) ([1dcae45](1dcae45)) * Missing NoteSelector from JSON RPC proxies ([#7493](#7493)) ([b209fad](b209fad)) * **pxe:** Best effort noir call stack generation ([#7336](#7336)) ([0c7459b](0c7459b)) * Validate gas used ([#7459](#7459)) ([6dc7598](6dc7598)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](#7475)) ([1a6c7f2](1a6c7f2)) * Checking compute_encrypted_note_log against TS impl ([#7491](#7491)) ([1e8a597](1e8a597)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](#7479)) ([457a115](457a115)) * Replace relative paths to noir-protocol-circuits ([71960d4](71960d4)) * Turn on elaborator ([#7451](#7451)) ([0599500](0599500)) </details> <details><summary>barretenberg: 0.46.7</summary> ## [0.46.7](barretenberg-v0.46.6...barretenberg-v0.46.7) (2024-07-16) ### Features * Point::fromXandSign(...) ([#7455](#7455)) ([225c6f6](225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](#7492)) ([f1216a7](f1216a7)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](#7475)) ([1a6c7f2](1a6c7f2)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](#7479)) ([457a115](457a115)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@aztec-package-v0.46.6...aztec-package-v0.46.7) (2024-07-16) ### Features * Devnet updates ([#7421](AztecProtocol/aztec-packages#7421)) ([103f099](AztecProtocol/aztec-packages@103f099)) ### Bug Fixes * Cli l1-chain-id option ([#7490](AztecProtocol/aztec-packages#7490)) ([307bc57](AztecProtocol/aztec-packages@307bc57)) ### Miscellaneous * Turn on elaborator ([#7451](AztecProtocol/aztec-packages#7451)) ([0599500](AztecProtocol/aztec-packages@0599500)) </details> <details><summary>barretenberg.js: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@barretenberg.js-v0.46.6...barretenberg.js-v0.46.7) (2024-07-16) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@aztec-packages-v0.46.6...aztec-packages-v0.46.7) (2024-07-16) ### Features * Add unconstrained context to txe ([#7448](AztecProtocol/aztec-packages#7448)) ([699fb79](AztecProtocol/aztec-packages@699fb79)) * Add unconstrained getters to sharedmutable ([#7429](AztecProtocol/aztec-packages#7429)) ([c0ff566](AztecProtocol/aztec-packages@c0ff566)) * Devnet updates ([#7421](AztecProtocol/aztec-packages#7421)) ([103f099](AztecProtocol/aztec-packages@103f099)) * Point::fromXandSign(...) ([#7455](AztecProtocol/aztec-packages#7455)) ([225c6f6](AztecProtocol/aztec-packages@225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](AztecProtocol/aztec-packages#7492)) ([f1216a7](AztecProtocol/aztec-packages@f1216a7)) * Cli l1-chain-id option ([#7490](AztecProtocol/aztec-packages#7490)) ([307bc57](AztecProtocol/aztec-packages@307bc57)) * Don't pass secrets to earthly-ci 'publish docs' command ([#7481](AztecProtocol/aztec-packages#7481)) ([a3f6feb](AztecProtocol/aztec-packages@a3f6feb)) * Fix msg_sender direct call exploit ([#7404](AztecProtocol/aztec-packages#7404)) ([1dcae45](AztecProtocol/aztec-packages@1dcae45)) * Missing NoteSelector from JSON RPC proxies ([#7493](AztecProtocol/aztec-packages#7493)) ([b209fad](AztecProtocol/aztec-packages@b209fad)) * **pxe:** Best effort noir call stack generation ([#7336](AztecProtocol/aztec-packages#7336)) ([0c7459b](AztecProtocol/aztec-packages@0c7459b)) * Validate gas used ([#7459](AztecProtocol/aztec-packages#7459)) ([6dc7598](AztecProtocol/aztec-packages@6dc7598)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](AztecProtocol/aztec-packages#7475)) ([1a6c7f2](AztecProtocol/aztec-packages@1a6c7f2)) * Checking compute_encrypted_note_log against TS impl ([#7491](AztecProtocol/aztec-packages#7491)) ([1e8a597](AztecProtocol/aztec-packages@1e8a597)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](AztecProtocol/aztec-packages#7479)) ([457a115](AztecProtocol/aztec-packages@457a115)) * Replace relative paths to noir-protocol-circuits ([71960d4](AztecProtocol/aztec-packages@71960d4)) * Turn on elaborator ([#7451](AztecProtocol/aztec-packages#7451)) ([0599500](AztecProtocol/aztec-packages@0599500)) </details> <details><summary>barretenberg: 0.46.7</summary> ## [0.46.7](AztecProtocol/aztec-packages@barretenberg-v0.46.6...barretenberg-v0.46.7) (2024-07-16) ### Features * Point::fromXandSign(...) ([#7455](AztecProtocol/aztec-packages#7455)) ([225c6f6](AztecProtocol/aztec-packages@225c6f6)) ### Bug Fixes * **avm:** Update generated verifier ([#7492](AztecProtocol/aztec-packages#7492)) ([f1216a7](AztecProtocol/aztec-packages@f1216a7)) ### Miscellaneous * **avm:** More stats and codegen cleanup ([#7475](AztecProtocol/aztec-packages#7475)) ([1a6c7f2](AztecProtocol/aztec-packages@1a6c7f2)) * Included subrelation witness degrees in the relations relevant to zk-sumcheck ([#7479](AztecProtocol/aztec-packages#7479)) ([457a115](AztecProtocol/aztec-packages@457a115)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sklppy88 changed the title ~~init~~ feat: add unconstrained getters to sharedmutable Jul 10, 2024

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch 2 times, most recently from 9b06af6 to acf5412 Compare July 10, 2024 21:25

sklppy88 requested review from just-mitch, nventuro and benesjan and removed request for just-mitch July 10, 2024 22:02

sklppy88 marked this pull request as ready for review July 11, 2024 14:17

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch from acf5412 to 15cb689 Compare July 11, 2024 14:45

nventuro reviewed Jul 11, 2024

View reviewed changes

sklppy88 mentioned this pull request Jul 11, 2024

Add support for unconstrained execution in TXE #7446

Open

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch from 15cb689 to f64d495 Compare July 11, 2024 17:11

sklppy88 changed the base branch from master to ek/feat/add-unconstrained-context-to-txe July 11, 2024 17:11

sklppy88 mentioned this pull request Jul 11, 2024

feat: add unconstrained context to txe #7448

Merged

sklppy88 force-pushed the ek/feat/add-unconstrained-context-to-txe branch from 886dd82 to f6ab485 Compare July 11, 2024 22:30

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch from f64d495 to 279a5d1 Compare July 11, 2024 22:30

sklppy88 force-pushed the ek/feat/add-unconstrained-context-to-txe branch from f6ab485 to 53d7abe Compare July 12, 2024 16:35

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch from 279a5d1 to 027d99d Compare July 12, 2024 16:35

sklppy88 force-pushed the ek/feat/add-unconstrained-context-to-txe branch from 53d7abe to 71f7739 Compare July 12, 2024 16:36

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch 2 times, most recently from 0378827 to 7471bf1 Compare July 12, 2024 20:02

sklppy88 mentioned this pull request Jul 12, 2024

feat: refactor shared mutable to include private and unconstrained getters #7465

Closed

sklppy88 force-pushed the ek/feat/add-unconstrained-context-to-txe branch 2 times, most recently from 0ab3f4d to 7a31314 Compare July 15, 2024 18:20

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch from 7471bf1 to 77b0685 Compare July 15, 2024 19:41

This was referenced Jul 15, 2024

feat: add unconstrained context to key getters #7486

Closed

feat: refactoring key getters #7487

Closed

Base automatically changed from ek/feat/add-unconstrained-context-to-txe to master July 15, 2024 20:31

nventuro reviewed Jul 15, 2024

View reviewed changes

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/shared_mutable.nr Show resolved Hide resolved

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch 2 times, most recently from f70bcaf to 2deb1bb Compare July 15, 2024 21:14

nventuro reviewed Jul 15, 2024

View reviewed changes

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/test.nr Outdated Show resolved Hide resolved

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch 2 times, most recently from 556fe66 to e6fedda Compare July 15, 2024 22:17

init

9a2fb8b

sklppy88 force-pushed the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch from e6fedda to 9a2fb8b Compare July 15, 2024 22:23

nventuro reviewed Jul 15, 2024

View reviewed changes

noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/shared_mutable.nr Outdated Show resolved Hide resolved

nventuro approved these changes Jul 15, 2024

View reviewed changes

Update noir-projects/aztec-nr/aztec/src/state_vars/shared_mutable/sha…

f05f981

…red_mutable.nr Co-authored-by: Nicolás Venturo <[email protected]>

sklppy88 merged commit c0ff566 into master Jul 15, 2024
91 checks passed

sklppy88 deleted the ek/feat/7326/add-unconstrained-getters-for-shared-mutable branch July 15, 2024 23:33

AztecBot mentioned this pull request Jul 15, 2024

chore(master): Release 0.46.7 #7480

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add unconstrained getters to sharedmutable #7429

feat: add unconstrained getters to sharedmutable #7429

sklppy88 commented Jul 10, 2024 •

edited

Loading

sklppy88 commented Jul 10, 2024 •

edited

Loading

AztecBot commented Jul 10, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

nventuro left a comment

nventuro Jul 11, 2024

sklppy88 Jul 11, 2024

nventuro Jul 11, 2024

sklppy88 Jul 11, 2024

benesjan commented Jul 13, 2024

feat: add unconstrained getters to sharedmutable #7429

feat: add unconstrained getters to sharedmutable #7429

Conversation

sklppy88 commented Jul 10, 2024 • edited Loading

sklppy88 commented Jul 10, 2024 • edited Loading

AztecBot commented Jul 10, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

nventuro left a comment

Choose a reason for hiding this comment

nventuro Jul 11, 2024

Choose a reason for hiding this comment

sklppy88 Jul 11, 2024

Choose a reason for hiding this comment

nventuro Jul 11, 2024

Choose a reason for hiding this comment

sklppy88 Jul 11, 2024

Choose a reason for hiding this comment

benesjan commented Jul 13, 2024

sklppy88 commented Jul 10, 2024 •

edited

Loading

sklppy88 commented Jul 10, 2024 •

edited

Loading

AztecBot commented Jul 10, 2024 •

edited

Loading