refactor: replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` #7382

benesjan · 2024-07-08T09:22:57Z

Decided to tackle this now because it became inconvenient when tackling this - needed to implement Serialize trait for it to work and at that point it felt retarded to just not replace the duplicate GrumpkinPoint.

benesjan · 2024-07-08T09:23:12Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

github-actions · 2024-07-08T09:52:34Z

Changes to circuit sizes

Generated at commit: da692ee799f6b92dd8629d36327eb88f5f578029, compared to commit: 046af9bb3c25d738ba5349793bc63d8512081714

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init_simulated	0 ➖	0.00%	+64 ❌	+2.86%
private_kernel_inner_simulated	0 ➖	0.00%	+64 ❌	+2.86%
private_kernel_reset_simulated	0 ➖	0.00%	+64 ❌	+2.86%
private_kernel_reset_simulated_big	0 ➖	0.00%	+64 ❌	+2.86%
private_kernel_reset_simulated_medium	0 ➖	0.00%	+64 ❌	+2.86%
private_kernel_reset_simulated_small	0 ➖	0.00%	+64 ❌	+2.86%
private_kernel_tail_to_public_simulated	0 ➖	0.00%	+64 ❌	+1.96%
public_kernel_app_logic_simulated	0 ➖	0.00%	+64 ❌	+1.96%
public_kernel_setup_simulated	0 ➖	0.00%	+64 ❌	+1.96%
public_kernel_teardown_simulated	0 ➖	0.00%	+64 ❌	+1.96%
private_kernel_reset_small	+1,412 ❌	+2.26%	+11,857 ❌	+1.43%
private_kernel_inner	+1,963 ❌	+4.41%	+14,519 ❌	+1.39%
private_kernel_reset_medium	+1,612 ❌	+2.23%	+12,055 ❌	+1.27%
private_kernel_reset_big	+2,012 ❌	+2.18%	+12,579 ❌	+1.05%
private_kernel_init	+1,025 ❌	+3.99%	+3,435 ❌	+0.90%
private_kernel_tail	+74 ❌	+0.35%	+10,351 ❌	+0.83%
private_kernel_reset	+2,812 ❌	+2.13%	+13,627 ❌	+0.80%
public_kernel_setup	+128 ❌	+0.07%	+10,270 ❌	+0.78%
public_kernel_app_logic	+128 ❌	+0.05%	+10,271 ❌	+0.74%
public_kernel_teardown	+128 ❌	+0.05%	+10,271 ❌	+0.74%
private_kernel_tail_to_public	+202 ❌	+0.05%	+10,543 ❌	+0.63%
public_kernel_tail	+64 ❌	+0.01%	+10,143 ❌	+0.23%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init_simulated	1 (0)	0.00%	2,305 (+64)	+2.86%
private_kernel_inner_simulated	1 (0)	0.00%	2,305 (+64)	+2.86%
private_kernel_reset_simulated	1 (0)	0.00%	2,305 (+64)	+2.86%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,305 (+64)	+2.86%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,305 (+64)	+2.86%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,305 (+64)	+2.86%
private_kernel_tail_to_public_simulated	1 (0)	0.00%	3,328 (+64)	+1.96%
public_kernel_app_logic_simulated	1 (0)	0.00%	3,328 (+64)	+1.96%
public_kernel_setup_simulated	1 (0)	0.00%	3,328 (+64)	+1.96%
public_kernel_teardown_simulated	1 (0)	0.00%	3,328 (+64)	+1.96%
private_kernel_reset_small	63,778 (+1,412)	+2.26%	840,198 (+11,857)	+1.43%
private_kernel_inner	46,434 (+1,963)	+4.41%	1,059,118 (+14,519)	+1.39%
private_kernel_reset_medium	73,973 (+1,612)	+2.23%	964,063 (+12,055)	+1.27%
private_kernel_reset_big	94,362 (+2,012)	+2.18%	1,212,000 (+12,579)	+1.05%
private_kernel_init	26,717 (+1,025)	+3.99%	383,262 (+3,435)	+0.90%
private_kernel_tail	21,468 (+74)	+0.35%	1,256,333 (+10,351)	+0.83%
private_kernel_reset	135,138 (+2,812)	+2.13%	1,707,872 (+13,627)	+0.80%
public_kernel_setup	182,877 (+128)	+0.07%	1,330,281 (+10,270)	+0.78%
public_kernel_app_logic	241,213 (+128)	+0.05%	1,393,960 (+10,271)	+0.74%
public_kernel_teardown	241,409 (+128)	+0.05%	1,394,199 (+10,271)	+0.74%
private_kernel_tail_to_public	444,067 (+202)	+0.05%	1,689,353 (+10,543)	+0.63%
public_kernel_tail	971,161 (+64)	+0.01%	4,418,594 (+10,143)	+0.23%

AztecBot · 2024-07-09T09:37:55Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:assert_minter_and_mint): 93.9 (+37%)
avm_simulation_time_ms (Token:_increase_public_balance): 15.9 (-75%)
avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 162 (+43%)
protocol_circuit_proving_time_in_ms (private-kernel-inner): 50,464 (+88%)
protocol_circuit_size_in_gates (private-kernel-inner): 2,097,152 (+100%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,762	1,555 (+1%)	705	746 (-1%)	773
proof_construction_time_sha256_30_ms	11,800	3,172 (+1%)	1,402	1,431 (-1%)	1,474 (+1%)
proof_construction_time_sha256_100_ms	43,921 (-1%)	12,110 (+2%)	5,453 (-2%)	5,394 (-3%)	5,357 (-2%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0 (+2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,529 (+1%)	420 (+1%)	200	220 (-1%)	263 (-3%)
proof_construction_time_poseidon_hash_100_ms	5,648 (+1%)	1,519	675	733 (+1%)	750

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,476	9,472	9,464
l1_rollup_execution_gas	613,504	613,651	613,794
l2_block_processing_time_in_ms	780 (+3%)	1,425	2,711
l2_block_building_time_in_ms	12,940	25,557	49,884
l2_block_rollup_simulation_time_in_ms	12,940	25,557	49,884
l2_block_public_tx_process_time_in_ms	10,892	23,326	47,643

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,120 (+1%)	9,985 (-1%)
node_database_size_in_bytes	12,406,864	16,187,472
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	109	433 (+4%)	15,730 (+12%)	20,002	55,022	76,256 (+3%)	2,316 (+3%)	524,288
private-kernel-inner	226 (+1%)	768 (+4%)	⚠️ 50,464 (+88%)	82,134	55,022	76,256 (+3%)	2,316 (+3%)	⚠️ 2,097,152 (+100%)
private-kernel-tail	1,046 (-3%)	2,508 (-1%)	44,793 (-10%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.33 (-2%)	908 (-4%)	2,527 (+5%)	160	96.0	2,240	3.00	131,072
root-parity	70.8	62.1 (+1%)	33,773 (-2%)	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,141	5,068 (-1%)	78,385 (-1%)	172,028	632	3,552	44.0	4,194,304
root-rollup	128 (-1%)	72.7 (-4%)	19,640 (-1%)	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	194 (+2%)	2,345 (-1%)	36,491 (-1%)	103,911	80,310	108,992 (+2%)	3,339 (+2%)	2,097,152
public-kernel-app-logic	147 (+1%)	3,351 (-1%)	36,831	103,911	80,310	108,992 (+2%)	3,339 (+2%)	2,097,152
public-kernel-tail	893 (-1%)	23,583 (-10%)	159,383	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	291 (-1%)	1,196 (-2%)	27,970 (+7%)	79,273	55,022	76,256 (+3%)	2,316 (+3%)	1,048,576
public-kernel-teardown	137 (+1%)	3,334 (-1%)	36,834 (-1%)	103,911	80,310	108,992 (+2%)	3,339 (+2%)	2,097,152
merge-rollup	40.3	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,802	49,072 (-9%)	N/A	N/A	108,992 (+2%)	3,339 (+2%)	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	398 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.4 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	670 (+2%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	567	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	511 (+4%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	857 (+4%)	16,352 (+3%)	5,087 (-2%)	131,072	444 (+4%)
Token:privately_mint_private_note	1,248	9,344	599 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	109 (+2%)	16,352 (+3%)	1,927 (+2%)	65,536	444 (+4%)
Token:transfer	1,280	9,344	1,773 (+7%)	16,352 (+3%)	11,282 (+7%)	524,288	444 (+4%)
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,730 (+3%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	3,112 (+6%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	3,848 (+1%)	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	3,013 (+2%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	19,194 (+5%)	N/A	N/A
Benchmarking:create_note	1,312	9,344	486 (+4%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	41.5 (-18%)	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,387 (+2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,803 (+3%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	78.4 (-1%)	13,790
GasToken:set_portal	12.0 (-5%)	3,339
Token:constructor	103 (-1%)	23,692
FPC:constructor	72.5	13,592
GasToken:mint_public	61.6	10,158
Token:mint_public	46.7 (-8%)	19,034
Token:assert_minter_and_mint	⚠️ 93.9 (+37%)	12,925
AuthRegistry:set_authorized	35.9 (+8%)	7,812
FPC:prepare_fee	114 (+13%)	15,062
Token:transfer_public	48.7 (+18%)	31,218
FPC:pay_refund	130 (+1%)	25,260
Benchmarking:increment_balance	1,317 (-1%)	15,267
Token:_increase_public_balance	⚠️ 15.9 (-75%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 162 (+43%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.152 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.603	0.515	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5	75.7 (-1%)	131	246	471
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.496	0.465 (-1%)	0.450	0.445	0.440
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.7	112 (+1%)	183 (+1%)	354	692
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.505	0.501	0.483 (+1%)	0.479	0.475
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.2	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.520	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,105	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

sklppy88

Very cool, nice change. Thanks for the unrelated cleanup too 🙏

Needed because some things are calculated in parallel.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.1</summary> ## [0.46.1](aztec-package-v0.46.0...aztec-package-v0.46.1) (2024-07-10) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.1</summary> ## [0.46.1](barretenberg.js-v0.46.0...barretenberg.js-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.1</summary> ## [0.46.1](aztec-packages-v0.46.0...aztec-packages-v0.46.1) (2024-07-10) ### Features * Apply `no_predicates` in stdlib (noir-lang/noir#5454) ([6237d96](6237d96)) * Lsp rename/find-all-references for globals (noir-lang/noir#5415) ([6237d96](6237d96)) * Lsp rename/find-all-references for local variables (noir-lang/noir#5439) ([6237d96](6237d96)) * Remove duplicated array reads at constant indices (noir-lang/noir#5445) ([6237d96](6237d96)) * Remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440) ([6237d96](6237d96)) ### Bug Fixes * Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) ([6237d96](6237d96)) * Added bb to noir-projects deps ([#7412](#7412)) ([6d3ed3a](6d3ed3a)) * Fix issue with unresolved results (noir-lang/noir#5453) ([6237d96](6237d96)) * Prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) ([6237d96](6237d96)) ### Miscellaneous * Replace relative paths to noir-protocol-circuits ([db45302](db45302)) * Replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` ([#7382](#7382)) ([5279695](5279695)) * Replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar` ([#7384](#7384)) ([a917198](a917198)) </details> <details><summary>barretenberg: 0.46.1</summary> ## [0.46.1](barretenberg-v0.46.0...barretenberg-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Automated pull of Noir development from [aztec-packages](https://github.com/AztecProtocol/aztec-packages). BEGIN_COMMIT_OVERRIDE feat: Sync from noir (AztecProtocol/aztec-packages#7400) refactor: replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar` (AztecProtocol/aztec-packages#7384) refactor: replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` (AztecProtocol/aztec-packages#7382) feat: Sync from noir (AztecProtocol/aztec-packages#7392) feat!: constant inputs for blackbox (AztecProtocol/aztec-packages#7222) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]> Co-authored-by: Tom French <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@aztec-package-v0.46.0...aztec-package-v0.46.1) (2024-07-10) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@barretenberg.js-v0.46.0...barretenberg.js-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@aztec-packages-v0.46.0...aztec-packages-v0.46.1) (2024-07-10) ### Features * Apply `no_predicates` in stdlib (noir-lang/noir#5454) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Lsp rename/find-all-references for globals (noir-lang/noir#5415) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Lsp rename/find-all-references for local variables (noir-lang/noir#5439) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Remove duplicated array reads at constant indices (noir-lang/noir#5445) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Remove redundant `EnableSideEffects` instructions (noir-lang/noir#5440) ([6237d96](AztecProtocol/aztec-packages@6237d96)) ### Bug Fixes * Account for the expected kind when resolving turbofish generics (noir-lang/noir#5448) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Added bb to noir-projects deps ([#7412](AztecProtocol/aztec-packages#7412)) ([6d3ed3a](AztecProtocol/aztec-packages@6d3ed3a)) * Fix issue with unresolved results (noir-lang/noir#5453) ([6237d96](AztecProtocol/aztec-packages@6237d96)) * Prevent `no_predicates` from removing predicates in calling function (noir-lang/noir#5452) ([6237d96](AztecProtocol/aztec-packages@6237d96)) ### Miscellaneous * Replace relative paths to noir-protocol-circuits ([db45302](AztecProtocol/aztec-packages@db45302)) * Replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` ([#7382](AztecProtocol/aztec-packages#7382)) ([5279695](AztecProtocol/aztec-packages@5279695)) * Replace usage of `GrumpkinPrivateKey` with `EmbeddedCurveScalar` ([#7384](AztecProtocol/aztec-packages#7384)) ([a917198](AztecProtocol/aztec-packages@a917198)) </details> <details><summary>barretenberg: 0.46.1</summary> ## [0.46.1](AztecProtocol/aztec-packages@barretenberg-v0.46.0...barretenberg-v0.46.1) (2024-07-10) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan changed the title ~~fix: replace usage of GrumpkinPoint with EmbeddedCurvePoint~~ refactor: replace usage of GrumpkinPoint with EmbeddedCurvePoint Jul 8, 2024

benesjan force-pushed the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch from 0fb6dbe to 5b0cc5f Compare July 8, 2024 09:45

benesjan mentioned this pull request Jul 8, 2024

refactor: replace usage of GrumpkinPrivateKey with EmbeddedCurveScalar #7384

Merged

benesjan force-pushed the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch 2 times, most recently from 7607ae2 to abc5bde Compare July 9, 2024 07:11

benesjan force-pushed the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch 4 times, most recently from df950c6 to 700a8d4 Compare July 9, 2024 13:27

benesjan mentioned this pull request Jul 9, 2024

refactor: private refund cleanup #7403

Merged

benesjan force-pushed the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch from 700a8d4 to 5c59713 Compare July 9, 2024 13:53

benesjan marked this pull request as ready for review July 9, 2024 14:49

benesjan requested review from fcarreiro and dbanks12 as code owners July 9, 2024 14:49

benesjan requested review from sklppy88 and removed request for fcarreiro and dbanks12 July 9, 2024 14:49

benesjan force-pushed the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch from 5c59713 to 4978dae Compare July 9, 2024 15:01

sklppy88 approved these changes Jul 9, 2024

View reviewed changes

fcarreiro and others added 8 commits July 9, 2024 17:33

chore(avm): make stats thread safe (#7393)

6cc91af

Needed because some things are calculated in parallel.

fix: replace usage of GrumpkinPoint with EmbeddedCurvePoint

70db4be

fix

c2220d9

fixes

b01473d

fixes

b866f73

WIP

c49ae3d

WIP

0be3348

fixes

73ca553

benesjan added 20 commits July 9, 2024 17:33

PublicKeys test

139c2b1

fixes

b4a102c

updated snaps after rebase

59a275b

updated snap

009a99b

fmt

217e33c

WIP

15d9e22

fix

3852713

cleanup

2468692

nice re-exports

3412f3a

fixes

abcdec1

cleanup

4e2c4f6

fixes

49aedf6

updated snap

be6a6b6

fixes

873173a

fix

6b36d6b

import cleanup

0d8bbb5

fixes

573e74e

revert

913af2a

boxes fixes

b473157

fix

79bd1a2

benesjan force-pushed the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch from 4978dae to 79bd1a2 Compare July 9, 2024 17:41

benesjan enabled auto-merge (squash) July 9, 2024 18:06

benesjan merged commit 5279695 into master Jul 9, 2024
90 checks passed

benesjan deleted the 07-08-fix_replace_usage_of_grumpkinpoint_with_embeddedcurvepoint branch July 9, 2024 18:10

AztecBot mentioned this pull request Jul 9, 2024

chore(master): Release 0.46.1 #7409

Merged

AztecBot mentioned this pull request Jul 10, 2024

feat: Sync from aztec-packages noir-lang/noir#5467

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` #7382

refactor: replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` #7382

benesjan commented Jul 8, 2024 •

edited

Loading

benesjan commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

AztecBot commented Jul 9, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

sklppy88 left a comment

refactor: replace usage of GrumpkinPoint with EmbeddedCurvePoint #7382

refactor: replace usage of GrumpkinPoint with EmbeddedCurvePoint #7382

Conversation

benesjan commented Jul 8, 2024 • edited Loading

benesjan commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

AztecBot commented Jul 9, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

sklppy88 left a comment

Choose a reason for hiding this comment

refactor: replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` #7382

refactor: replace usage of `GrumpkinPoint` with `EmbeddedCurvePoint` #7382

benesjan commented Jul 8, 2024 •

edited

Loading

benesjan commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

AztecBot commented Jul 9, 2024 •

edited

Loading