Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deployment contract logic in Private Kernel Circuit #699

Merged
merged 4 commits into from
May 26, 2023

Conversation

jeanmon
Copy link
Contributor

@jeanmon jeanmon commented May 26, 2023

Description

This resolves #684

In common_contract_logic() method, we should create new contract data in public_inputs only when the boolean
public_inputs.constants.tx_context.is_contract_deployment_tx is true.

As a consequence, one unit test is failing due to the expectation that there must be some contract data even though the underlying transaction request does not deploy any contract. This was replaced by an assertion that no new contract data
is present in public_inputs.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@jeanmon jeanmon requested review from dbanks12 and suyash67 May 26, 2023 12:06
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM.

@dbanks12 dbanks12 merged commit f60cc40 into master May 26, 2023
@dbanks12 dbanks12 deleted the jm/684-deployment-contract branch May 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: private kernel always pushes the current contract to new_contracts (even if is_contract_deployment=false)
2 participants