bug: private kernel always pushes the current contract to new_contracts (even if is_contract_deployment=false)
#684
Assignees
Labels
C-protocol-circuits
Component: Protocol circuits (kernel & rollup)
T-bug
Type: Bug. Something is broken.
Comments
dbanks12
added
T-bug
6 tasks
codygunton
pushed a commit
that referenced
this issue
Sep 15, 2023
This PR introduces the concept of an `Instance` and slightly reworks the components of Honk as follows: * an `Instance` contains and is responsible for creating all the polynomials resulting from a circuit and required to generate a proof (the functionality that performs these operations has been hence moved from the Composer and Prover to the Instance). This abstraction is necessary for implementing ProtoGalaxy since we are going to fold polynomials. Moreover, it makes certain tests in Honk more lightweight as we no longer have to create a full Prover to produce polynomials from a finalised circuit. * the `Composer` now creates an `Instance` from a finalised circuit and creates a Prover and Verifier from an Instance (or several Instances in the case of ProtoGalaxy). The `Instance` abstraction is currently only supported by UltraHonk. Then, I introduced shells for the `ProtoGalaxyProver` and `ProtoGalaxyVerifier` and data structures involved in folding. Resolves [#684](AztecProtocol/barretenberg#684) and partially resolves [#681](AztecProtocol/barretenberg#681) (might also need to provide some shell in the circuits library to fully resolve this one). # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: ludamad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From slack:
Jean:
If I move the following code region:
https://github.com/AztecProtocol/aztec-packages/blob/db-jm/intial-private-kernel/circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp#L129-L143
into the
if (is_contract_deployment)clause just afterwards, a cpp unit test will fail.Is this really expected that we might have new contract data to push into
public_inputs.end.new_contractseven when the booleanis_contract_deploymentisfalse?David:
I think this is a bug. It should be moved into the if statement and should not fail.
The text was updated successfully, but these errors were encountered: