refactor: nuking KeyStore and KeyPair interfaces

[benesjan]

The KeyStore interface provides no value because we don't have multiple implementations of it (and we do not expect to have them) and it is not the case that we would use it to communicate with over the network.

The KeyPair interface was no longer used so I nuked that as well.

[benesjan]

• refactor: nuking KeyStore and KeyPair interfaces #6553 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[github-actions]

Changes to circuit sizes

Generated at commit: b3ae2acce4d036e5a9ae33cb501a060b9ba7966b, compared to commit: 8e8d2ddd5eefed4f5ca7248b882dfc3d8287d1bb

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_reset	+256 ❌	+0.10%	+256 ❌	+0.01%
private_kernel_reset_medium	+16 ❌	+0.01%	+16 ❌	+0.00%
private_kernel_reset_big	+16 ❌	+0.01%	+16 ❌	+0.00%
private_kernel_reset_small	+8 ❌	+0.01%	+8 ❌	+0.00%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_reset	257,443 (+256)	+0.10%	2,528,135 (+256)	+0.01%
private_kernel_reset_medium	148,060 (+16)	+0.01%	1,197,386 (+16)	+0.00%
private_kernel_reset_big	173,380 (+16)	+0.01%	1,547,098 (+16)	+0.00%
private_kernel_reset_small	134,285 (+8)	+0.01%	1,013,116 (+8)	+0.00%

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_witness_generation_time_in_ms (base-parity): 229 (-73%)
• protocol_circuit_witness_generation_time_in_ms (merge-rollup): 146 (+67%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256	5,778	1,567	718	772	775

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,856	6,856	6,844
l1_rollup_execution_gas	587,396	587,396	587,384
l2_block_processing_time_in_ms	1,357	5,091 (+1%)	10,106 (+1%)
l2_block_building_time_in_ms	33,517 (+1%)	131,724 (+1%)	261,655
l2_block_rollup_simulation_time_in_ms	33,335 (+1%)	131,052 (+1%)	260,393
l2_block_public_tx_process_time_in_ms	15,657 (+1%)	66,601 (+1%)	133,962

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,206	28,366
node_database_size_in_bytes	21,393,488	38,080,592
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	protocol_circuit_simulation_time_in_ms	protocol_circuit_witness_generation_time_in_ms	protocol_circuit_proving_time_in_ms	protocol_circuit_input_size_in_bytes	protocol_circuit_output_size_in_bytes	protocol_circuit_proof_size_in_bytes	protocol_circuit_num_public_inputs	protocol_circuit_size_in_gates
private-kernel-init	154	3,672 (+1%)	22,410	19,987	61,999	86,720	2,643	1,048,576
private-kernel-inner	539	5,099	40,535	89,054	61,999	86,720	2,643	2,097,152
private-kernel-reset-small	551	2,606 (-1%)	23,448	117,961	61,999	86,720	2,643	1,048,576
private-kernel-tail	531	2,870 (+2%)	39,865	86,849	79,454	10,688	267	2,097,152
base-parity	7.69 (+1%)	⚠️ 229 (-73%)	4,219 (-5%)	128	64.0	2,208	2.00	131,072
root-parity	48.8 (+1%)	129 (+2%)	40,070 (+1%)	27,064	64.0	2,720	18.0	2,097,152
base-rollup	854 (-1%)	5,067 (+1%)	43,377 (+1%)	111,158	957	3,136	31.0	2,097,152
root-rollup	65.6	182 (-1%)	8,308	11,518	821	3,456	41.0	524,288
public-kernel-app-logic	189	302 (-5%)	704 (-5%)	96,979	85,095	116,448	3,572	4,096
public-kernel-tail	854	887 (+5%)	1,166 (-4%)	388,207	7,755	10,176	251	512
public-kernel-setup	166 (+2%)	430 (+13%)	951 (-5%)	138,310	85,095	116,448	3,572	4,096
public-kernel-teardown	169 (-1%)	441 (+9%)	957 (-10%)	143,321	85,095	116,448	3,572	4,096
merge-rollup	6.59 (+1%)	⚠️ 146 (+67%)	1,624 (+3%)	2,760	957	3,136	31.0	65,536
private-kernel-tail-to-public	N/A	10,285 (+2%)	72,824	N/A	N/A	116,960	3,588	4,194,304

Stats on running time collected for app circuits

Function	app_circuit_proof_size_in_bytes	app_circuit_proving_time_in_ms	app_circuit_size_in_gates	app_circuit_num_public_inputs
SchnorrAccount:entrypoint	16,128	48,443 (+1%)	2,097,152	437
Test:emit_nullifier	16,128	2,347 (-1%)	65,536	437
FPC:fee_entrypoint_public	16,128	8,567	524,288	437
FPC:fee_entrypoint_private	16,128	8,849	524,288	437
Token:unshield	16,128	50,245 (+1%)	2,097,152	437
SchnorrAccount:spend_private_authwit	16,128	2,703 (+1%)	131,072	437
Token:transfer	16,128	35,001	2,097,152	437

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.3	18.3	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.658	0.563	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.4	80.8	261	505	992 (+1%)	1,962	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.536	0.499	0.474	0.472	0.470 (+1%)	0.469	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	62.6	119	377	742	1,473	2,926	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.545	0.535	0.512	0.510	0.510	0.508	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.7
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.593

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	84,743	673,221

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	28,709	3,112	98,325

Metric	0 public data writes	1 public data writes	2 public data writes	4 public data writes	8 public data writes
tx_sequencer_processing_time_ms	1,336 (+1%)	2,140	1,870	2,756	1,773 (+1%)

[LHerskind]

🚢