chore!: remove backend interactions from nargo (AztecProtocol#6320)

This PR removes the `nargo codegen-verifier` command and replaces it with an example bash script showing how to use `nargo` in conjunction with `bb` to generate a smart contract verifier. cc @AztecProtocol/devrel Closes noir-lang/noir#4447 Closes noir-lang/noir#1138 Closes noir-lang/noir#2222 Closes noir-lang/noir#1159 Closes noir-lang/noir#1009 Closes noir-lang/noir#3837 Closes noir-lang/noir#2667 --------- Co-authored-by: ludamad <[email protected]> Co-authored-by: Maxim Vezenov <[email protected]>
zkpassport · May 17, 2024 · 7a31896 · 7a31896
1 parent 52d85d1
commit 7a31896
Show file tree

Hide file tree

Showing 81 changed files with 324 additions and 2,872 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -241,9 +241,21 @@ jobs:
       - uses: ./.github/ci-setup-action
         with:
           concurrency_key: noir-x86
-      - name: "Test Noir JS packages"
+      - name: "Test Nargo"
         run: earthly-ci --no-output ./noir+test
 
+  noir-examples:
+    needs: setup
+    runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
+    steps:
+      - uses: actions/checkout@v4
+        with: { ref: "${{ env.GIT_COMMIT }}" }
+      - uses: ./.github/ci-setup-action
+        with:
+          concurrency_key: noir-examples-x86
+      - name: "Test Noir examples"
+        run: earthly-ci --no-output ./noir+examples
+
   noir-packages-test:
     needs: setup
     runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86

diff --git a/.gitmodules b/.gitmodules
@@ -12,4 +12,4 @@
 	url = https://github.com/Arachnid/solidity-stringutils
 [submodule "barretenberg/sol/lib/openzeppelin-contracts"]
 	path = barretenberg/sol/lib/openzeppelin-contracts
-	url = https://github.com/OpenZeppelin/openzeppelin-contracts
+	url = https://github.com/OpenZeppelin/openzeppelin-contracts
diff --git a/noir/Earthfile b/noir/Earthfile
@@ -44,6 +44,21 @@ test:
   COPY noir-repo/.rustfmt.toml noir-repo/.rustfmt.toml
   RUN ./scripts/test_native.sh
 
+examples:
+  FROM +nargo
+  ENV PATH="/usr/src/noir-repo/target/release:${PATH}"
+
+  COPY --dir noir-repo/examples noir-repo
+  COPY ../barretenberg/cpp/+preset-clang-assert/bin/bb /usr/src/barretenberg/cpp/build/bin/bb
+
+  ENV BACKEND=/usr/src/barretenberg/cpp/build/bin/bb
+
+  WORKDIR noir-repo/examples/codegen-verifier
+  RUN ./test.sh
+
+  WORKDIR ../prove_and_verify
+  RUN ./test.sh
+
 format:
   FROM +nargo
   ENV PATH=$PATH:/usr/src/noir-repo/target/release

diff --git a/noir/noir-repo/.github/workflows/test-js-packages.yml b/noir/noir-repo/.github/workflows/test-js-packages.yml
@@ -399,6 +399,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Download bb binary
+        run: |
+          # Adds `bb` to PATH
+          ./scripts/install_bb.sh
+
       - name: Download nargo binary
         uses: actions/download-artifact@v4
         with: