refactor: nuking GrumpkinScalar
#6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
GrumpkinScalar
Base automatically changed from
04-30-feat_multi_scalar_mul_blackbox_func
to
master
May 7, 2024 14:20
benesjan
force-pushed
the
05-07-refactor_nuking_grumpkinscalar
branch
from
c096531
to
59ba00b
Compare
TomAFrench
approved these changes
May 7, 2024
This was referenced May 7, 2024
TomAFrench
added a commit
to noir-lang/noir
that referenced
this pull request
May 8, 2024
Automated pull of Noir development from [aztec-packages](https://github.com/AztecProtocol/aztec-packages). BEGIN_COMMIT_OVERRIDE feat!: AES blackbox (AztecProtocol/aztec-packages#6016) chore(aztec-macros): avm function return types are auto tagged as `pub` (AztecProtocol/aztec-packages#6250) refactor: nuking `GrumpkinScalar` (AztecProtocol/aztec-packages#6240) feat: `multi_scalar_mul` blackbox func (AztecProtocol/aztec-packages#6097) feat: Set aztec private functions to be recursive (AztecProtocol/aztec-packages#6192) feat: Parsing non-string assertion payloads in noir js (AztecProtocol/aztec-packages#6079) feat: `variable_base_scalar_mul` blackbox func (AztecProtocol/aztec-packages#6039) feat: Dynamic assertion payloads v2 (AztecProtocol/aztec-packages#5949) chore!: remove `Opcode::Brillig` from ACIR (AztecProtocol/aztec-packages#5995) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the aztec usecases were already replaced with a GrumpkinPrivateKey which is basically a duplicate of GrumpkinScalar.
Fixes noir-lang/noir#4968