chore: Use BrilligCall for unconstrained main and update AVM transpiler #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
commented
Apr 16, 2024
| } | ||
|
|
||
| /// Print inputs, outputs, and instructions in a Brillig program | ||
| pub fn dbg_print_brillig_program(brillig: &Brillig) { | ||
| pub fn dbg_print_brillig_program(brillig_bytecode: &[BrilligOpcode]) { |
There was a problem hiding this comment.
I figuredi t would be fine to just print the bytecode as the AVM transpiler doesn't look to touch the inputs/outputs at all, we only print instructions for the AVM program, and you can get the Brillig inputs/outputs by printing the ACIR.
TomAFrench
approved these changes
Apr 16, 2024
|
This could probably do with a rebase on top of master. |
Co-authored-by: Tom French <[email protected]>
Co-authored-by: jfecher <[email protected]>
Co-authored-by: jfecher <[email protected]>
…ir/acir_variable.rs Co-authored-by: jfecher <[email protected]>
…ir/acir_variable.rs Co-authored-by: jfecher <[email protected]>
…ir/acir_variable.rs Co-authored-by: jfecher <[email protected]>
…ir/acir_variable.rs Co-authored-by: jfecher <[email protected]>
…ir/acir_variable.rs Co-authored-by: jfecher <[email protected]>
…ir/acir_variable.rs Co-authored-by: jfecher <[email protected]>
Co-authored-by: jfecher <[email protected]>
vezenovm
force-pushed
the
mv/update-avm-for-brillig-call
branch
from
6601d1a to
14b9ae8
Compare
|
This commit history is really ugly and I messed up the rebase so this PR has been superseded by 5797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #5737
Separate PR as this touches mainly the AVM transpiler and not Noir codegen itself. Look in PR #5737 for full details about the switch, but basically we are moving away from the
Brilligopcode to aBrilligCallopcode that contains a Brillig call opcode. The AVM needs to be updated to account for this change.