feat: poseidon separator

[benesjan]

After talking with @lucasxia01 it should be enough to just add the separator as another element in the array of input fields. This PR does that without modifying bb API.

[benesjan]

• refactor: integrate new key store #5731
• feat: app siloing in new key store #5721
• feat: poseidon separator #5717 👈
• feat: new key store #5653
• refactor: TS hash wrappers cleanup #5691
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• batch_insert_into_append_only_tree_32_depth_ms (2048): 985 (-47%)
• batch_insert_into_append_only_tree_32_depth_ms (4096): 1,978 (-26%)
• batch_insert_into_append_only_tree_32_depth_hash_ms (2048): 0.468 (-47%)
• batch_insert_into_indexed_tree_20_depth_ms (2048): 1,471 (-39%)
• batch_insert_into_indexed_tree_20_depth_ms (4096): 2,925 (-25%)
• batch_insert_into_indexed_tree_20_depth_hash_ms (2048): 0.510 (-38%)
• l2_block_public_tx_process_time_in_ms (32): 21,105 (-19%)
• l2_block_processing_time_in_ms (32): 5,254 (-29%)
• note_trial_decrypting_time_in_ms (32): 29.0 (+95%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,808	6,796	6,784
l1_rollup_execution_gas	587,289	587,277	587,265
l2_block_processing_time_in_ms	1,502 (+5%)	⚠️ 5,254 (-29%)	10,516 (-12%)
note_successful_decrypting_time_in_ms	241 (+1%)	519 (+2%)	976 (+9%)
note_trial_decrypting_time_in_ms	44.0 (+5%)	⚠️ 29.0 (+95%)	93.4 (-14%)
l2_block_building_time_in_ms	9,840 (+2%)	38,328 (-11%)	77,584 (+2%)
l2_block_rollup_simulation_time_in_ms	9,646 (+2%)	37,623 (-12%)	76,215 (+2%)
l2_block_public_tx_process_time_in_ms	5,391 (+2%)	⚠️ 21,105 (-19%)	42,307 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,204	28,816
note_history_successful_decrypting_time_in_ms	1,159 (-5%)	2,253 (-5%)
note_history_trial_decrypting_time_in_ms	39.2 (-35%)	76.8 (-25%)
node_database_size_in_bytes	18,772,048	35,127,376
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	151 (-1%)	44,561	26,424
private-kernel-inner	156 (-1%)	72,188	26,424
private-kernel-ordering	109	51,090	39,297
base-parity	52.1	128	311
root-parity	9.94 (+1%)	1,244	311
base-rollup	12,682	110,820	957
root-rollup	48.9 (+1%)	4,551	821
public-kernel-app-logic	81.3 (-3%)	48,151	40,933
public-kernel-tail	121 (-2%)	53,644	7,385
merge-rollup	9.74 (-4%)	2,760	957
public-kernel-teardown	79.8 (+1%)	48,151	40,933
public-kernel-setup	79.2 (+2%)	48,151	40,933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (-7%)	17.9 (-5%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.639 (-7%)	0.555 (-5%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.1 (-2%)	84.3 (-7%)	263 (+2%)	500 (-1%)	⚠️ 985 (-47%)	⚠️ 1,978 (-26%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.533 (-1%)	0.520 (-7%)	0.476 (+1%)	0.468 (-1%)	⚠️ 0.468 (-47%)	0.472 (-27%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.2 (-2%)	125 (-3%)	383 (+2%)	734 (-1%)	⚠️ 1,471 (-39%)	⚠️ 2,925 (-25%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.533 (-2%)	0.565 (-3%)	0.523 (+2%)	0.507 (-1%)	⚠️ 0.510 (-38%)	0.509 (-25%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.3 (-3%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.589 (-3%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	41,005	528,889

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,208 (+5%)	789 (-1%)	3,398 (+1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	455 (-3%)	307 (+1%)	826 (+1%)	396 (+1%)	1,367 (+1%)	462 (+1%)

[lucasxia01]

LGTM