fix: Simplify ECCVM prover constructor and add a TODO #5681

ledwards2225 · 2024-04-10T22:09:25Z

Simplify ECCVM prover constructor and clarify the confusion around what we thought was the use of uninitialized polynomials via an issue and a TODO.

Note: I think there may have been a merge mistake or something in Cody's recent PR (which I approved) that left the ECCVM prover constructors in a very weird state. (Also there was a WORKTODO left in code). There is still some weirdness (captured in the TODO) but hopefully this clarifies the situation a bit.

ClientIVCBench/Full/6 22891 ms 17769 ms 1

AztecBot · 2024-04-10T23:26:43Z

Benchmark results

Metrics with a significant change:

note_successful_decrypting_time_in_ms (8): 202 (-17%)
note_trial_decrypting_time_in_ms (8): 102 (+133%)
note_trial_decrypting_time_in_ms (64): 103 (+243%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,400	6,412
l1_rollup_execution_gas	585,757	585,733	585,745
l2_block_processing_time_in_ms	1,301 (-2%)	4,753	9,338 (-2%)
note_successful_decrypting_time_in_ms	⚠️ 202 (-17%)	529 (+5%)	886 (-3%)
note_trial_decrypting_time_in_ms	⚠️ 102 (+133%)	39.6 (-65%)	⚠️ 103 (+243%)
l2_block_building_time_in_ms	10,383	37,765 (+1%)	72,198 (-3%)
l2_block_rollup_simulation_time_in_ms	10,269	37,365 (+1%)	71,446 (-3%)
l2_block_public_tx_process_time_in_ms	4,897 (-1%)	19,129 (-1%)	38,014 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,369 (-1%)	26,755 (-3%)
note_history_successful_decrypting_time_in_ms	1,126 (+1%)	2,204 (-1%)
note_history_trial_decrypting_time_in_ms	41.9 (-4%)	75.7 (-3%)
node_database_size_in_bytes	18,608,208	35,049,552
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	143	44,281	26,164
private-kernel-inner	152	71,648	26,164
private-kernel-ordering	112	50,830	39,026
base-parity	3,944 (+2%)	128	311
root-parity	1,053 (-6%)	1,244	311
base-rollup	13,285 (-1%)	110,464	861
root-rollup	49.4 (-1%)	4,359	725
public-kernel-app-logic	79.2 (-1%)	47,599	40,661
public-kernel-tail	112 (-1%)	53,372	7,125
merge-rollup	10.4 (-3%)	2,568	861
public-kernel-teardown	75.7 (+3%)	47,599	40,661
public-kernel-setup	74.9 (-1%)	47,599	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	16.0 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583	0.494 (-2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.0 (-1%)	72.4	232	445	868	1,725 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471 (-1%)	0.447	0.422	0.416	0.413	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.3 (-1%)	106 (-1%)	335 (-1%)	660	1,310	2,606 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480 (-1%)	0.480	0.456	0.455	0.453	0.453 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.9
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.533

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,172 (+2%)	820	4,001 (+4%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	419 (-1%)	285 (+4%)	737 (+4%)	367 (+4%)	1,204 (-1%)	429 (+3%)

lucasxia01

Nice, looks good to me. Would be curious to see effects on benchmarks though

lucasxia01 · 2024-04-11T10:05:38Z

barretenberg/cpp/src/barretenberg/eccvm/eccvm_prover.cpp

 ECCVMProver::ECCVMProver(CircuitBuilder& builder, const std::shared_ptr<Transcript>& transcript)
+    : transcript(transcript)
+    , prover_polynomials(builder)


In ulltra/goblin_ultra, we go the other way: construct a proving_key and then construct a prover_polynomials from that. I supposed its not a big deal if we do it like this although things are inconsistent.

yeah I tried to capture this in the TODO. It used to be the case that the pkey "owned" the polys and prover_polys was just an immutable view into them. That's changed so now one is really just a copy of the other (without the expense due to the shared memory), plus the shifted polys but those don't use additional memory. I think its possible we should do away with one or the other. Maybe pkey just has a prover_polys

lucasxia01 · 2024-04-11T10:13:50Z

barretenberg/cpp/src/barretenberg/eccvm/eccvm_prover.cpp

        ASSERT(flavor_get_label(prover_polynomials, prover_poly) == flavor_get_label(*key, key_poly));
-        std::copy(prover_poly.begin(), prover_poly.end(), key_poly.begin());
+        key_poly = prover_poly.share();


what's the impact on client ivc bench for removing these copys?

added to the description. 22.8

seems like none or very little impact?

lucasxia01 · 2024-04-11T10:17:16Z

barretenberg/cpp/src/barretenberg/eccvm/eccvm_prover.cpp

@@ -98,7 +80,6 @@ void ECCVMProver::execute_log_derivative_commitments_round()
    compute_logderivative_inverse<Flavor, typename Flavor::LookupRelation>(
        prover_polynomials, relation_parameters, key->circuit_size);
    transcript->send_to_verifier(commitment_labels.lookup_inverses, commitment_key->commit(key->lookup_inverses));
-    prover_polynomials.lookup_inverses = key->lookup_inverses.share();


So since these have already been shared before, this line doesn't do anything correct, as the backing_memory, size, and coeff ptr are the same?

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.35.0</summary> ## [0.35.0](aztec-package-v0.34.0...aztec-package-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * pay fee for account init ([#5601](#5601)) ### Features * Pay fee for account init ([#5601](#5601)) ([aca804f](aca804f)) </details> <details><summary>barretenberg.js: 0.35.0</summary> ## [0.35.0](barretenberg.js-v0.34.0...barretenberg.js-v0.35.0) (2024-04-16) ### Features * Export poseidon2_permutation and add to foundation/crypto ([#5706](#5706)) ([6b91e27](6b91e27)) ### Miscellaneous * Don't strip bb wasm ([#5743](#5743)) ([d4cb410](d4cb410)) * TS hash wrappers cleanup ([#5691](#5691)) ([7f8b09f](7f8b09f)) </details> <details><summary>aztec-cli: 0.35.0</summary> ## [0.35.0](aztec-cli-v0.34.0...aztec-cli-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * pay fee for account init ([#5601](#5601)) ### Features * Pay fee for account init ([#5601](#5601)) ([aca804f](aca804f)) </details> <details><summary>aztec-packages: 0.35.0</summary> ## [0.35.0](aztec-packages-v0.34.0...aztec-packages-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * Use fixed size arrays in black box functions where sizes are known ([#5620](#5620)) * trap with revert data ([#5732](#5732)) * **acir:** BrilligCall opcode ([#5709](#5709)) * rename request_max_block_number ([#5675](#5675)) * pay fee for account init ([#5601](#5601)) ### Features * **acir:** BrilligCall opcode ([#5709](#5709)) ([f06f64c](f06f64c)) * Add serialisation methods ([#5749](#5749)) ([20d290c](20d290c)) * App siloing in new key store ([#5721](#5721)) ([ae37d32](ae37d32)), closes [#5635](#5635) * **avm-simulator:** Plumb noir assertion messages ([#5774](#5774)) ([2cf11ac](2cf11ac)) * **avm:** CMOV opcode ([#5575](#5575)) ([19dbe46](19dbe46)), closes [#5557](#5557) * **avm:** Enable contract testing with bb binary ([#5584](#5584)) ([d007d79](d007d79)) * **avm:** Enable range check on the ALU registers ([#5696](#5696)) ([202fc1b](202fc1b)) * **avm:** Keccak as blackbox function ([#5722](#5722)) ([6ea677a](6ea677a)) * **avm:** Poseidon2_permutation as black box ([#5707](#5707)) ([5526b36](5526b36)) * **avm:** Sha256 as blackbox function ([#5727](#5727)) ([cac9cba](cac9cba)) * **avm:** Take sizeOffset in CALL ([#5763](#5763)) ([95eadd6](95eadd6)) * Brillig heterogeneous memory cells ([#5608](#5608)) ([3287aa2](3287aa2)) * Change public nullifiers api ([#5660](#5660)) ([986e7f9](986e7f9)) * Changing finite field arithmetic in wasm to 29 bits for multiplications ([#5435](#5435)) ([b2d9b9d](b2d9b9d)) * **ci:** Turn on new CI as mandatory ([#5761](#5761)) ([bebed32](bebed32)) * **docs:** Merge yellow paper into docs protocol specs section ([#5668](#5668)) ([66dc509](66dc509)) * E2e token contract can run in 2m with snapshots and test separation. ([#5526](#5526)) ([b0037dd](b0037dd)) * Export poseidon2_permutation and add to foundation/crypto ([#5706](#5706)) ([6b91e27](6b91e27)) * Get last mock oracles params (noir-lang/noir#4789) ([825c455](825c455)) * Impl of missing functionality in new key store ([#5750](#5750)) ([af49a29](af49a29)) * LT/LTE for AVM ([#5559](#5559)) ([350abeb](350abeb)) * New key store ([#5653](#5653)) ([3e44a58](3e44a58)), closes [#5607](#5607) * Pay fee for account init ([#5601](#5601)) ([aca804f](aca804f)) * Poseidon separator ([#5717](#5717)) ([d5256d2](d5256d2)) * Proving the rollup circuits ([#5599](#5599)) ([145cbcd](145cbcd)) * Public Kernel proving orchestration ([#5748](#5748)) ([2ae0ee5](2ae0ee5)) * Rename request_max_block_number ([#5675](#5675)) ([c695fcd](c695fcd)) * Separate nullfier_inclusion checks for private/public/avm ([#5657](#5657)) ([e4d2df6](e4d2df6)) * Sequencer validates setup/teardown function selectors ([#5649](#5649)) ([8f8ad56](8f8ad56)), closes [#5401](#5401) * Shared mutable storage ([#5490](#5490)) ([c4e41a9](c4e41a9)) * **simulator:** Fetch return values at circuit execution ([#5642](#5642)) ([413a4e0](413a4e0)) * Split `backend_barretenburg` into prover and verifier classes (noir-lang/noir#4769) ([825c455](825c455)) * Sync from aztec-packages (noir-lang/noir#4764) ([1eb288e](1eb288e)) * Sync from aztec-packages (noir-lang/noir#4787) ([825c455](825c455)) * Trap with revert data ([#5732](#5732)) ([f849575](f849575)) * Unroll loops iteratively (noir-lang/noir#4779) ([1eb288e](1eb288e)) * Update circuits structs with gas info ([#5677](#5677)) ([3db6dd1](3db6dd1)) * Use fixed size arrays in black box functions where sizes are known ([#5620](#5620)) ([f50b180](f50b180)) * Variable length returns ([#5633](#5633)) ([b4a6f17](b4a6f17)) * Wire AVM gas used to public kernel ([#5740](#5740)) ([4f55d10](4f55d10)) ### Bug Fixes * "feat: Changing finite field arithmetic in wasm to 29 bits for multiplications" ([#5779](#5779)) ([bcfee97](bcfee97)) * Anvil start retry in case something bad. Fix colors. ([#5673](#5673)) ([0b6b6f6](0b6b6f6)) * ArrayGet and Set are not pure (noir-lang/noir#4783) ([825c455](825c455)) * Avoid get row in databus ([#5742](#5742)) ([d67b6c8](d67b6c8)) * Avoid huge unrolling in hash_args ([#5703](#5703)) ([10d9ad9](10d9ad9)) * **ci,noir-projects:** Bring apt-get higher in cache ([#5775](#5775)) ([d37cbb9](d37cbb9)) * **ci:** 192 core spot runner ([#5767](#5767)) ([37daac6](37daac6)) * **ci:** Bigger cache disk, cache+prune docker images, disable ClientIvcTests.Full ([#5729](#5729)) ([5dcbd75](5dcbd75)) * **ci:** Builder types ([#5711](#5711)) ([b16f169](b16f169)) * **ci:** Cache size not honoured ([#5738](#5738)) ([d4ff340](d4ff340)) * **ci:** Don't fail if can't prune ([d9bb2c7](d9bb2c7)) * **ci:** Error in spot ([#5745](#5745)) ([4d754aa](4d754aa)) * **ci:** Fix arm e2e references, spot shutdown ([#5741](#5741)) ([1c4667c](1c4667c)) * **ci:** Hotfix arm ([1ddb1c7](1ddb1c7)) * **ci:** Hotfix just one ARM task ([10f27ae](10f27ae)) * **ci:** Speculative deploy fix ([9a9eab6](9a9eab6)) * **ci:** Wait for mainnet fork deployment ([#5735](#5735)) ([8f3794d](8f3794d)) * **ci:** Wait_for_fork env var ([#5780](#5780)) ([d85267b](d85267b)) * Correct ICE panic messages in brillig `convert_black_box_call` (noir-lang/noir#4761) ([1eb288e](1eb288e)) * Disable flakey vanilla recursion test ([#5672](#5672)) ([f84f7b6](f84f7b6)) * Don't run e2e tests against wrong anvil ([#5686](#5686)) ([9ff45f6](9ff45f6)) * Dont error in bench summary ([#5693](#5693)) ([470b0f3](470b0f3)) * E2e getStack, disable failing e2e ([#5768](#5768)) ([e5f3ece](e5f3ece)) * GA concurrency ([#5713](#5713)) ([eac2585](eac2585)) * Generate_aztecnr_reference.js not getting generics or multi-line params ([#5679](#5679)) ([a22bc3d](a22bc3d)) * Hotfix submodule cache ([92b92b3](92b92b3)) * Hotfix underspec'd machine ([#5710](#5710)) ([059e38e](059e38e)) * **hotfix:** CI ignore git safe.directory checks ([#5659](#5659)) ([9fc3fe3](9fc3fe3)) * Less earthly cache ([#5690](#5690)) ([8190dc7](8190dc7)) * Make earthly more parallel ([#5747](#5747)) ([9734455](9734455)) * Primary_message typo in errors.rs ([#5646](#5646)) ([1dfbe7b](1dfbe7b)) * Pull noir ([#5699](#5699)) ([bf35464](bf35464)) * REDO dont error in bench summary ([#5695](#5695)) ([8c1a7b9](8c1a7b9)) * Running e2e tests as part of build, requires forcing ip4 (not ip6) when connecting to anvil ([#5744](#5744)) ([66fc89f](66fc89f)) * Simplify ECCVM prover constructor and add a TODO ([#5681](#5681)) ([8c151ea](8c151ea)) * Spot refcount ([#5746](#5746)) ([9e18444](9e18444)) * Take a deep copy of circuit inputs for proving ([#5777](#5777)) ([785591e](785591e)) * Temporarily disable the bench tests ([#5755](#5755)) ([1d52ac5](1d52ac5)) * Update commit for noir-gates-diff (noir-lang/noir#4773) ([1eb288e](1eb288e)) * Use entrypoint instead of pay_init_fee ([#5623](#5623)) ([62ac765](62ac765)) * Watch less files. ([#5651](#5651)) ([57a1d69](57a1d69)) ### Miscellaneous * Add missing aztec-address tests ([#5674](#5674)) ([58aefba](58aefba)) * **avm:** Add a boolean to toggle proving in AVM unit tests ([#5667](#5667)) ([ec122c9](ec122c9)), closes [#5663](#5663) * **avm:** Hashing tests cleanup ([#5733](#5733)) ([53d0102](53d0102)) * **avm:** Range checks negative tests ([#5770](#5770)) ([2907142](2907142)) * **avm:** Split the negative test on range check for high 16-bit registers ([#5785](#5785)) ([8ebbe57](8ebbe57)) * **avm:** Split up AVM test contract as it was growing too large ([#5702](#5702)) ([5b8e812](5b8e812)) * **aztec-nr:** Minor public interface changes ([#5776](#5776)) ([91b8110](91b8110)) * **ci:** Break e2e-deploy into multiple test suites ([#5704](#5704)) ([2522294](2522294)) * **ci:** Earthly in spot with persistent cache ([#5644](#5644)) ([a39c2f6](a39c2f6)) * **ci:** Hotfix AMI's, workflow to stop personal spot runners ([#5712](#5712)) ([5f18139](5f18139)) * **ci:** Only run ARM on master ([#5705](#5705)) ([f77c142](f77c142)) * **ci:** Use 128 cores for x86 and add timeouts ([#5665](#5665)) ([0c5dc0a](0c5dc0a)) * Compute_note_hash_and_nullifier - improve error message ([#5671](#5671)) ([8942d69](8942d69)) * Create placeholder version of 0.26.0 docs (noir-lang/noir#4782) ([1eb288e](1eb288e)) * **doc:** Fix broken docs links (noir-lang/noir#4606) ([1eb288e](1eb288e)) * **docs:** Fix link in the Data Types page (noir-lang/noir#4527) ([1eb288e](1eb288e)) * Don't strip bb wasm ([#5743](#5743)) ([d4cb410](d4cb410)) * Fix master after merge issue related to validate_trace renaming ([#5676](#5676)) ([44e0d8a](44e0d8a)) * Fix max-block-number and auth e2e tests ([#5694](#5694)) ([f1bf314](f1bf314)) * Op queue ([#5648](#5648)) ([822c7e6](822c7e6)) * **public:** Remove getNullifierMembershipWitness ([#5715](#5715)) ([3be402c](3be402c)) * Re-enable e2e fees tests ([#5784](#5784)) ([102e8b8](102e8b8)) * Release Noir(0.27.0) (noir-lang/noir#4632) ([1eb288e](1eb288e)) * Remove the old Value struct from the oracle docs (noir-lang/noir#4738) ([1eb288e](1eb288e)) * Replace relative paths to noir-protocol-circuits ([fb2b298](fb2b298)) * Replace relative paths to noir-protocol-circuits ([e20920d](e20920d)) * Replace relative paths to noir-protocol-circuits ([6351dc5](6351dc5)) * Replace relative paths to noir-protocol-circuits ([fee13bf](fee13bf)) * Replacing unsafe::zeroed() ([#5685](#5685)) ([ea3884e](ea3884e)) * Small logging changes ([#5654](#5654)) ([25cc70d](25cc70d)) * Temporarily skip failing e2e fees test ([a3ac5ff](a3ac5ff)) * Testing that nargo fmt is idempotent (noir-lang/noir#4765) ([825c455](825c455)) * TS hash wrappers cleanup ([#5691](#5691)) ([7f8b09f](7f8b09f)) * Turn ENABLE_GAS where it is needed ([#5730](#5730)) ([30a2edd](30a2edd)) * Update noir gates diff ([#5658](#5658)) ([9816c1a](9816c1a)) * We can run 35 of our e2e tests just using jest. ([#5643](#5643)) ([4fcaeae](4fcaeae)) ### Documentation * Fix yp typo control-flow.md ([#5638](#5638)) ([363d227](363d227)) </details> <details><summary>barretenberg: 0.35.0</summary> ## [0.35.0](barretenberg-v0.34.0...barretenberg-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * Use fixed size arrays in black box functions where sizes are known ([#5620](#5620)) * trap with revert data ([#5732](#5732)) * **acir:** BrilligCall opcode ([#5709](#5709)) ### Features * **acir:** BrilligCall opcode ([#5709](#5709)) ([f06f64c](f06f64c)) * **avm:** CMOV opcode ([#5575](#5575)) ([19dbe46](19dbe46)), closes [#5557](#5557) * **avm:** Enable contract testing with bb binary ([#5584](#5584)) ([d007d79](d007d79)) * **avm:** Enable range check on the ALU registers ([#5696](#5696)) ([202fc1b](202fc1b)) * Changing finite field arithmetic in wasm to 29 bits for multiplications ([#5435](#5435)) ([b2d9b9d](b2d9b9d)) * **ci:** Turn on new CI as mandatory ([#5761](#5761)) ([bebed32](bebed32)) * Export poseidon2_permutation and add to foundation/crypto ([#5706](#5706)) ([6b91e27](6b91e27)) * LT/LTE for AVM ([#5559](#5559)) ([350abeb](350abeb)) * Trap with revert data ([#5732](#5732)) ([f849575](f849575)) * Use fixed size arrays in black box functions where sizes are known ([#5620](#5620)) ([f50b180](f50b180)) ### Bug Fixes * "feat: Changing finite field arithmetic in wasm to 29 bits for multiplications" ([#5779](#5779)) ([bcfee97](bcfee97)) * Avoid get row in databus ([#5742](#5742)) ([d67b6c8](d67b6c8)) * **ci:** Bigger cache disk, cache+prune docker images, disable ClientIvcTests.Full ([#5729](#5729)) ([5dcbd75](5dcbd75)) * Disable flakey vanilla recursion test ([#5672](#5672)) ([f84f7b6](f84f7b6)) * Less earthly cache ([#5690](#5690)) ([8190dc7](8190dc7)) * Make earthly more parallel ([#5747](#5747)) ([9734455](9734455)) * Simplify ECCVM prover constructor and add a TODO ([#5681](#5681)) ([8c151ea](8c151ea)) ### Miscellaneous * **avm:** Add a boolean to toggle proving in AVM unit tests ([#5667](#5667)) ([ec122c9](ec122c9)), closes [#5663](#5663) * **avm:** Range checks negative tests ([#5770](#5770)) ([2907142](2907142)) * **avm:** Split the negative test on range check for high 16-bit registers ([#5785](#5785)) ([8ebbe57](8ebbe57)) * **ci:** Use 128 cores for x86 and add timeouts ([#5665](#5665)) ([0c5dc0a](0c5dc0a)) * Don't strip bb wasm ([#5743](#5743)) ([d4cb410](d4cb410)) * Fix master after merge issue related to validate_trace renaming ([#5676](#5676)) ([44e0d8a](44e0d8a)) * Op queue ([#5648](#5648)) ([822c7e6](822c7e6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.35.0</summary> ## [0.35.0](AztecProtocol/aztec-packages@aztec-package-v0.34.0...aztec-package-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * pay fee for account init ([#5601](AztecProtocol/aztec-packages#5601)) ### Features * Pay fee for account init ([#5601](AztecProtocol/aztec-packages#5601)) ([aca804f](AztecProtocol/aztec-packages@aca804f)) </details> <details><summary>barretenberg.js: 0.35.0</summary> ## [0.35.0](AztecProtocol/aztec-packages@barretenberg.js-v0.34.0...barretenberg.js-v0.35.0) (2024-04-16) ### Features * Export poseidon2_permutation and add to foundation/crypto ([#5706](AztecProtocol/aztec-packages#5706)) ([6b91e27](AztecProtocol/aztec-packages@6b91e27)) ### Miscellaneous * Don't strip bb wasm ([#5743](AztecProtocol/aztec-packages#5743)) ([d4cb410](AztecProtocol/aztec-packages@d4cb410)) * TS hash wrappers cleanup ([#5691](AztecProtocol/aztec-packages#5691)) ([7f8b09f](AztecProtocol/aztec-packages@7f8b09f)) </details> <details><summary>aztec-cli: 0.35.0</summary> ## [0.35.0](AztecProtocol/aztec-packages@aztec-cli-v0.34.0...aztec-cli-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * pay fee for account init ([#5601](AztecProtocol/aztec-packages#5601)) ### Features * Pay fee for account init ([#5601](AztecProtocol/aztec-packages#5601)) ([aca804f](AztecProtocol/aztec-packages@aca804f)) </details> <details><summary>aztec-packages: 0.35.0</summary> ## [0.35.0](AztecProtocol/aztec-packages@aztec-packages-v0.34.0...aztec-packages-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * Use fixed size arrays in black box functions where sizes are known ([#5620](AztecProtocol/aztec-packages#5620)) * trap with revert data ([#5732](AztecProtocol/aztec-packages#5732)) * **acir:** BrilligCall opcode ([#5709](AztecProtocol/aztec-packages#5709)) * rename request_max_block_number ([#5675](AztecProtocol/aztec-packages#5675)) * pay fee for account init ([#5601](AztecProtocol/aztec-packages#5601)) ### Features * **acir:** BrilligCall opcode ([#5709](AztecProtocol/aztec-packages#5709)) ([f06f64c](AztecProtocol/aztec-packages@f06f64c)) * Add serialisation methods ([#5749](AztecProtocol/aztec-packages#5749)) ([20d290c](AztecProtocol/aztec-packages@20d290c)) * App siloing in new key store ([#5721](AztecProtocol/aztec-packages#5721)) ([ae37d32](AztecProtocol/aztec-packages@ae37d32)), closes [#5635](AztecProtocol/aztec-packages#5635) * **avm-simulator:** Plumb noir assertion messages ([#5774](AztecProtocol/aztec-packages#5774)) ([2cf11ac](AztecProtocol/aztec-packages@2cf11ac)) * **avm:** CMOV opcode ([#5575](AztecProtocol/aztec-packages#5575)) ([19dbe46](AztecProtocol/aztec-packages@19dbe46)), closes [#5557](AztecProtocol/aztec-packages#5557) * **avm:** Enable contract testing with bb binary ([#5584](AztecProtocol/aztec-packages#5584)) ([d007d79](AztecProtocol/aztec-packages@d007d79)) * **avm:** Enable range check on the ALU registers ([#5696](AztecProtocol/aztec-packages#5696)) ([202fc1b](AztecProtocol/aztec-packages@202fc1b)) * **avm:** Keccak as blackbox function ([#5722](AztecProtocol/aztec-packages#5722)) ([6ea677a](AztecProtocol/aztec-packages@6ea677a)) * **avm:** Poseidon2_permutation as black box ([#5707](AztecProtocol/aztec-packages#5707)) ([5526b36](AztecProtocol/aztec-packages@5526b36)) * **avm:** Sha256 as blackbox function ([#5727](AztecProtocol/aztec-packages#5727)) ([cac9cba](AztecProtocol/aztec-packages@cac9cba)) * **avm:** Take sizeOffset in CALL ([#5763](AztecProtocol/aztec-packages#5763)) ([95eadd6](AztecProtocol/aztec-packages@95eadd6)) * Brillig heterogeneous memory cells ([#5608](AztecProtocol/aztec-packages#5608)) ([3287aa2](AztecProtocol/aztec-packages@3287aa2)) * Change public nullifiers api ([#5660](AztecProtocol/aztec-packages#5660)) ([986e7f9](AztecProtocol/aztec-packages@986e7f9)) * Changing finite field arithmetic in wasm to 29 bits for multiplications ([#5435](AztecProtocol/aztec-packages#5435)) ([b2d9b9d](AztecProtocol/aztec-packages@b2d9b9d)) * **ci:** Turn on new CI as mandatory ([#5761](AztecProtocol/aztec-packages#5761)) ([bebed32](AztecProtocol/aztec-packages@bebed32)) * **docs:** Merge yellow paper into docs protocol specs section ([#5668](AztecProtocol/aztec-packages#5668)) ([66dc509](AztecProtocol/aztec-packages@66dc509)) * E2e token contract can run in 2m with snapshots and test separation. ([#5526](AztecProtocol/aztec-packages#5526)) ([b0037dd](AztecProtocol/aztec-packages@b0037dd)) * Export poseidon2_permutation and add to foundation/crypto ([#5706](AztecProtocol/aztec-packages#5706)) ([6b91e27](AztecProtocol/aztec-packages@6b91e27)) * Get last mock oracles params (noir-lang/noir#4789) ([825c455](AztecProtocol/aztec-packages@825c455)) * Impl of missing functionality in new key store ([#5750](AztecProtocol/aztec-packages#5750)) ([af49a29](AztecProtocol/aztec-packages@af49a29)) * LT/LTE for AVM ([#5559](AztecProtocol/aztec-packages#5559)) ([350abeb](AztecProtocol/aztec-packages@350abeb)) * New key store ([#5653](AztecProtocol/aztec-packages#5653)) ([3e44a58](AztecProtocol/aztec-packages@3e44a58)), closes [#5607](AztecProtocol/aztec-packages#5607) * Pay fee for account init ([#5601](AztecProtocol/aztec-packages#5601)) ([aca804f](AztecProtocol/aztec-packages@aca804f)) * Poseidon separator ([#5717](AztecProtocol/aztec-packages#5717)) ([d5256d2](AztecProtocol/aztec-packages@d5256d2)) * Proving the rollup circuits ([#5599](AztecProtocol/aztec-packages#5599)) ([145cbcd](AztecProtocol/aztec-packages@145cbcd)) * Public Kernel proving orchestration ([#5748](AztecProtocol/aztec-packages#5748)) ([2ae0ee5](AztecProtocol/aztec-packages@2ae0ee5)) * Rename request_max_block_number ([#5675](AztecProtocol/aztec-packages#5675)) ([c695fcd](AztecProtocol/aztec-packages@c695fcd)) * Separate nullfier_inclusion checks for private/public/avm ([#5657](AztecProtocol/aztec-packages#5657)) ([e4d2df6](AztecProtocol/aztec-packages@e4d2df6)) * Sequencer validates setup/teardown function selectors ([#5649](AztecProtocol/aztec-packages#5649)) ([8f8ad56](AztecProtocol/aztec-packages@8f8ad56)), closes [#5401](AztecProtocol/aztec-packages#5401) * Shared mutable storage ([#5490](AztecProtocol/aztec-packages#5490)) ([c4e41a9](AztecProtocol/aztec-packages@c4e41a9)) * **simulator:** Fetch return values at circuit execution ([#5642](AztecProtocol/aztec-packages#5642)) ([413a4e0](AztecProtocol/aztec-packages@413a4e0)) * Split `backend_barretenburg` into prover and verifier classes (noir-lang/noir#4769) ([825c455](AztecProtocol/aztec-packages@825c455)) * Sync from aztec-packages (noir-lang/noir#4764) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Sync from aztec-packages (noir-lang/noir#4787) ([825c455](AztecProtocol/aztec-packages@825c455)) * Trap with revert data ([#5732](AztecProtocol/aztec-packages#5732)) ([f849575](AztecProtocol/aztec-packages@f849575)) * Unroll loops iteratively (noir-lang/noir#4779) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Update circuits structs with gas info ([#5677](AztecProtocol/aztec-packages#5677)) ([3db6dd1](AztecProtocol/aztec-packages@3db6dd1)) * Use fixed size arrays in black box functions where sizes are known ([#5620](AztecProtocol/aztec-packages#5620)) ([f50b180](AztecProtocol/aztec-packages@f50b180)) * Variable length returns ([#5633](AztecProtocol/aztec-packages#5633)) ([b4a6f17](AztecProtocol/aztec-packages@b4a6f17)) * Wire AVM gas used to public kernel ([#5740](AztecProtocol/aztec-packages#5740)) ([4f55d10](AztecProtocol/aztec-packages@4f55d10)) ### Bug Fixes * "feat: Changing finite field arithmetic in wasm to 29 bits for multiplications" ([#5779](AztecProtocol/aztec-packages#5779)) ([bcfee97](AztecProtocol/aztec-packages@bcfee97)) * Anvil start retry in case something bad. Fix colors. ([#5673](AztecProtocol/aztec-packages#5673)) ([0b6b6f6](AztecProtocol/aztec-packages@0b6b6f6)) * ArrayGet and Set are not pure (noir-lang/noir#4783) ([825c455](AztecProtocol/aztec-packages@825c455)) * Avoid get row in databus ([#5742](AztecProtocol/aztec-packages#5742)) ([d67b6c8](AztecProtocol/aztec-packages@d67b6c8)) * Avoid huge unrolling in hash_args ([#5703](AztecProtocol/aztec-packages#5703)) ([10d9ad9](AztecProtocol/aztec-packages@10d9ad9)) * **ci,noir-projects:** Bring apt-get higher in cache ([#5775](AztecProtocol/aztec-packages#5775)) ([d37cbb9](AztecProtocol/aztec-packages@d37cbb9)) * **ci:** 192 core spot runner ([#5767](AztecProtocol/aztec-packages#5767)) ([37daac6](AztecProtocol/aztec-packages@37daac6)) * **ci:** Bigger cache disk, cache+prune docker images, disable ClientIvcTests.Full ([#5729](AztecProtocol/aztec-packages#5729)) ([5dcbd75](AztecProtocol/aztec-packages@5dcbd75)) * **ci:** Builder types ([#5711](AztecProtocol/aztec-packages#5711)) ([b16f169](AztecProtocol/aztec-packages@b16f169)) * **ci:** Cache size not honoured ([#5738](AztecProtocol/aztec-packages#5738)) ([d4ff340](AztecProtocol/aztec-packages@d4ff340)) * **ci:** Don't fail if can't prune ([d9bb2c7](AztecProtocol/aztec-packages@d9bb2c7)) * **ci:** Error in spot ([#5745](AztecProtocol/aztec-packages#5745)) ([4d754aa](AztecProtocol/aztec-packages@4d754aa)) * **ci:** Fix arm e2e references, spot shutdown ([#5741](AztecProtocol/aztec-packages#5741)) ([1c4667c](AztecProtocol/aztec-packages@1c4667c)) * **ci:** Hotfix arm ([1ddb1c7](AztecProtocol/aztec-packages@1ddb1c7)) * **ci:** Hotfix just one ARM task ([10f27ae](AztecProtocol/aztec-packages@10f27ae)) * **ci:** Speculative deploy fix ([9a9eab6](AztecProtocol/aztec-packages@9a9eab6)) * **ci:** Wait for mainnet fork deployment ([#5735](AztecProtocol/aztec-packages#5735)) ([8f3794d](AztecProtocol/aztec-packages@8f3794d)) * **ci:** Wait_for_fork env var ([#5780](AztecProtocol/aztec-packages#5780)) ([d85267b](AztecProtocol/aztec-packages@d85267b)) * Correct ICE panic messages in brillig `convert_black_box_call` (noir-lang/noir#4761) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Disable flakey vanilla recursion test ([#5672](AztecProtocol/aztec-packages#5672)) ([f84f7b6](AztecProtocol/aztec-packages@f84f7b6)) * Don't run e2e tests against wrong anvil ([#5686](AztecProtocol/aztec-packages#5686)) ([9ff45f6](AztecProtocol/aztec-packages@9ff45f6)) * Dont error in bench summary ([#5693](AztecProtocol/aztec-packages#5693)) ([470b0f3](AztecProtocol/aztec-packages@470b0f3)) * E2e getStack, disable failing e2e ([#5768](AztecProtocol/aztec-packages#5768)) ([e5f3ece](AztecProtocol/aztec-packages@e5f3ece)) * GA concurrency ([#5713](AztecProtocol/aztec-packages#5713)) ([eac2585](AztecProtocol/aztec-packages@eac2585)) * Generate_aztecnr_reference.js not getting generics or multi-line params ([#5679](AztecProtocol/aztec-packages#5679)) ([a22bc3d](AztecProtocol/aztec-packages@a22bc3d)) * Hotfix submodule cache ([92b92b3](AztecProtocol/aztec-packages@92b92b3)) * Hotfix underspec'd machine ([#5710](AztecProtocol/aztec-packages#5710)) ([059e38e](AztecProtocol/aztec-packages@059e38e)) * **hotfix:** CI ignore git safe.directory checks ([#5659](AztecProtocol/aztec-packages#5659)) ([9fc3fe3](AztecProtocol/aztec-packages@9fc3fe3)) * Less earthly cache ([#5690](AztecProtocol/aztec-packages#5690)) ([8190dc7](AztecProtocol/aztec-packages@8190dc7)) * Make earthly more parallel ([#5747](AztecProtocol/aztec-packages#5747)) ([9734455](AztecProtocol/aztec-packages@9734455)) * Primary_message typo in errors.rs ([#5646](AztecProtocol/aztec-packages#5646)) ([1dfbe7b](AztecProtocol/aztec-packages@1dfbe7b)) * Pull noir ([#5699](AztecProtocol/aztec-packages#5699)) ([bf35464](AztecProtocol/aztec-packages@bf35464)) * REDO dont error in bench summary ([#5695](AztecProtocol/aztec-packages#5695)) ([8c1a7b9](AztecProtocol/aztec-packages@8c1a7b9)) * Running e2e tests as part of build, requires forcing ip4 (not ip6) when connecting to anvil ([#5744](AztecProtocol/aztec-packages#5744)) ([66fc89f](AztecProtocol/aztec-packages@66fc89f)) * Simplify ECCVM prover constructor and add a TODO ([#5681](AztecProtocol/aztec-packages#5681)) ([8c151ea](AztecProtocol/aztec-packages@8c151ea)) * Spot refcount ([#5746](AztecProtocol/aztec-packages#5746)) ([9e18444](AztecProtocol/aztec-packages@9e18444)) * Take a deep copy of circuit inputs for proving ([#5777](AztecProtocol/aztec-packages#5777)) ([785591e](AztecProtocol/aztec-packages@785591e)) * Temporarily disable the bench tests ([#5755](AztecProtocol/aztec-packages#5755)) ([1d52ac5](AztecProtocol/aztec-packages@1d52ac5)) * Update commit for noir-gates-diff (noir-lang/noir#4773) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Use entrypoint instead of pay_init_fee ([#5623](AztecProtocol/aztec-packages#5623)) ([62ac765](AztecProtocol/aztec-packages@62ac765)) * Watch less files. ([#5651](AztecProtocol/aztec-packages#5651)) ([57a1d69](AztecProtocol/aztec-packages@57a1d69)) ### Miscellaneous * Add missing aztec-address tests ([#5674](AztecProtocol/aztec-packages#5674)) ([58aefba](AztecProtocol/aztec-packages@58aefba)) * **avm:** Add a boolean to toggle proving in AVM unit tests ([#5667](AztecProtocol/aztec-packages#5667)) ([ec122c9](AztecProtocol/aztec-packages@ec122c9)), closes [#5663](AztecProtocol/aztec-packages#5663) * **avm:** Hashing tests cleanup ([#5733](AztecProtocol/aztec-packages#5733)) ([53d0102](AztecProtocol/aztec-packages@53d0102)) * **avm:** Range checks negative tests ([#5770](AztecProtocol/aztec-packages#5770)) ([2907142](AztecProtocol/aztec-packages@2907142)) * **avm:** Split the negative test on range check for high 16-bit registers ([#5785](AztecProtocol/aztec-packages#5785)) ([8ebbe57](AztecProtocol/aztec-packages@8ebbe57)) * **avm:** Split up AVM test contract as it was growing too large ([#5702](AztecProtocol/aztec-packages#5702)) ([5b8e812](AztecProtocol/aztec-packages@5b8e812)) * **aztec-nr:** Minor public interface changes ([#5776](AztecProtocol/aztec-packages#5776)) ([91b8110](AztecProtocol/aztec-packages@91b8110)) * **ci:** Break e2e-deploy into multiple test suites ([#5704](AztecProtocol/aztec-packages#5704)) ([2522294](AztecProtocol/aztec-packages@2522294)) * **ci:** Earthly in spot with persistent cache ([#5644](AztecProtocol/aztec-packages#5644)) ([a39c2f6](AztecProtocol/aztec-packages@a39c2f6)) * **ci:** Hotfix AMI's, workflow to stop personal spot runners ([#5712](AztecProtocol/aztec-packages#5712)) ([5f18139](AztecProtocol/aztec-packages@5f18139)) * **ci:** Only run ARM on master ([#5705](AztecProtocol/aztec-packages#5705)) ([f77c142](AztecProtocol/aztec-packages@f77c142)) * **ci:** Use 128 cores for x86 and add timeouts ([#5665](AztecProtocol/aztec-packages#5665)) ([0c5dc0a](AztecProtocol/aztec-packages@0c5dc0a)) * Compute_note_hash_and_nullifier - improve error message ([#5671](AztecProtocol/aztec-packages#5671)) ([8942d69](AztecProtocol/aztec-packages@8942d69)) * Create placeholder version of 0.26.0 docs (noir-lang/noir#4782) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * **doc:** Fix broken docs links (noir-lang/noir#4606) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * **docs:** Fix link in the Data Types page (noir-lang/noir#4527) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Don't strip bb wasm ([#5743](AztecProtocol/aztec-packages#5743)) ([d4cb410](AztecProtocol/aztec-packages@d4cb410)) * Fix master after merge issue related to validate_trace renaming ([#5676](AztecProtocol/aztec-packages#5676)) ([44e0d8a](AztecProtocol/aztec-packages@44e0d8a)) * Fix max-block-number and auth e2e tests ([#5694](AztecProtocol/aztec-packages#5694)) ([f1bf314](AztecProtocol/aztec-packages@f1bf314)) * Op queue ([#5648](AztecProtocol/aztec-packages#5648)) ([822c7e6](AztecProtocol/aztec-packages@822c7e6)) * **public:** Remove getNullifierMembershipWitness ([#5715](AztecProtocol/aztec-packages#5715)) ([3be402c](AztecProtocol/aztec-packages@3be402c)) * Re-enable e2e fees tests ([#5784](AztecProtocol/aztec-packages#5784)) ([102e8b8](AztecProtocol/aztec-packages@102e8b8)) * Release Noir(0.27.0) (noir-lang/noir#4632) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Remove the old Value struct from the oracle docs (noir-lang/noir#4738) ([1eb288e](AztecProtocol/aztec-packages@1eb288e)) * Replace relative paths to noir-protocol-circuits ([fb2b298](AztecProtocol/aztec-packages@fb2b298)) * Replace relative paths to noir-protocol-circuits ([e20920d](AztecProtocol/aztec-packages@e20920d)) * Replace relative paths to noir-protocol-circuits ([6351dc5](AztecProtocol/aztec-packages@6351dc5)) * Replace relative paths to noir-protocol-circuits ([fee13bf](AztecProtocol/aztec-packages@fee13bf)) * Replacing unsafe::zeroed() ([#5685](AztecProtocol/aztec-packages#5685)) ([ea3884e](AztecProtocol/aztec-packages@ea3884e)) * Small logging changes ([#5654](AztecProtocol/aztec-packages#5654)) ([25cc70d](AztecProtocol/aztec-packages@25cc70d)) * Temporarily skip failing e2e fees test ([a3ac5ff](AztecProtocol/aztec-packages@a3ac5ff)) * Testing that nargo fmt is idempotent (noir-lang/noir#4765) ([825c455](AztecProtocol/aztec-packages@825c455)) * TS hash wrappers cleanup ([#5691](AztecProtocol/aztec-packages#5691)) ([7f8b09f](AztecProtocol/aztec-packages@7f8b09f)) * Turn ENABLE_GAS where it is needed ([#5730](AztecProtocol/aztec-packages#5730)) ([30a2edd](AztecProtocol/aztec-packages@30a2edd)) * Update noir gates diff ([#5658](AztecProtocol/aztec-packages#5658)) ([9816c1a](AztecProtocol/aztec-packages@9816c1a)) * We can run 35 of our e2e tests just using jest. ([#5643](AztecProtocol/aztec-packages#5643)) ([4fcaeae](AztecProtocol/aztec-packages@4fcaeae)) ### Documentation * Fix yp typo control-flow.md ([#5638](AztecProtocol/aztec-packages#5638)) ([363d227](AztecProtocol/aztec-packages@363d227)) </details> <details><summary>barretenberg: 0.35.0</summary> ## [0.35.0](AztecProtocol/aztec-packages@barretenberg-v0.34.0...barretenberg-v0.35.0) (2024-04-16) ### ⚠ BREAKING CHANGES * Use fixed size arrays in black box functions where sizes are known ([#5620](AztecProtocol/aztec-packages#5620)) * trap with revert data ([#5732](AztecProtocol/aztec-packages#5732)) * **acir:** BrilligCall opcode ([#5709](AztecProtocol/aztec-packages#5709)) ### Features * **acir:** BrilligCall opcode ([#5709](AztecProtocol/aztec-packages#5709)) ([f06f64c](AztecProtocol/aztec-packages@f06f64c)) * **avm:** CMOV opcode ([#5575](AztecProtocol/aztec-packages#5575)) ([19dbe46](AztecProtocol/aztec-packages@19dbe46)), closes [#5557](AztecProtocol/aztec-packages#5557) * **avm:** Enable contract testing with bb binary ([#5584](AztecProtocol/aztec-packages#5584)) ([d007d79](AztecProtocol/aztec-packages@d007d79)) * **avm:** Enable range check on the ALU registers ([#5696](AztecProtocol/aztec-packages#5696)) ([202fc1b](AztecProtocol/aztec-packages@202fc1b)) * Changing finite field arithmetic in wasm to 29 bits for multiplications ([#5435](AztecProtocol/aztec-packages#5435)) ([b2d9b9d](AztecProtocol/aztec-packages@b2d9b9d)) * **ci:** Turn on new CI as mandatory ([#5761](AztecProtocol/aztec-packages#5761)) ([bebed32](AztecProtocol/aztec-packages@bebed32)) * Export poseidon2_permutation and add to foundation/crypto ([#5706](AztecProtocol/aztec-packages#5706)) ([6b91e27](AztecProtocol/aztec-packages@6b91e27)) * LT/LTE for AVM ([#5559](AztecProtocol/aztec-packages#5559)) ([350abeb](AztecProtocol/aztec-packages@350abeb)) * Trap with revert data ([#5732](AztecProtocol/aztec-packages#5732)) ([f849575](AztecProtocol/aztec-packages@f849575)) * Use fixed size arrays in black box functions where sizes are known ([#5620](AztecProtocol/aztec-packages#5620)) ([f50b180](AztecProtocol/aztec-packages@f50b180)) ### Bug Fixes * "feat: Changing finite field arithmetic in wasm to 29 bits for multiplications" ([#5779](AztecProtocol/aztec-packages#5779)) ([bcfee97](AztecProtocol/aztec-packages@bcfee97)) * Avoid get row in databus ([#5742](AztecProtocol/aztec-packages#5742)) ([d67b6c8](AztecProtocol/aztec-packages@d67b6c8)) * **ci:** Bigger cache disk, cache+prune docker images, disable ClientIvcTests.Full ([#5729](AztecProtocol/aztec-packages#5729)) ([5dcbd75](AztecProtocol/aztec-packages@5dcbd75)) * Disable flakey vanilla recursion test ([#5672](AztecProtocol/aztec-packages#5672)) ([f84f7b6](AztecProtocol/aztec-packages@f84f7b6)) * Less earthly cache ([#5690](AztecProtocol/aztec-packages#5690)) ([8190dc7](AztecProtocol/aztec-packages@8190dc7)) * Make earthly more parallel ([#5747](AztecProtocol/aztec-packages#5747)) ([9734455](AztecProtocol/aztec-packages@9734455)) * Simplify ECCVM prover constructor and add a TODO ([#5681](AztecProtocol/aztec-packages#5681)) ([8c151ea](AztecProtocol/aztec-packages@8c151ea)) ### Miscellaneous * **avm:** Add a boolean to toggle proving in AVM unit tests ([#5667](AztecProtocol/aztec-packages#5667)) ([ec122c9](AztecProtocol/aztec-packages@ec122c9)), closes [#5663](AztecProtocol/aztec-packages#5663) * **avm:** Range checks negative tests ([#5770](AztecProtocol/aztec-packages#5770)) ([2907142](AztecProtocol/aztec-packages@2907142)) * **avm:** Split the negative test on range check for high 16-bit registers ([#5785](AztecProtocol/aztec-packages#5785)) ([8ebbe57](AztecProtocol/aztec-packages@8ebbe57)) * **ci:** Use 128 cores for x86 and add timeouts ([#5665](AztecProtocol/aztec-packages#5665)) ([0c5dc0a](AztecProtocol/aztec-packages@0c5dc0a)) * Don't strip bb wasm ([#5743](AztecProtocol/aztec-packages#5743)) ([d4cb410](AztecProtocol/aztec-packages@d4cb410)) * Fix master after merge issue related to validate_trace renaming ([#5676](AztecProtocol/aztec-packages#5676)) ([44e0d8a](AztecProtocol/aztec-packages@44e0d8a)) * Op queue ([#5648](AztecProtocol/aztec-packages#5648)) ([822c7e6](AztecProtocol/aztec-packages@822c7e6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

ledwards2225 added 3 commits April 10, 2024 22:07

simplify prover constructor

e961af9

Merge branch 'master' into lde/eccvm_cleanup

c41d898

woops, share all

6326320

ledwards2225 requested a review from lucasxia01 April 10, 2024 22:42

comment

ce83d5e

ledwards2225 marked this pull request as ready for review April 10, 2024 22:52

ledwards2225 changed the title ~~fix: Fix missing polynomials and simplify ECCVM prover constructor~~ fix: Simplify ECCVM prover constructor and add a TODO Apr 10, 2024

ledwards2225 self-assigned this Apr 10, 2024

lucasxia01 approved these changes Apr 11, 2024

View reviewed changes

lucasxia01 reviewed Apr 11, 2024

View reviewed changes

ledwards2225 merged commit 8c151ea into master Apr 11, 2024
130 of 161 checks passed

ledwards2225 deleted the lde/eccvm_cleanup branch April 11, 2024 13:41

AztecBot mentioned this pull request Apr 11, 2024

chore(master): Release 0.35.0 #5650

Merged

ledwards2225 mentioned this pull request Apr 11, 2024

fix: set z_perm and lookup_inverses for proving key in ECCVM and Translator #5558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Simplify ECCVM prover constructor and add a TODO #5681

fix: Simplify ECCVM prover constructor and add a TODO #5681

ledwards2225 commented Apr 10, 2024 •

edited

Loading

AztecBot commented Apr 10, 2024

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

lucasxia01 left a comment •

edited

Loading

lucasxia01 Apr 11, 2024

ledwards2225 Apr 11, 2024

lucasxia01 Apr 11, 2024

ledwards2225 Apr 11, 2024

lucasxia01 Apr 11, 2024

lucasxia01 Apr 11, 2024

ledwards2225 Apr 11, 2024

fix: Simplify ECCVM prover constructor and add a TODO #5681

fix: Simplify ECCVM prover constructor and add a TODO #5681

Conversation

ledwards2225 commented Apr 10, 2024 • edited Loading

AztecBot commented Apr 10, 2024

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

lucasxia01 left a comment • edited Loading

Choose a reason for hiding this comment

lucasxia01 Apr 11, 2024

Choose a reason for hiding this comment

ledwards2225 Apr 11, 2024

Choose a reason for hiding this comment

lucasxia01 Apr 11, 2024

Choose a reason for hiding this comment

ledwards2225 Apr 11, 2024

Choose a reason for hiding this comment

lucasxia01 Apr 11, 2024

Choose a reason for hiding this comment

lucasxia01 Apr 11, 2024

Choose a reason for hiding this comment

ledwards2225 Apr 11, 2024

Choose a reason for hiding this comment

ledwards2225 commented Apr 10, 2024 •

edited

Loading

lucasxia01 left a comment •

edited

Loading