fix(avm-transpiler): FDIV and U128 test case

[fcarreiro]

FDIV does not take a tag. Current state was breaking serialization.

[fcarreiro]

• fix(avm-transpiler): FDIV and U128 test case #5200 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[spalladino]

LGTM, but I'm not familiar enough with the AVM to approve it. I have no idea what a tag is in the context of the AVM to begin with...

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (8): 209 (+44%)
• note_trial_decrypting_time_in_ms (8): 11.4 (-78%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 201c5e1c and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,412	239,332	469,808
l1_rollup_execution_gas	667,093	954,242	1,337,165
l2_block_processing_time_in_ms	1,251 (+2%)	4,715 (+4%)	9,359 (+5%)
note_successful_decrypting_time_in_ms	⚠️ 209 (+44%)	478 (+1%)	921 (+3%)
note_trial_decrypting_time_in_ms	⚠️ 11.4 (-78%)	95.4 (+8%)	51.5 (-59%)
l2_block_building_time_in_ms	18,334 (+2%)	69,262 (+1%)	137,834 (+1%)
l2_block_rollup_simulation_time_in_ms	8,199 (+3%)	28,977 (+3%)	57,499 (+4%)
l2_block_public_tx_process_time_in_ms	10,113 (+2%)	40,229 (-1%)	80,238

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,165 (+1%)	27,148 (+1%)
note_history_successful_decrypting_time_in_ms	1,330 (+1%)	2,460 (+2%)
note_history_trial_decrypting_time_in_ms	135 (+40%)	153 (+13%)
node_database_size_in_bytes	19,103,824	35,651,664
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	284	44,370	27,700
private-kernel-ordering	217 (+1%)	52,324	14,326
base-parity	1,806 (+2%)	128	311
base-rollup	726 (+1%)	177,083	925
root-parity	1,587 (-2%)	1,244	311
root-rollup	68.8 (+1%)	4,487	789
private-kernel-inner	638 (+1%)	73,229	27,700
public-kernel-app-logic	447	35,262	28,215
public-kernel-tail	175 (-1%)	40,926	28,215
merge-rollup	8.27 (+2%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.90 (+1%)	15.8 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.579 (+1%)	0.490 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.8 (+2%)	71.2 (+1%)	228 (+3%)	442	861 (+4%)	1,705 (+3%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471 (+2%)	0.441 (+1%)	0.418 (+3%)	0.414	0.411 (+4%)	0.409 (+3%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.5 (+3%)	106	332 (+2%)	655	1,302 (+4%)	2,591 (+3%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.487 (+4%)	0.477	0.454 (+3%)	0.452	0.452 (+4%)	0.452 (+3%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.8 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,014

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	4,057 (+3%)	1,740 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	12.8 (+3%)	1,247 (-1%)

[jeanmon]

LGTM. @fcarreiro Have a look at the feedback though.

[jeanmon]

@fcarreiro We define FDIV without any tag? In this way, we can save the tag in the serialization. That's good.

[jeanmon]

@fcarreiro All good. I did not see the first comment above.

[jeanmon]

If this is the only test, I would welcome to have integer values which fit into U128 but not into other lower integer types such as U64, etc... This way we know this is really working for truly U128 integers.
Just replace the values by: 11111111111....., 22222222.... and it remains very readable.

[fcarreiro]

Merge activity

• Mar 14, 3:57 AM EDT: @fcarreiro merged this pull request with Graphite.