Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate EthAddress size in aztec-nr #5198

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

spalladino
Copy link
Collaborator

Ensure the field element backing an EthAddress in aztec-nr is no larger than 20 bytes.

@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (32): 574 (+19%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit cfd673d6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,820 36,356
l1_rollup_calldata_gas 66,328 239,032 468,884
l1_rollup_execution_gas 667,009 953,942 1,336,241
l2_block_processing_time_in_ms 1,277 (-2%) 4,746 (+1%) 8,925
note_successful_decrypting_time_in_ms 145 (-27%) ⚠️ 574 (+19%) 934 (-1%)
note_trial_decrypting_time_in_ms 48.5 (-54%) 89.6 (-10%) 67.6 (-8%)
l2_block_building_time_in_ms 18,426 (-1%) 69,647 137,350 (-1%)
l2_block_rollup_simulation_time_in_ms 8,302 29,507 (+1%) 57,295
l2_block_public_tx_process_time_in_ms 10,100 (-1%) 40,078 (-2%) 79,952 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,925 26,733 (-10%)
note_history_successful_decrypting_time_in_ms 1,200 (-3%) 2,398 (-5%)
note_history_trial_decrypting_time_in_ms 72.0 (-23%) 128 (-37%)
node_database_size_in_bytes 19,054,672 35,647,568
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 285 (-1%) 44,370 27,700
private-kernel-ordering 218 (-1%) 52,324 14,326
base-parity 1,885 (-2%) 128 311
base-rollup 728 177,083 925
root-parity 1,609 (+11%) 1,244 311
root-rollup 69.0 (+1%) 4,487 789
private-kernel-inner 638 (-1%) 73,229 27,700
public-kernel-app-logic 451 (-2%) 35,262 28,215
public-kernel-tail 177 (-3%) 40,926 28,215
merge-rollup 8.26 (-1%) 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.97 16.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.581 0.496 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 45.8 72.2 230 444 879 (+2%) 1,716 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.470 0.445 0.420 0.416 0.417 (+1%) 0.412 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 53.8 (+1%) 107 (+1%) 335 657 (-1%) 1,309 2,602 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.480 (+1%) 0.482 (+1%) 0.456 0.453 0.454 0.452 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.4 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.538 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,014

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 4,013 (-1%) 1,749 (-1%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 12.5 (-16%) 1,261 (-2%)

@spalladino spalladino enabled auto-merge (squash) March 13, 2024 18:11
@spalladino spalladino merged commit 201c5e1 into master Mar 13, 2024
97 checks passed
@spalladino spalladino deleted the palla/assert-eth-address-bit-size branch March 13, 2024 18:20
critesjosh pushed a commit that referenced this pull request Mar 14, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.28.0</summary>

##
[0.28.0](aztec-package-v0.27.2...aztec-package-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](#5175))

### Features

* Support contracts with no constructor
([#5175](#5175))
([df7fa32](df7fa32))
</details>

<details><summary>barretenberg.js: 0.28.0</summary>

##
[0.28.0](barretenberg.js-v0.27.2...barretenberg.js-v0.28.0)
(2024-03-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.28.0</summary>

##
[0.28.0](aztec-cli-v0.27.2...aztec-cli-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](#5175))

### Features

* Support contracts with no constructor
([#5175](#5175))
([df7fa32](df7fa32))
</details>

<details><summary>aztec-packages: 0.28.0</summary>

##
[0.28.0](aztec-packages-v0.27.2...aztec-packages-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](#5175))

### Features

* **avm-simulator:** Euclidean and field div
([#5181](#5181))
([037a38f](037a38f))
* Isolate Plonk dependencies
([#5068](#5068))
([5cbbd7d](5cbbd7d))
* New brillig field operations and refactor of binary operations
([#5208](#5208))
([eb69504](eb69504))
* Parallelize linearly dependent contribution in PG
([#4742](#4742))
([d1799ae](d1799ae))
* Parity circuits
([#5082](#5082))
([335c46e](335c46e))
* Support contracts with no constructor
([#5175](#5175))
([df7fa32](df7fa32))
* Track side effects in public
([#5129](#5129))
([d666f6f](d666f6f)),
closes
[#5185](#5185)
* Update SMT Circuit class and add gate relaxation functionality
([#5176](#5176))
([5948996](5948996))


### Bug Fixes

* **avm-transpiler:** FDIV and U128 test case
([#5200](#5200))
([6977e81](6977e81))
* Barretenberg-acir-tests-bb.js thru version bump
([#5216](#5216))
([9298f93](9298f93))
* Do not release docs on every commit to master
([#5214](#5214))
([c34a299](c34a299))
* Fail transaction if we revert in setup or teardown
([#5093](#5093))
([db9a960](db9a960))
* Intermittent invert 0 in Goblin
([#5189](#5189))
([6c70624](6c70624))
* Point docs links to current tag if available
([#5219](#5219))
([0e9c7c7](0e9c7c7))
* Remove embedded srs
([#5173](#5173))
([cfd673d](cfd673d))
* Split setup/teardown functions when there's no public app logic
([#5156](#5156))
([2ee13b3](2ee13b3))
* Validate EthAddress size in aztec-nr
([#5198](#5198))
([201c5e1](201c5e1))


### Miscellaneous

* Add dependency instructions to bberg README
([#5187](#5187))
([850febc](850febc))
* **avm-simulator:** Make sure we support Map storage
([#5207](#5207))
([08835f9](08835f9))
* **avm-simulator:** Restructure contract storage tests
([#5194](#5194))
([fcdd1cc](fcdd1cc))
* **docs:** Add details to getting started contract deployment
([#5220](#5220))
([5c267ae](5c267ae))
* Moving wit comms and witness and comm labels from instance to oink
([#5199](#5199))
([19eb7f9](19eb7f9))
* Oink
([#5210](#5210))
([321f149](321f149))
* Pull noir
([#5193](#5193))
([aa90f6e](aa90f6e))
* Trying to fix intermitent ci failure for boxes
([#5182](#5182))
([f988cb8](f988cb8))


### Documentation

* **yellow-paper:** Add pseudocode for verifying broadcasted functions
in contract deployment
([#4431](#4431))
([8bdb921](8bdb921))
</details>

<details><summary>barretenberg: 0.28.0</summary>

##
[0.28.0](barretenberg-v0.27.2...barretenberg-v0.28.0)
(2024-03-14)


### Features

* **avm-simulator:** Euclidean and field div
([#5181](#5181))
([037a38f](037a38f))
* Isolate Plonk dependencies
([#5068](#5068))
([5cbbd7d](5cbbd7d))
* New brillig field operations and refactor of binary operations
([#5208](#5208))
([eb69504](eb69504))
* Parallelize linearly dependent contribution in PG
([#4742](#4742))
([d1799ae](d1799ae))
* Update SMT Circuit class and add gate relaxation functionality
([#5176](#5176))
([5948996](5948996))


### Bug Fixes

* Barretenberg-acir-tests-bb.js thru version bump
([#5216](#5216))
([9298f93](9298f93))
* Intermittent invert 0 in Goblin
([#5189](#5189))
([6c70624](6c70624))
* Remove embedded srs
([#5173](#5173))
([cfd673d](cfd673d))


### Miscellaneous

* Add dependency instructions to bberg README
([#5187](#5187))
([850febc](850febc))
* Moving wit comms and witness and comm labels from instance to oink
([#5199](#5199))
([19eb7f9](19eb7f9))
* Oink
([#5210](#5210))
([321f149](321f149))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.28.0</summary>

##
[0.28.0](AztecProtocol/aztec-packages@aztec-package-v0.27.2...aztec-package-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](AztecProtocol/aztec-packages#5175))

### Features

* Support contracts with no constructor
([#5175](AztecProtocol/aztec-packages#5175))
([df7fa32](AztecProtocol/aztec-packages@df7fa32))
</details>

<details><summary>barretenberg.js: 0.28.0</summary>

##
[0.28.0](AztecProtocol/aztec-packages@barretenberg.js-v0.27.2...barretenberg.js-v0.28.0)
(2024-03-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.28.0</summary>

##
[0.28.0](AztecProtocol/aztec-packages@aztec-cli-v0.27.2...aztec-cli-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](AztecProtocol/aztec-packages#5175))

### Features

* Support contracts with no constructor
([#5175](AztecProtocol/aztec-packages#5175))
([df7fa32](AztecProtocol/aztec-packages@df7fa32))
</details>

<details><summary>aztec-packages: 0.28.0</summary>

##
[0.28.0](AztecProtocol/aztec-packages@aztec-packages-v0.27.2...aztec-packages-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](AztecProtocol/aztec-packages#5175))

### Features

* **avm-simulator:** Euclidean and field div
([#5181](AztecProtocol/aztec-packages#5181))
([037a38f](AztecProtocol/aztec-packages@037a38f))
* Isolate Plonk dependencies
([#5068](AztecProtocol/aztec-packages#5068))
([5cbbd7d](AztecProtocol/aztec-packages@5cbbd7d))
* New brillig field operations and refactor of binary operations
([#5208](AztecProtocol/aztec-packages#5208))
([eb69504](AztecProtocol/aztec-packages@eb69504))
* Parallelize linearly dependent contribution in PG
([#4742](AztecProtocol/aztec-packages#4742))
([d1799ae](AztecProtocol/aztec-packages@d1799ae))
* Parity circuits
([#5082](AztecProtocol/aztec-packages#5082))
([335c46e](AztecProtocol/aztec-packages@335c46e))
* Support contracts with no constructor
([#5175](AztecProtocol/aztec-packages#5175))
([df7fa32](AztecProtocol/aztec-packages@df7fa32))
* Track side effects in public
([#5129](AztecProtocol/aztec-packages#5129))
([d666f6f](AztecProtocol/aztec-packages@d666f6f)),
closes
[#5185](AztecProtocol/aztec-packages#5185)
* Update SMT Circuit class and add gate relaxation functionality
([#5176](AztecProtocol/aztec-packages#5176))
([5948996](AztecProtocol/aztec-packages@5948996))


### Bug Fixes

* **avm-transpiler:** FDIV and U128 test case
([#5200](AztecProtocol/aztec-packages#5200))
([6977e81](AztecProtocol/aztec-packages@6977e81))
* Barretenberg-acir-tests-bb.js thru version bump
([#5216](AztecProtocol/aztec-packages#5216))
([9298f93](AztecProtocol/aztec-packages@9298f93))
* Do not release docs on every commit to master
([#5214](AztecProtocol/aztec-packages#5214))
([c34a299](AztecProtocol/aztec-packages@c34a299))
* Fail transaction if we revert in setup or teardown
([#5093](AztecProtocol/aztec-packages#5093))
([db9a960](AztecProtocol/aztec-packages@db9a960))
* Intermittent invert 0 in Goblin
([#5189](AztecProtocol/aztec-packages#5189))
([6c70624](AztecProtocol/aztec-packages@6c70624))
* Point docs links to current tag if available
([#5219](AztecProtocol/aztec-packages#5219))
([0e9c7c7](AztecProtocol/aztec-packages@0e9c7c7))
* Remove embedded srs
([#5173](AztecProtocol/aztec-packages#5173))
([cfd673d](AztecProtocol/aztec-packages@cfd673d))
* Split setup/teardown functions when there's no public app logic
([#5156](AztecProtocol/aztec-packages#5156))
([2ee13b3](AztecProtocol/aztec-packages@2ee13b3))
* Validate EthAddress size in aztec-nr
([#5198](AztecProtocol/aztec-packages#5198))
([201c5e1](AztecProtocol/aztec-packages@201c5e1))


### Miscellaneous

* Add dependency instructions to bberg README
([#5187](AztecProtocol/aztec-packages#5187))
([850febc](AztecProtocol/aztec-packages@850febc))
* **avm-simulator:** Make sure we support Map storage
([#5207](AztecProtocol/aztec-packages#5207))
([08835f9](AztecProtocol/aztec-packages@08835f9))
* **avm-simulator:** Restructure contract storage tests
([#5194](AztecProtocol/aztec-packages#5194))
([fcdd1cc](AztecProtocol/aztec-packages@fcdd1cc))
* **docs:** Add details to getting started contract deployment
([#5220](AztecProtocol/aztec-packages#5220))
([5c267ae](AztecProtocol/aztec-packages@5c267ae))
* Moving wit comms and witness and comm labels from instance to oink
([#5199](AztecProtocol/aztec-packages#5199))
([19eb7f9](AztecProtocol/aztec-packages@19eb7f9))
* Oink
([#5210](AztecProtocol/aztec-packages#5210))
([321f149](AztecProtocol/aztec-packages@321f149))
* Pull noir
([#5193](AztecProtocol/aztec-packages#5193))
([aa90f6e](AztecProtocol/aztec-packages@aa90f6e))
* Trying to fix intermitent ci failure for boxes
([#5182](AztecProtocol/aztec-packages#5182))
([f988cb8](AztecProtocol/aztec-packages@f988cb8))


### Documentation

* **yellow-paper:** Add pseudocode for verifying broadcasted functions
in contract deployment
([#4431](AztecProtocol/aztec-packages#4431))
([8bdb921](AztecProtocol/aztec-packages@8bdb921))
</details>

<details><summary>barretenberg: 0.28.0</summary>

##
[0.28.0](AztecProtocol/aztec-packages@barretenberg-v0.27.2...barretenberg-v0.28.0)
(2024-03-14)


### Features

* **avm-simulator:** Euclidean and field div
([#5181](AztecProtocol/aztec-packages#5181))
([037a38f](AztecProtocol/aztec-packages@037a38f))
* Isolate Plonk dependencies
([#5068](AztecProtocol/aztec-packages#5068))
([5cbbd7d](AztecProtocol/aztec-packages@5cbbd7d))
* New brillig field operations and refactor of binary operations
([#5208](AztecProtocol/aztec-packages#5208))
([eb69504](AztecProtocol/aztec-packages@eb69504))
* Parallelize linearly dependent contribution in PG
([#4742](AztecProtocol/aztec-packages#4742))
([d1799ae](AztecProtocol/aztec-packages@d1799ae))
* Update SMT Circuit class and add gate relaxation functionality
([#5176](AztecProtocol/aztec-packages#5176))
([5948996](AztecProtocol/aztec-packages@5948996))


### Bug Fixes

* Barretenberg-acir-tests-bb.js thru version bump
([#5216](AztecProtocol/aztec-packages#5216))
([9298f93](AztecProtocol/aztec-packages@9298f93))
* Intermittent invert 0 in Goblin
([#5189](AztecProtocol/aztec-packages#5189))
([6c70624](AztecProtocol/aztec-packages@6c70624))
* Remove embedded srs
([#5173](AztecProtocol/aztec-packages#5173))
([cfd673d](AztecProtocol/aztec-packages@cfd673d))


### Miscellaneous

* Add dependency instructions to bberg README
([#5187](AztecProtocol/aztec-packages#5187))
([850febc](AztecProtocol/aztec-packages@850febc))
* Moving wit comms and witness and comm labels from instance to oink
([#5199](AztecProtocol/aztec-packages#5199))
([19eb7f9](AztecProtocol/aztec-packages@19eb7f9))
* Oink
([#5210](AztecProtocol/aztec-packages#5210))
([321f149](AztecProtocol/aztec-packages@321f149))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
sklppy88 pushed a commit that referenced this pull request Mar 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.28.0</summary>

##
[0.28.0](aztec-package-v0.27.2...aztec-package-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](#5175))

### Features

* Support contracts with no constructor
([#5175](#5175))
([df7fa32](df7fa32))
</details>

<details><summary>barretenberg.js: 0.28.0</summary>

##
[0.28.0](barretenberg.js-v0.27.2...barretenberg.js-v0.28.0)
(2024-03-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.28.0</summary>

##
[0.28.0](aztec-cli-v0.27.2...aztec-cli-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](#5175))

### Features

* Support contracts with no constructor
([#5175](#5175))
([df7fa32](df7fa32))
</details>

<details><summary>aztec-packages: 0.28.0</summary>

##
[0.28.0](aztec-packages-v0.27.2...aztec-packages-v0.28.0)
(2024-03-14)


### ⚠ BREAKING CHANGES

* Support contracts with no constructor
([#5175](#5175))

### Features

* **avm-simulator:** Euclidean and field div
([#5181](#5181))
([037a38f](037a38f))
* Isolate Plonk dependencies
([#5068](#5068))
([5cbbd7d](5cbbd7d))
* New brillig field operations and refactor of binary operations
([#5208](#5208))
([eb69504](eb69504))
* Parallelize linearly dependent contribution in PG
([#4742](#4742))
([d1799ae](d1799ae))
* Parity circuits
([#5082](#5082))
([335c46e](335c46e))
* Support contracts with no constructor
([#5175](#5175))
([df7fa32](df7fa32))
* Track side effects in public
([#5129](#5129))
([d666f6f](d666f6f)),
closes
[#5185](#5185)
* Update SMT Circuit class and add gate relaxation functionality
([#5176](#5176))
([5948996](5948996))


### Bug Fixes

* **avm-transpiler:** FDIV and U128 test case
([#5200](#5200))
([6977e81](6977e81))
* Barretenberg-acir-tests-bb.js thru version bump
([#5216](#5216))
([9298f93](9298f93))
* Do not release docs on every commit to master
([#5214](#5214))
([c34a299](c34a299))
* Fail transaction if we revert in setup or teardown
([#5093](#5093))
([db9a960](db9a960))
* Intermittent invert 0 in Goblin
([#5189](#5189))
([6c70624](6c70624))
* Point docs links to current tag if available
([#5219](#5219))
([0e9c7c7](0e9c7c7))
* Remove embedded srs
([#5173](#5173))
([cfd673d](cfd673d))
* Split setup/teardown functions when there's no public app logic
([#5156](#5156))
([2ee13b3](2ee13b3))
* Validate EthAddress size in aztec-nr
([#5198](#5198))
([201c5e1](201c5e1))


### Miscellaneous

* Add dependency instructions to bberg README
([#5187](#5187))
([850febc](850febc))
* **avm-simulator:** Make sure we support Map storage
([#5207](#5207))
([08835f9](08835f9))
* **avm-simulator:** Restructure contract storage tests
([#5194](#5194))
([fcdd1cc](fcdd1cc))
* **docs:** Add details to getting started contract deployment
([#5220](#5220))
([5c267ae](5c267ae))
* Moving wit comms and witness and comm labels from instance to oink
([#5199](#5199))
([19eb7f9](19eb7f9))
* Oink
([#5210](#5210))
([321f149](321f149))
* Pull noir
([#5193](#5193))
([aa90f6e](aa90f6e))
* Trying to fix intermitent ci failure for boxes
([#5182](#5182))
([f988cb8](f988cb8))


### Documentation

* **yellow-paper:** Add pseudocode for verifying broadcasted functions
in contract deployment
([#4431](#4431))
([8bdb921](8bdb921))
</details>

<details><summary>barretenberg: 0.28.0</summary>

##
[0.28.0](barretenberg-v0.27.2...barretenberg-v0.28.0)
(2024-03-14)


### Features

* **avm-simulator:** Euclidean and field div
([#5181](#5181))
([037a38f](037a38f))
* Isolate Plonk dependencies
([#5068](#5068))
([5cbbd7d](5cbbd7d))
* New brillig field operations and refactor of binary operations
([#5208](#5208))
([eb69504](eb69504))
* Parallelize linearly dependent contribution in PG
([#4742](#4742))
([d1799ae](d1799ae))
* Update SMT Circuit class and add gate relaxation functionality
([#5176](#5176))
([5948996](5948996))


### Bug Fixes

* Barretenberg-acir-tests-bb.js thru version bump
([#5216](#5216))
([9298f93](9298f93))
* Intermittent invert 0 in Goblin
([#5189](#5189))
([6c70624](6c70624))
* Remove embedded srs
([#5173](#5173))
([cfd673d](cfd673d))


### Miscellaneous

* Add dependency instructions to bberg README
([#5187](#5187))
([850febc](850febc))
* Moving wit comms and witness and comm labels from instance to oink
([#5199](#5199))
([19eb7f9](19eb7f9))
* Oink
([#5210](#5210))
([321f149](321f149))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants