feat(avm): tagged memory

[fcarreiro]

• Added tagged memory model for public VM
• Updated opcodes and tests to pass

Some things still missing

• Checking in/dstTag in most opcodes
• Default values for uninitialized memory (had a discussion with @Maddiaa0 for now this is good and might be ok long term but we need to double check)
• Of course addressing modes, etc

[Maddiaa0]

Overall pretty happy with this! let me know when its finished up and i can merge!

[Maddiaa0]

I assume more tests are coming for this?

[fcarreiro]

Yes (but not in this PR! lmk if you feel strongly). I'm thinking if it makes sense to test everything here (for the types) AND in the arithmetic+bitwise opcodes, or if there's a less verbose way. (note that there will be massive duplication).

[Maddiaa0]

Sounds good i can wait until later!

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 26.9 (-78%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 18581265 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,524	866,848	3,448,276
l1_rollup_execution_gas	313,943	984,520	3,667,865
l2_block_processing_time_in_ms	1,440 (+3%)	5,349 (+1%)	20,945
note_successful_decrypting_time_in_ms	239	801 (+1%)	3,145
note_trial_decrypting_time_in_ms	46.8	⚠️ 26.9 (-78%)	156 (+5%)
l2_block_building_time_in_ms	16,103	63,917	256,039
l2_block_rollup_simulation_time_in_ms	11,720	46,612	186,859 (-1%)
l2_block_public_tx_process_time_in_ms	4,353	17,217	68,722 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,314 (+2%)	31,148 (+2%)
note_history_successful_decrypting_time_in_ms	1,967	3,841
note_history_trial_decrypting_time_in_ms	159 (+18%)	239 (-4%)
node_database_size_in_bytes	3,585,678	3,623,264
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	213 (-1%)	44,681	25,561
private-kernel-ordering	165 (-1%)	43,753	14,809
base-rollup	1,197 (-2%)	128,338	881
root-rollup	79.3 (-2%)	4,088	677
private-kernel-inner	292 (-1%)	71,208	25,561
public-kernel-private-input	205 (-1%)	31,863	25,561
public-kernel-non-first-iteration	203 (-1%)	31,905	25,561
merge-rollup	7.65	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	12.2 (+1%)	20.3 (+9%)	14.3	19.4 (-4%)	25.5 (-1%)	70.2 (+4%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.625 (+1%)	0.731 (+11%)	0.577 (-1%)	0.539 (-3%)	0.483 (-1%)	0.443	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	93.8 (+6%)	52.4 (+1%)	257 (+1%)	483 (+1%)	913	3,564
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.510 (+2%)	0.500 (+1%)	0.443 (+1%)	0.438	0.428	0.426
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	118 (+1%)	62.8 (+1%)	374 (+1%)	771 (+1%)	1,441 (+1%)	5,623 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.507 (+2%)	0.503	0.478	0.483 (-1%)	0.474	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	68.5 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.598	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,222

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	377	1,086 (-1%)

Metric	1 public data writes
tx_sequencer_processing_time_ms	535 (-1%)