Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that public data tree root follows from left to right rollup #396

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

spalladino
Copy link
Collaborator

Checks that the end root of the public data tree in the left previous rollup matches the start of the one in the right previous rollup, for both merge and root rollup circuits.

Fixes #270 (combined with #357 and #387)

@spalladino spalladino requested a review from Maddiaa0 April 27, 2023 15:07
Maddiaa0
Maddiaa0 previously approved these changes Apr 27, 2023
@Maddiaa0 Maddiaa0 dismissed their stale review April 27, 2023 16:06

accident

Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me, ping me when the circuits ts test is sorted

@spalladino spalladino force-pushed the palla/check-public-data-tree-in-rollup-merges branch from f229ded to 73407e8 Compare April 27, 2023 16:42
@spalladino spalladino requested a review from Maddiaa0 April 27, 2023 17:16
@spalladino
Copy link
Collaborator Author

@Cheethas it's sorted

@Maddiaa0 Maddiaa0 merged commit 6d2a29f into master Apr 27, 2023
@Maddiaa0 Maddiaa0 deleted the palla/check-public-data-tree-in-rollup-merges branch April 27, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update base/merge/root rollup circuits to process public data (state transitions, tree snapshots)
2 participants