Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update structs for processing public function data in rollup circuits #357

Merged
merged 7 commits into from
Apr 26, 2023

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Apr 24, 2023

Changes related to processing public function data in rollup circuits, instead of in public kernel circuit.

  • Add missing public data tree fields to root rollup public inputs
  • Set public data tree start and end roots in merge and root circuits
  • Update base rollup inputs and public kernel circuit inputs and outputs
  • Update public data tree in circuit block builder and not in public tx processor
  • Verify state reads in base rollup circuit
  • Process state transitions in base rollup circuit
  • Include new fields in root rollup calldata hash (see Root Rollup Public Input Hash #353 and Update rollup contract to incorporate public data in state hashing #272 )

Related to #270

@benesjan benesjan mentioned this pull request Apr 25, 2023
6 tasks
@spalladino spalladino force-pushed the palla/public_fn_data_in_rollup_circuits branch 3 times, most recently from ba2ed59 to 56d15dc Compare April 25, 2023 20:17
@spalladino spalladino force-pushed the palla/public_fn_data_in_rollup_circuits branch from bc1eed0 to 6ccce96 Compare April 25, 2023 21:30
@spalladino spalladino marked this pull request as ready for review April 25, 2023 21:37
@spalladino spalladino requested a review from PhilWindle April 25, 2023 21:37
@spalladino spalladino changed the title Process public function data in rollup circuits Update structs for processing public function data in rollup circuits Apr 25, 2023
@PhilWindle PhilWindle merged commit 1117f2f into master Apr 26, 2023
@PhilWindle PhilWindle deleted the palla/public_fn_data_in_rollup_circuits branch April 26, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants