Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EFS file storage to devnet nodes #3584

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Dec 5, 2023

Closes #3568

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@AztecBot
Copy link
Collaborator

AztecBot commented Dec 5, 2023

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (8): 13.7 (-36%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e7b5fc90 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,912 868,184 3,449,480
l1_rollup_execution_gas 841,999 3,595,292 22,204,849
l2_block_processing_time_in_ms 2,193 (-1%) 8,615 (+1%) 35,105 (-1%)
note_successful_decrypting_time_in_ms 306 (-2%) 918 3,323 (-1%)
note_trial_decrypting_time_in_ms ⚠️ 13.7 (-36%) 44.6 (+7%) 200
l2_block_building_time_in_ms 20,282 79,979 (-1%) 321,105 (-1%)
l2_block_rollup_simulation_time_in_ms 16,738 66,135 (-1%) 265,421 (-1%)
l2_block_public_tx_process_time_in_ms 3,504 (-3%) 13,771 (-1%) 55,442 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,786 (-2%) 47,398 (-3%)
note_history_successful_decrypting_time_in_ms 2,168 (-5%) 4,181 (-6%)
note_history_trial_decrypting_time_in_ms 164 (+1%) 352 (-11%)
node_database_size_in_bytes 3,617,033 3,920,765
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 199 43,109 20,441
private-kernel-ordering 115 25,833 9,689
base-rollup 2,960 667,692 873
root-rollup 86.0 (-5%) 4,072 881
private-kernel-inner 261 64,516 20,441
public-kernel-private-input 171 (-1%) 25,203 20,441
public-kernel-non-first-iteration 168 (-1%) 25,245 20,441
merge-rollup 10.8 (-1%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 10,323 25,938

@PhilWindle PhilWindle merged commit 5b590eb into master Dec 6, 2023
82 checks passed
@PhilWindle PhilWindle deleted the spy/node-efs branch December 6, 2023 09:18
rahul-kothari pushed a commit that referenced this pull request Dec 6, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.5</summary>

##
[0.16.5](aztec-packages-v0.16.4...aztec-packages-v0.16.5)
(2023-12-06)


### Features

* Add EFS file storage to devnet nodes
([#3584](#3584))
([5b590eb](5b590eb))


### Bug Fixes

* **ci:** Aztec node devnet healthchecks
([#3598](#3598))
([1a9d742](1a9d742))
* **ci:** Count for EFS AZ2
([#3597](#3597))
([d427bca](d427bca))
* **ci:** L1-contracts npm release
([#3596](#3596))
([008df50](008df50))
* **ci:** Node health-check + contract address env vars
([#3578](#3578))
([fffc700](fffc700))


### Miscellaneous

* Make noir-circuit independent of aztec-nr
([#3591](#3591))
([3013354](3013354))
* Remove foundation and types deps from boxes
([#3389](#3389))
([eade352](eade352))
* Renaming blockstree to archive
([#3569](#3569))
([6c200e9](6c200e9))
* Trivial change roundup
([#3556](#3556))
([ff893b2](ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](#3585))
([9773e8c](9773e8c))
</details>

<details><summary>barretenberg.js: 0.16.5</summary>

##
[0.16.5](barretenberg.js-v0.16.4...barretenberg.js-v0.16.5)
(2023-12-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.16.5</summary>

##
[0.16.5](barretenberg-v0.16.4...barretenberg-v0.16.5)
(2023-12-06)


### Miscellaneous

* Trivial change roundup
([#3556](#3556))
([ff893b2](ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](#3585))
([9773e8c](9773e8c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Dec 7, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.5</summary>

##
[0.16.5](AztecProtocol/aztec-packages@aztec-packages-v0.16.4...aztec-packages-v0.16.5)
(2023-12-06)


### Features

* Add EFS file storage to devnet nodes
([#3584](AztecProtocol/aztec-packages#3584))
([5b590eb](AztecProtocol/aztec-packages@5b590eb))


### Bug Fixes

* **ci:** Aztec node devnet healthchecks
([#3598](AztecProtocol/aztec-packages#3598))
([1a9d742](AztecProtocol/aztec-packages@1a9d742))
* **ci:** Count for EFS AZ2
([#3597](AztecProtocol/aztec-packages#3597))
([d427bca](AztecProtocol/aztec-packages@d427bca))
* **ci:** L1-contracts npm release
([#3596](AztecProtocol/aztec-packages#3596))
([008df50](AztecProtocol/aztec-packages@008df50))
* **ci:** Node health-check + contract address env vars
([#3578](AztecProtocol/aztec-packages#3578))
([fffc700](AztecProtocol/aztec-packages@fffc700))


### Miscellaneous

* Make noir-circuit independent of aztec-nr
([#3591](AztecProtocol/aztec-packages#3591))
([3013354](AztecProtocol/aztec-packages@3013354))
* Remove foundation and types deps from boxes
([#3389](AztecProtocol/aztec-packages#3389))
([eade352](AztecProtocol/aztec-packages@eade352))
* Renaming blockstree to archive
([#3569](AztecProtocol/aztec-packages#3569))
([6c200e9](AztecProtocol/aztec-packages@6c200e9))
* Trivial change roundup
([#3556](AztecProtocol/aztec-packages#3556))
([ff893b2](AztecProtocol/aztec-packages@ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](AztecProtocol/aztec-packages#3585))
([9773e8c](AztecProtocol/aztec-packages@9773e8c))
</details>

<details><summary>barretenberg.js: 0.16.5</summary>

##
[0.16.5](AztecProtocol/aztec-packages@barretenberg.js-v0.16.4...barretenberg.js-v0.16.5)
(2023-12-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.16.5</summary>

##
[0.16.5](AztecProtocol/aztec-packages@barretenberg-v0.16.4...barretenberg-v0.16.5)
(2023-12-06)


### Miscellaneous

* Trivial change roundup
([#3556](AztecProtocol/aztec-packages#3556))
([ff893b2](AztecProtocol/aztec-packages@ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](AztecProtocol/aztec-packages#3585))
([9773e8c](AztecProtocol/aztec-packages@9773e8c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add EFS volumes to devnet nodes
3 participants