Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove foundation and types deps from boxes #3389

Merged
merged 19 commits into from
Dec 5, 2023
Merged

Conversation

dan-aztec
Copy link
Contributor

@dan-aztec dan-aztec commented Nov 22, 2023

first part of #3340

note: removing the dependency on circuits.js, which previously provided the circuits wasm, was done in #3421 .

tested that the boxes still work after that update!

@dan-aztec dan-aztec enabled auto-merge (squash) November 22, 2023 15:38
@AztecBot
Copy link
Collaborator

AztecBot commented Nov 22, 2023

Benchmark results

Metrics with a significant change:

  • note_history_trial_decrypting_time_in_ms (10): 235 (-41%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e7b5fc90 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,900 868,184 3,449,528
l1_rollup_execution_gas 841,987 3,595,292 22,204,897
l2_block_processing_time_in_ms 2,221 (+1%) 8,527 35,130 (-1%)
note_successful_decrypting_time_in_ms 314 923 (+1%) 3,315 (-1%)
note_trial_decrypting_time_in_ms 23.6 (+10%) 48.3 (+16%) 199 (-1%)
l2_block_building_time_in_ms 20,283 80,601 322,255 (-1%)
l2_block_rollup_simulation_time_in_ms 16,727 66,651 266,346 (-1%)
l2_block_public_tx_process_time_in_ms 3,523 (-2%) 13,883 55,663 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,928 (-2%) 47,625 (-2%)
note_history_successful_decrypting_time_in_ms 2,160 (-6%) 4,208 (-6%)
note_history_trial_decrypting_time_in_ms 163 (+1%) ⚠️ 235 (-41%)
node_database_size_in_bytes 3,635,359 3,924,305
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 200 43,109 20,441
private-kernel-ordering 115 25,833 9,689
base-rollup 2,968 667,692 873
root-rollup 91.0 (+1%) 4,072 881
private-kernel-inner 261 64,516 20,441
public-kernel-private-input 172 (-1%) 25,203 20,441
public-kernel-non-first-iteration 169 (-1%) 25,245 20,441
merge-rollup 10.8 (-1%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 10,323 25,938

Copy link

socket-security bot commented Nov 27, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@dan-aztec dan-aztec changed the title chore: remove founation and types deps from boxes chore: remove foundation and types deps from boxes Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 20:17

Pull Request is not mergeable

@dan-aztec dan-aztec linked an issue Nov 27, 2023 that may be closed by this pull request
@dan-aztec dan-aztec enabled auto-merge (squash) November 27, 2023 21:57
@@ -10,7 +10,7 @@ import { Fr } from '../fields/index.js';
export class AztecAddress extends Fr {
constructor(buffer: Buffer) {
if (buffer.length !== 32) {
throw new Error(`Invalid length ${buffer.length}.`);
throw new Error(`Invalid AztecAddress length ${buffer.length}.`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran into this when testing against published sandbox instead of local version - slightly more detailed error message helps distinguish between these two

@dan-aztec dan-aztec requested a review from LeilaWang November 27, 2023 21:58
@dan-aztec dan-aztec merged commit eade352 into master Dec 5, 2023
74 of 76 checks passed
@dan-aztec dan-aztec deleted the dan/aztecjs-deps branch December 5, 2023 21:03
rahul-kothari pushed a commit that referenced this pull request Dec 6, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.5</summary>

##
[0.16.5](aztec-packages-v0.16.4...aztec-packages-v0.16.5)
(2023-12-06)


### Features

* Add EFS file storage to devnet nodes
([#3584](#3584))
([5b590eb](5b590eb))


### Bug Fixes

* **ci:** Aztec node devnet healthchecks
([#3598](#3598))
([1a9d742](1a9d742))
* **ci:** Count for EFS AZ2
([#3597](#3597))
([d427bca](d427bca))
* **ci:** L1-contracts npm release
([#3596](#3596))
([008df50](008df50))
* **ci:** Node health-check + contract address env vars
([#3578](#3578))
([fffc700](fffc700))


### Miscellaneous

* Make noir-circuit independent of aztec-nr
([#3591](#3591))
([3013354](3013354))
* Remove foundation and types deps from boxes
([#3389](#3389))
([eade352](eade352))
* Renaming blockstree to archive
([#3569](#3569))
([6c200e9](6c200e9))
* Trivial change roundup
([#3556](#3556))
([ff893b2](ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](#3585))
([9773e8c](9773e8c))
</details>

<details><summary>barretenberg.js: 0.16.5</summary>

##
[0.16.5](barretenberg.js-v0.16.4...barretenberg.js-v0.16.5)
(2023-12-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.16.5</summary>

##
[0.16.5](barretenberg-v0.16.4...barretenberg-v0.16.5)
(2023-12-06)


### Miscellaneous

* Trivial change roundup
([#3556](#3556))
([ff893b2](ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](#3585))
([9773e8c](9773e8c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Dec 7, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.5</summary>

##
[0.16.5](AztecProtocol/aztec-packages@aztec-packages-v0.16.4...aztec-packages-v0.16.5)
(2023-12-06)


### Features

* Add EFS file storage to devnet nodes
([#3584](AztecProtocol/aztec-packages#3584))
([5b590eb](AztecProtocol/aztec-packages@5b590eb))


### Bug Fixes

* **ci:** Aztec node devnet healthchecks
([#3598](AztecProtocol/aztec-packages#3598))
([1a9d742](AztecProtocol/aztec-packages@1a9d742))
* **ci:** Count for EFS AZ2
([#3597](AztecProtocol/aztec-packages#3597))
([d427bca](AztecProtocol/aztec-packages@d427bca))
* **ci:** L1-contracts npm release
([#3596](AztecProtocol/aztec-packages#3596))
([008df50](AztecProtocol/aztec-packages@008df50))
* **ci:** Node health-check + contract address env vars
([#3578](AztecProtocol/aztec-packages#3578))
([fffc700](AztecProtocol/aztec-packages@fffc700))


### Miscellaneous

* Make noir-circuit independent of aztec-nr
([#3591](AztecProtocol/aztec-packages#3591))
([3013354](AztecProtocol/aztec-packages@3013354))
* Remove foundation and types deps from boxes
([#3389](AztecProtocol/aztec-packages#3389))
([eade352](AztecProtocol/aztec-packages@eade352))
* Renaming blockstree to archive
([#3569](AztecProtocol/aztec-packages#3569))
([6c200e9](AztecProtocol/aztec-packages@6c200e9))
* Trivial change roundup
([#3556](AztecProtocol/aztec-packages#3556))
([ff893b2](AztecProtocol/aztec-packages@ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](AztecProtocol/aztec-packages#3585))
([9773e8c](AztecProtocol/aztec-packages@9773e8c))
</details>

<details><summary>barretenberg.js: 0.16.5</summary>

##
[0.16.5](AztecProtocol/aztec-packages@barretenberg.js-v0.16.4...barretenberg.js-v0.16.5)
(2023-12-06)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.16.5</summary>

##
[0.16.5](AztecProtocol/aztec-packages@barretenberg-v0.16.4...barretenberg-v0.16.5)
(2023-12-06)


### Miscellaneous

* Trivial change roundup
([#3556](AztecProtocol/aztec-packages#3556))
([ff893b2](AztecProtocol/aztec-packages@ff893b2))


### Documentation

* Add libstdc++-12-dev to setup instructions
([#3585](AztecProtocol/aztec-packages#3585))
([9773e8c](AztecProtocol/aztec-packages@9773e8c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Boxes should only depend on aztec.js.
3 participants