fix: sequencer aborts in-progress block #2883

alexghr · 2023-10-16T18:44:49Z

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

AztecBot · 2023-10-16T19:11:04Z

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 38d045f5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,948	867,404	3,448,016
l1_rollup_execution_gas	842,035	3,594,512	22,203,385
l2_block_processing_time_in_ms	⚠️ 1,259 (+20%)	⚠️ 4,749 (+23%)	⚠️ 18,914 (+25%)
note_successful_decrypting_time_in_ms	⚠️ 384 (+17%)	⚠️ 1,231 (+27%)	⚠️ 4,624 (+29%)
note_trial_decrypting_time_in_ms	⚠️ 86.0 (+187%)	⚠️ 110 (+38%)	146 (+7%)
l2_block_building_time_in_ms	⚠️ 10,969 (+23%)	⚠️ 44,391 (+24%)	⚠️ 187,605 (+26%)
l2_block_rollup_simulation_time_in_ms	⚠️ 8,212 (+25%)	⚠️ 33,325 (+25%)	⚠️ 131,590 (+26%)
l2_block_public_tx_process_time_in_ms	⚠️ 2,708 (+20%)	⚠️ 10,912 (+21%)	⚠️ 55,150 (+26%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	⚠️ 16,173 (+14%)	34,280 (+10%)
note_history_successful_decrypting_time_in_ms	⚠️ 2,950 (+25%)	⚠️ 6,053 (+26%)
note_history_trial_decrypting_time_in_ms	128 (+2%)	159 (+7%)
node_database_size_in_bytes	1,648,823	1,191,548
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	⚠️ 52.8 (+23%)	56,577	14,745
private-kernel-ordering	⚠️ 26.0 (+22%)	20,137	8,089
base-rollup	⚠️ 1,035 (+21%)	631,605	811
root-rollup	⚠️ 46.8 (+23%)	4,072	1,097
private-kernel-inner	⚠️ 43.7 (+23%)	72,288	14,745
public-kernel-private-input	⚠️ 57.6 (+22%)	37,359	14,745
public-kernel-non-first-iteration	⚠️ 34.0 (+22%)	37,401	14,745
merge-rollup	⚠️ 1.14 (+32%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,094

PhilWindle · 2023-10-17T09:17:01Z

yarn-project/sequencer-client/src/sequencer/sequencer.ts

@@ -172,6 +184,8 @@ export class Sequencer {
      // Build the new block by running the rollup circuits
      this.log(`Assembling block with txs ${processedValidTxs.map(tx => tx.hash).join(', ')}`);

+      await assertBlockHeight();
+


Lets put a check in before we publish the block too.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.9.0</summary> ## [0.9.0](aztec-packages-v0.8.14...aztec-packages-v0.9.0) (2023-10-17) ### ⚠ BREAKING CHANGES * nuking `PublicToken` and `PrivateAirdropToken` ([#2873](#2873)) * Change blake3 to blake2 in private kernel ([#2861](#2861)) * nuking private token ([#2822](#2822)) ### Features * Contract ts interface to use only aztec.js imports ([#2876](#2876)) ([6952a1a](6952a1a)) * Faucet ([#2856](#2856)) ([5bad35f](5bad35f)) * Nuking `PublicToken` and `PrivateAirdropToken` ([#2873](#2873)) ([c74311d](c74311d)) * Nuking private token ([#2822](#2822)) ([5d93a47](5d93a47)), closes [#2350](#2350) ### Bug Fixes * Aztec node to save outbox adddress to config ([#2867](#2867)) ([b6418a6](b6418a6)) * Create data dir on node boot ([#2864](#2864)) ([2d498b3](2d498b3)) * Don't repeatedly scan for missing messages ([#2886](#2886)) ([3fe1cc8](3fe1cc8)) * Fix trailing pipe causing everything to rebuild. Sorry... ([d13ba75](d13ba75)) * Pad L1 to L2 messages upon retrieval from L1 ([#2879](#2879)) ([457669e](457669e)) * Sequencer aborts in-progress block ([#2883](#2883)) ([b0915a8](b0915a8)) ### Miscellaneous * Change blake3 to blake2 in private kernel ([#2861](#2861)) ([d629940](d629940)) * Making anvil silent again ([#2866](#2866)) ([90ae5dc](90ae5dc)) * Spell check on forbidden words. ([#2887](#2887)) ([06bc4f9](06bc4f9)) ### Documentation * Initial 'protocol description' toc ([#2844](#2844)) ([cb18f45](cb18f45)) </details> <details><summary>barretenberg.js: 0.9.0</summary> ## [0.9.0](barretenberg.js-v0.8.14...barretenberg.js-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.9.0</summary> ## [0.9.0](barretenberg-v0.8.14...barretenberg-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@aztec-packages-v0.8.14...aztec-packages-v0.9.0) (2023-10-17) ### ⚠ BREAKING CHANGES * nuking `PublicToken` and `PrivateAirdropToken` ([#2873](AztecProtocol/aztec-packages#2873)) * Change blake3 to blake2 in private kernel ([#2861](AztecProtocol/aztec-packages#2861)) * nuking private token ([#2822](AztecProtocol/aztec-packages#2822)) ### Features * Contract ts interface to use only aztec.js imports ([#2876](AztecProtocol/aztec-packages#2876)) ([6952a1a](AztecProtocol/aztec-packages@6952a1a)) * Faucet ([#2856](AztecProtocol/aztec-packages#2856)) ([5bad35f](AztecProtocol/aztec-packages@5bad35f)) * Nuking `PublicToken` and `PrivateAirdropToken` ([#2873](AztecProtocol/aztec-packages#2873)) ([c74311d](AztecProtocol/aztec-packages@c74311d)) * Nuking private token ([#2822](AztecProtocol/aztec-packages#2822)) ([5d93a47](AztecProtocol/aztec-packages@5d93a47)), closes [#2350](AztecProtocol/aztec-packages#2350) ### Bug Fixes * Aztec node to save outbox adddress to config ([#2867](AztecProtocol/aztec-packages#2867)) ([b6418a6](AztecProtocol/aztec-packages@b6418a6)) * Create data dir on node boot ([#2864](AztecProtocol/aztec-packages#2864)) ([2d498b3](AztecProtocol/aztec-packages@2d498b3)) * Don't repeatedly scan for missing messages ([#2886](AztecProtocol/aztec-packages#2886)) ([3fe1cc8](AztecProtocol/aztec-packages@3fe1cc8)) * Fix trailing pipe causing everything to rebuild. Sorry... ([d13ba75](AztecProtocol/aztec-packages@d13ba75)) * Pad L1 to L2 messages upon retrieval from L1 ([#2879](AztecProtocol/aztec-packages#2879)) ([457669e](AztecProtocol/aztec-packages@457669e)) * Sequencer aborts in-progress block ([#2883](AztecProtocol/aztec-packages#2883)) ([b0915a8](AztecProtocol/aztec-packages@b0915a8)) ### Miscellaneous * Change blake3 to blake2 in private kernel ([#2861](AztecProtocol/aztec-packages#2861)) ([d629940](AztecProtocol/aztec-packages@d629940)) * Making anvil silent again ([#2866](AztecProtocol/aztec-packages#2866)) ([90ae5dc](AztecProtocol/aztec-packages@90ae5dc)) * Spell check on forbidden words. ([#2887](AztecProtocol/aztec-packages#2887)) ([06bc4f9](AztecProtocol/aztec-packages@06bc4f9)) ### Documentation * Initial 'protocol description' toc ([#2844](AztecProtocol/aztec-packages#2844)) ([cb18f45](AztecProtocol/aztec-packages@cb18f45)) </details> <details><summary>barretenberg.js: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@barretenberg.js-v0.8.14...barretenberg.js-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@barretenberg-v0.8.14...barretenberg-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

PhilWindle requested changes Oct 17, 2023

View reviewed changes

alexghr added 2 commits October 17, 2023 11:35

refactor: remove unused parameter

aaf372b

fix: abort block building if block height changes

21c3ed3

alexghr force-pushed the alexg/perf/sequencer-abort-block branch from 14e5b7b to 21c3ed3 Compare October 17, 2023 10:35

PhilWindle approved these changes Oct 17, 2023

View reviewed changes

alexghr merged commit b0915a8 into master Oct 17, 2023
2 checks passed

alexghr deleted the alexg/perf/sequencer-abort-block branch October 17, 2023 11:55

AztecBot mentioned this pull request Oct 17, 2023

chore(master): Release 0.9.0 #2865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: sequencer aborts in-progress block #2883

fix: sequencer aborts in-progress block #2883

alexghr commented Oct 16, 2023

AztecBot commented Oct 16, 2023 •

edited

Loading

PhilWindle Oct 17, 2023

fix: sequencer aborts in-progress block #2883

fix: sequencer aborts in-progress block #2883

Conversation

alexghr commented Oct 16, 2023

Checklist:

AztecBot commented Oct 16, 2023 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

PhilWindle Oct 17, 2023

Choose a reason for hiding this comment

AztecBot commented Oct 16, 2023 •

edited

Loading