-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: nuking PublicToken
and PrivateAirdropToken
#2873
Conversation
90c0190
to
34885ad
Compare
Benchmark resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the unencrypted logs proposed in here 😬
yarn-project/noir-contracts/src/contracts/token_contract/src/main.nr
Outdated
Show resolved
Hide resolved
docs/docs/dev_docs/tutorials/writing_dapp/contract_interaction.md
Outdated
Show resolved
Hide resolved
This reverts commit 1c17487.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fix the failing test and then its good. Might just be timeout.
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.9.0</summary> ## [0.9.0](aztec-packages-v0.8.14...aztec-packages-v0.9.0) (2023-10-17) ### ⚠ BREAKING CHANGES * nuking `PublicToken` and `PrivateAirdropToken` ([#2873](#2873)) * Change blake3 to blake2 in private kernel ([#2861](#2861)) * nuking private token ([#2822](#2822)) ### Features * Contract ts interface to use only aztec.js imports ([#2876](#2876)) ([6952a1a](6952a1a)) * Faucet ([#2856](#2856)) ([5bad35f](5bad35f)) * Nuking `PublicToken` and `PrivateAirdropToken` ([#2873](#2873)) ([c74311d](c74311d)) * Nuking private token ([#2822](#2822)) ([5d93a47](5d93a47)), closes [#2350](#2350) ### Bug Fixes * Aztec node to save outbox adddress to config ([#2867](#2867)) ([b6418a6](b6418a6)) * Create data dir on node boot ([#2864](#2864)) ([2d498b3](2d498b3)) * Don't repeatedly scan for missing messages ([#2886](#2886)) ([3fe1cc8](3fe1cc8)) * Fix trailing pipe causing everything to rebuild. Sorry... ([d13ba75](d13ba75)) * Pad L1 to L2 messages upon retrieval from L1 ([#2879](#2879)) ([457669e](457669e)) * Sequencer aborts in-progress block ([#2883](#2883)) ([b0915a8](b0915a8)) ### Miscellaneous * Change blake3 to blake2 in private kernel ([#2861](#2861)) ([d629940](d629940)) * Making anvil silent again ([#2866](#2866)) ([90ae5dc](90ae5dc)) * Spell check on forbidden words. ([#2887](#2887)) ([06bc4f9](06bc4f9)) ### Documentation * Initial 'protocol description' toc ([#2844](#2844)) ([cb18f45](cb18f45)) </details> <details><summary>barretenberg.js: 0.9.0</summary> ## [0.9.0](barretenberg.js-v0.8.14...barretenberg.js-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.9.0</summary> ## [0.9.0](barretenberg-v0.8.14...barretenberg-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@aztec-packages-v0.8.14...aztec-packages-v0.9.0) (2023-10-17) ### ⚠ BREAKING CHANGES * nuking `PublicToken` and `PrivateAirdropToken` ([#2873](AztecProtocol/aztec-packages#2873)) * Change blake3 to blake2 in private kernel ([#2861](AztecProtocol/aztec-packages#2861)) * nuking private token ([#2822](AztecProtocol/aztec-packages#2822)) ### Features * Contract ts interface to use only aztec.js imports ([#2876](AztecProtocol/aztec-packages#2876)) ([6952a1a](AztecProtocol/aztec-packages@6952a1a)) * Faucet ([#2856](AztecProtocol/aztec-packages#2856)) ([5bad35f](AztecProtocol/aztec-packages@5bad35f)) * Nuking `PublicToken` and `PrivateAirdropToken` ([#2873](AztecProtocol/aztec-packages#2873)) ([c74311d](AztecProtocol/aztec-packages@c74311d)) * Nuking private token ([#2822](AztecProtocol/aztec-packages#2822)) ([5d93a47](AztecProtocol/aztec-packages@5d93a47)), closes [#2350](AztecProtocol/aztec-packages#2350) ### Bug Fixes * Aztec node to save outbox adddress to config ([#2867](AztecProtocol/aztec-packages#2867)) ([b6418a6](AztecProtocol/aztec-packages@b6418a6)) * Create data dir on node boot ([#2864](AztecProtocol/aztec-packages#2864)) ([2d498b3](AztecProtocol/aztec-packages@2d498b3)) * Don't repeatedly scan for missing messages ([#2886](AztecProtocol/aztec-packages#2886)) ([3fe1cc8](AztecProtocol/aztec-packages@3fe1cc8)) * Fix trailing pipe causing everything to rebuild. Sorry... ([d13ba75](AztecProtocol/aztec-packages@d13ba75)) * Pad L1 to L2 messages upon retrieval from L1 ([#2879](AztecProtocol/aztec-packages#2879)) ([457669e](AztecProtocol/aztec-packages@457669e)) * Sequencer aborts in-progress block ([#2883](AztecProtocol/aztec-packages#2883)) ([b0915a8](AztecProtocol/aztec-packages@b0915a8)) ### Miscellaneous * Change blake3 to blake2 in private kernel ([#2861](AztecProtocol/aztec-packages#2861)) ([d629940](AztecProtocol/aztec-packages@d629940)) * Making anvil silent again ([#2866](AztecProtocol/aztec-packages#2866)) ([90ae5dc](AztecProtocol/aztec-packages@90ae5dc)) * Spell check on forbidden words. ([#2887](AztecProtocol/aztec-packages#2887)) ([06bc4f9](AztecProtocol/aztec-packages@06bc4f9)) ### Documentation * Initial 'protocol description' toc ([#2844](AztecProtocol/aztec-packages#2844)) ([cb18f45](AztecProtocol/aztec-packages@cb18f45)) </details> <details><summary>barretenberg.js: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@barretenberg.js-v0.8.14...barretenberg.js-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@barretenberg-v0.8.14...barretenberg-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Both tokens are no longer needed as the new
Token
is enough.Note: I decided to not replace the
private token airdrop contract
in private execution test because the test was pretty much identical to thestateful test contract
one.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.