feat: deploy l1 contracts npm pkg #2754
Conversation
rahul-kothari
changed the title
rahul-kothari
force-pushed
the
rk/deploy_l1_contracts
branch
from
5a93367 to
df15d1e
Compare
rahul-kothari
requested review from
ludamad,
PhilWindle,
LHerskind and
Maddiaa0
|
|
||
| function deploy_package() { | ||
| REPOSITORY=$1 | ||
| cd $REPOSITORY | ||
|
|
||
| VERSION=$(extract_tag_version $REPOSITORY true) | ||
| VERSION=$(extract_tag_version $REPOSITORY false) |
There was a problem hiding this comment.
Why is this one changed? Should it not error if failing anymore?
There was a problem hiding this comment.
The idea is to be able to take in this without a tag and see the entire process dry run. Open to thoughts here but this was changed by me then back by @spalladino . This reverts to my intended change allowing dry runs
There was a problem hiding this comment.
So it should be false? @ludamad (remember I'm peanut-brain, so I just need a simple yes/no here 🥜).
There was a problem hiding this comment.
yeap - without it, you can't do dry runs
There was a problem hiding this comment.
Ahh good to know, I wasn't aware that that was the intention. Makes sense then!
| # Generate L1 contract TypeScript artifacts. | ||
| COPY --from=contracts /usr/src/l1-contracts/out /usr/src/l1-contracts/out |
There was a problem hiding this comment.
Why remove this one? Were they redundant with the generate-artifacts.sh?
There was a problem hiding this comment.
No now that we are copying the entire l1-contracts, out directory gets copied with it. So this line is not needed anymore
There was a problem hiding this comment.
Ah yes, I forgot to think.
Introducing https://www.npmjs.com/package/@aztec/l1-contracts
I have manually deployed v0.8.8 (since deploy-npm script works for continual releases). Next release onwards CI should release 0.8.9 automatically!
Also created a README so people don't struggle as much!
Thanks @ludamad @PhilWindle for the help!