Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror L1-contracts to a repo + publish it as an npm package #2453

Closed
Tracked by #2459
rahul-kothari opened this issue Sep 21, 2023 · 1 comment
Closed
Tracked by #2459

Mirror L1-contracts to a repo + publish it as an npm package #2453

rahul-kothari opened this issue Sep 21, 2023 · 1 comment
Assignees
@rahul-kothari

Comments

@rahul-kothari
Copy link
Contributor

rahul-kothari commented Sep 21, 2023 •
edited
Loading

  • This way aztec's l1-contracts can be easily imported for use in foundry or hardhat
  • This is needed for working with portals on Aztec
@rahul-kothari rahul-kothari added this to A3 Sep 21, 2023
@rahul-kothari rahul-kothari self-assigned this Sep 21, 2023
@rahul-kothari rahul-kothari converted this from a draft issue Sep 21, 2023
@rahul-kothari rahul-kothari changed the title Create TokenBridge/Uniswapbridge onn sandbox Create TokenBridge/Uniswapbridge on sandbox Sep 21, 2023
@rahul-kothari rahul-kothari mentioned this issue Sep 22, 2023
Closed
@rahul-kothari rahul-kothari changed the title Create TokenBridge/Uniswapbridge on sandbox Portals don't work on the sandbox - try to Create TokenBridge/Uniswapbridge on sandbox and fix issues! Sep 22, 2023
@rahul-kothari rahul-kothari mentioned this issue Sep 22, 2023
Merged
rahul-kothari added a commit that referenced this issue Sep 22, 2023
@rahul-kothari
feat: expose registry address in getNodeInfo (#2478)
652bb04 
part of #2453 
Users need `getNodeInfo` to add to the Portal contract! Added
`registryAddress` in ArchiverConfig, archiver constructor,
L2BlockSource, pass the address when deploying the sandbox, created
relevant method on aztec node to expose,
@rahul-kothari rahul-kothari changed the title Portals don't work on the sandbox - try to Create TokenBridge/Uniswapbridge on sandbox and fix issues! Mirror L1-contracts to a repo + publish it as an npm package Oct 4, 2023
@rahul-kothari rahul-kothari mentioned this issue Oct 6, 2023
Merged
@LHerskind
Copy link
Contributor

This seems to have been fixed by #2754

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 11, 2023
@Maddiaa0 Maddiaa0 removed this from A3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LHerskind @rahul-kothari