feat: NPM canary deployment #2731
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,18 @@ | ||
| #!/bin/bash | ||
| set -eu | ||
|
|
||
| DIST_TAG=$1 | ||
|
|
||
| if [ -z "$DIST_TAG" ]; then | ||
| echo "No dist tag provided." | ||
| exit 0 | ||
| fi | ||
|
|
||
| echo "Updating Aztec dependencies to tag $DIST_TAG" | ||
|
|
||
| TMP=$(mktemp) | ||
| for PKG in $(jq --raw-output ".dependencies | keys[] | select(contains(\"@aztec/\") and (. != \"@aztec/end-to-end\"))" package.json); do | ||
| jq --arg v $DIST_TAG ".dependencies[\"$PKG\"] = \$v" package.json >$TMP && mv $TMP package.json | ||
| done | ||
|
|
||
| jq ".references = []" tsconfig.json >$TMP && mv $TMP tsconfig.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,16 @@ | ||
| #!/bin/bash | ||
|
|
||
| DIST_TAG=${1:-"latest"} | ||
|
|
||
| extract_repo yarn-project /usr/src project | ||
| PROJECT_ROOT=$(pwd)/project/src/ | ||
|
|
||
| for REPOSITORY in "pxe" "aztec-sandbox"; do | ||
| echo "Deploying $REPOSITORY $TAG" | ||
| RELATIVE_PROJECT_DIR=$(query_manifest relativeProjectDir $REPOSITORY) | ||
| cd "$PROJECT_ROOT/$RELATIVE_PROJECT_DIR" | ||
|
|
||
| deploy_dockerhub $REPOSITORY x86_64 $DIST_TAG | ||
| deploy_dockerhub $REPOSITORY arm64 $DIST_TAG | ||
| create_dockerhub_manifest $REPOSITORY x86_64,arm64 $DIST_TAG | ||
| done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,57 +5,70 @@ set -eu | |
| extract_repo yarn-project /usr/src project | ||
| cd project/src/yarn-project | ||
|
|
||
| echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >.npmrc | ||
|
|
||
| # This is to be used with the 'canary' tag for testing, and then 'latest' for making it public | ||
| DIST_TAG=${1:-} | ||
|
|
||
| function deploy_package() { | ||
| REPOSITORY=$1 | ||
| cd $REPOSITORY | ||
|
|
||
| PACKAGE_NAME=$(jq -r '.name' package.json) | ||
|
|
||
| VERSION=$(extract_tag_version $REPOSITORY true) | ||
| echo "Deploying $REPOSITORY $VERSION $DIST_TAG" | ||
|
|
||
| if [ -n "$DIST_TAG" ]; then | ||
| TAG_ARG="--tag $DIST_TAG" | ||
|
There was a problem hiding this comment. Should this be set to something by default? |
||
| fi | ||
|
|
||
| PUBLISHED_VERSION=$(npm show . version ${TAG_ARG:-} 2>/dev/null) || true | ||
| HIGHER_VERSION=$(npx semver ${VERSION} ${PUBLISHED_VERSION} | tail -1) | ||
|
|
||
| # Check if there is already a published package equal to given version, assume this is a re-run of a deploy | ||
| if [ "$VERSION" == "$PUBLISHED_VERSION" ]; then | ||
| echo "Tagged ${DIST_TAG:+ $DIST_TAG}version $VERSION is equal to published ${DIST_TAG:+ $DIST_TAG}version $PUBLISHED_VERSION." | ||
| echo "Skipping publish." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # If the published version is > the given version, something's gone wrong. | ||
| if [ "$VERSION" != "$HIGHER_VERSION" ]; then | ||
| echo "Tagged version $VERSION is lower than published version $PUBLISHED_VERSION." | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Update the package version in package.json. | ||
| TMP=$(mktemp) | ||
| jq --arg v $VERSION '.version = $v' package.json >$TMP && mv $TMP package.json | ||
|
|
||
| if [ -z "${STANDALONE:-}" ]; then | ||
| # Update each dependent @aztec package version in package.json. | ||
| for PKG in $(jq --raw-output ".dependencies | keys[] | select(contains(\"@aztec/\"))" package.json); do | ||
| jq --arg v $VERSION ".dependencies[\"$PKG\"] = \$v" package.json >$TMP && mv $TMP package.json | ||
| done | ||
| fi | ||
|
|
||
| # Publish | ||
| if [ -n "${COMMIT_TAG:-}" ]; then | ||
| if [ "$DIST_TAG" == "latest" ]; then | ||
| # Check if version exists | ||
|
There was a problem hiding this comment. Not quite sure I follow this block. Doesn't this only apply the dist tag if there is a There was a problem hiding this comment. Yes this was wrong, fixed in bbae4f7 |
||
| # npm show . version --tag canary | ||
| if npm view "$PACKAGE_NAME@$VERSION" version >/dev/null 2>&1; then | ||
| # Tag the existing version | ||
| npm dist-tag add $PACKAGE_NAME@$VERSION $DIST_TAG | ||
| else | ||
| # Publish new verison | ||
| npm publish $TAG_ARG --access public | ||
| fi | ||
| fi | ||
| else | ||
| npm publish --dry-run $TAG_ARG --access public | ||
| fi | ||
|
|
||
| # Back to root | ||
| cd .. | ||
| } | ||
|
|
||
| deploy_package foundation | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.