feat: NPM canary deployment #2731
Conversation
.circleci/config.yml
Outdated
| - canary-browser-test | ||
| - canary-cli-test | ||
|
|
||
| # Deployment and Canary tests |
There was a problem hiding this comment.
| # Deployment and Canary tests | |
| # Production deployment |
| PUBLISHED_VERSION=$(npm show . version ${TAG_ARG:-} 2> /dev/null) || true | ||
| HIGHER_VERSION=$(npx semver ${VERSION} ${PUBLISHED_VERSION} | tail -1) | ||
| if [ -n "$DIST_TAG" ]; then | ||
| TAG_ARG="--tag $DIST_TAG" |
There was a problem hiding this comment.
Should this be set to something by default?
yarn-project/deploy_npm.sh
Outdated
| # Publish | ||
| if [ -n "${COMMIT_TAG:-}" ]; then | ||
| if [ "$DIST_TAG" == "latest" ]; then | ||
| # Check if version exists |
There was a problem hiding this comment.
Not quite sure I follow this block. Doesn't this only apply the dist tag if there is a COMMIT_TAG and the DIST_TAG is latest?
There was a problem hiding this comment.
Yes this was wrong, fixed in bbae4f7
Benchmark resultsAll benchmarks are run on txs on the L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
|
Fixes #2366
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.