chore: Remove Standard Honk

[ledwards2225]

Standard Honk was a stepping stone in our development process and has no role in the final architecture of aztec.

Note: Many of the earlier Honk tests were hard coded for Standard. In most cases I've updated those tests to use Ultra. Some tests that I deemed redundant or unhelpful I have removed altogether. (One Sumcheck test that was redundant with the one that followed it, plus two in SumcheckRound that were redundant with relation correctness/consistency + Sumcheck tests)

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[ludamad]

I assume stuff like honk_tests now all refers to ultrahonk?

[ludamad]

See a few references left to standard_honk_bench

[ludamad]

Notice these:

barretenberg/cpp/src/barretenberg/honk/composer/eccvm_composer.test.cpp:namespace test_standard_honk_composer {
barretenberg/cpp/src/barretenberg/honk/composer/eccvm_composer.test.cpp:} // namespace test_standard_honk_composer
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp: * @brief Compute standard honk id polynomials and put them into cache
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp:void compute_standard_honk_id_polynomials(auto proving_key) // TODO(Cody): proving_key* and shared_ptr<proving_key>
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp: * @brief Compute sigma permutations for standard honk and put them into polynomial cache
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp:void compute_standard_honk_sigma_permutations(const typename Flavor::CircuitBuilder& circuit_constructor,
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.test.cpp:    compute_standard_honk_id_polynomials<Flavor>(proving_key);
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.test.cpp:    compute_standard_honk_sigma_permutations<Flavor>(circuit_constructor, proving_key.get());

[ledwards2225]

Notice these:

barretenberg/cpp/src/barretenberg/honk/composer/eccvm_composer.test.cpp:namespace test_standard_honk_composer {
barretenberg/cpp/src/barretenberg/honk/composer/eccvm_composer.test.cpp:} // namespace test_standard_honk_composer
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp: * @brief Compute standard honk id polynomials and put them into cache
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp:void compute_standard_honk_id_polynomials(auto proving_key) // TODO(Cody): proving_key* and shared_ptr<proving_key>
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp: * @brief Compute sigma permutations for standard honk and put them into polynomial cache
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.hpp:void compute_standard_honk_sigma_permutations(const typename Flavor::CircuitBuilder& circuit_constructor,
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.test.cpp:    compute_standard_honk_id_polynomials<Flavor>(proving_key);
barretenberg/cpp/src/barretenberg/proof_system/composer/permutation_lib.test.cpp:    compute_standard_honk_sigma_permutations<Flavor>(circuit_constructor, proving_key.get());

Thanks for taking a look! This PR (and other similar ones) still need a final pass

[maramihali]

Remove the if constexpr for Ultra here and everywhere else, they were here to be able to include both Standard and Ultra functionality in a single class and not necessary anymore

[maramihali]

Also the requires IsUltraFlavor concepts with which some functions are annotated are not necessary anymore. Remove both here and in the header files

[ledwards2225]

Good call, removed. Left the IsUltraFlavor concept definition because its light and might come in handy

[maramihali]

Thanks again for this work, mostly looks good, I just flagged a couple tiny things.

[maramihali]

can you add a TODO here to use the instance abstraction which requires much less code (or do it yourself if you have time), should be similar or the exact same as the approach in relation_correctness.test.cpp for Ultra and Goblin tests.

[ledwards2225]

I hate the hard-codedness of this too but I dont think the instance abstraction applies here. In the relation tests there is a builder and a genuine circuit from which to construct polynomials. Here we're doing something more isolated and there is no builder or composer. Let me know if I'm missing something

[maramihali]

right yeah, you are right, misread that it doesn't create a full proof, sorry about this

[maramihali]

this test was checking an entire standard_honk manifest explicitly and entirely removing it means we don't have anything similar, can you instead modify it to work with Ultra?

[ledwards2225]

Yeah I debated about this. I'll update it tho just in case it's useful to someone in the future.

[ledwards2225]

done

[maramihali]

Why was this test entirely removed rather than adapted for Ultra?

[ledwards2225]

I think this test was useful as a sanity check during development but it's not useful as a long term test IMO. It's very hard coded based on the current structure of the StandardCircuitConstructor. In UltraCircuitConstructor, due to the need to "create_gates_to_avoid_zero_polynomials" there are far more "dummy" gates at the start of the circuit. So re-writing the analogous test would have to take into account a few dozen of those gates and fail anytime we changed that. I don't see the value

[maramihali]

sounds good, I agree