Skip to content

Commit

Permalink
chore: Remove unneeded dockerfiles. (#2588)
Browse files Browse the repository at this point in the history
Now that we just build the entire project in the root yarn-project, we
don't need to be individually building each project.
We only need to build output artifects, which right now is
`aztec-sandbox`, `canary` and `end-to-end`.
Oh, and the `noir-contracts` stuff, but that build step should be moved
out of yarn-project as yarn-project depends on it, not vice versa.
  • Loading branch information
charlielye authored Sep 28, 2023
1 parent 6eaf0c7 commit d6f903d
Show file tree
Hide file tree
Showing 23 changed files with 18 additions and 342 deletions.
2 changes: 1 addition & 1 deletion build-system/scripts/build_local
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ for E in "${PROJECTS[@]}"; do
docker pull $CACHE_IMAGE_URI
else
docker build ${ADDITIONAL_ARGS:-} --build-arg ARG_COMMIT_HASH=$COMMIT_HASH -f $DOCKERFILE -t $CACHE_IMAGE_URI .
docker tag $CACHE_IMAGE_URI $DEPLOY_IMAGE_URI
fi
docker tag $CACHE_IMAGE_URI $DEPLOY_IMAGE_URI
fi
fi

Expand Down
1 change: 0 additions & 1 deletion build_manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ l1-contracts:
noir-contracts-build:
buildDir: yarn-project
projectDir: yarn-project/noir-contracts
dockerfile: Dockerfile.build
rebuildPatterns:
- ^yarn-project/noir-contracts/
- ^yarn-project/aztec-nr/
Expand Down
14 changes: 0 additions & 14 deletions yarn-project/acir-simulator/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/archiver/Dockerfile

This file was deleted.

16 changes: 0 additions & 16 deletions yarn-project/aztec-node/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/aztec.js/Dockerfile

This file was deleted.

24 changes: 0 additions & 24 deletions yarn-project/circuits.js/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/cli/Dockerfile

This file was deleted.

17 changes: 0 additions & 17 deletions yarn-project/ethereum/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/foundation/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/key-store/Dockerfile

This file was deleted.

14 changes: 0 additions & 14 deletions yarn-project/l1-artifacts/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/merkle-tree/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/noir-compiler/Dockerfile

This file was deleted.

29 changes: 17 additions & 12 deletions yarn-project/noir-contracts/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/yarn-project-base AS builder

COPY . .

FROM ubuntu:lunar
RUN apt-get update && apt-get install -y \
jq \
curl \
git \
sed
WORKDIR /usr/src/yarn-project
COPY noir-contracts noir-contracts
COPY noir-compiler noir-compiler
COPY aztec-nr aztec-nr
WORKDIR /usr/src/yarn-project/noir-contracts
RUN yarn build && yarn test

# Prune dev dependencies. See comment in base image.
RUN yarn cache clean
RUN yarn workspaces focus --production > /dev/null
# Download and extract nargo
ENV NARGO_HOME="/usr/src/yarn-project/noir-contracts/.nargo"
RUN ./scripts/install_noirup.sh $(pwd)
ENV PATH="/usr/src/yarn-project/noir-contracts/.nargo/bin:${PATH}"

FROM node:18-alpine
COPY --from=builder /usr/src/yarn-project/noir-contracts /usr/src/yarn-project/noir-contracts
WORKDIR /usr/src/yarn-project/noir-contracts
ENTRYPOINT ["yarn"]
RUN ./scripts/install_noir.sh
RUN ./scripts/compile_all.sh
RUN ./scripts/nargo_test_ci.sh
20 changes: 0 additions & 20 deletions yarn-project/noir-contracts/Dockerfile.build

This file was deleted.

18 changes: 0 additions & 18 deletions yarn-project/p2p-bootstrap/Dockerfile

This file was deleted.

17 changes: 0 additions & 17 deletions yarn-project/p2p/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/prover-client/Dockerfile

This file was deleted.

15 changes: 0 additions & 15 deletions yarn-project/pxe/Dockerfile

This file was deleted.

21 changes: 0 additions & 21 deletions yarn-project/sequencer-client/Dockerfile

This file was deleted.

14 changes: 0 additions & 14 deletions yarn-project/types/Dockerfile

This file was deleted.

Loading

0 comments on commit d6f903d

Please sign in to comment.