WIP: Milestone 1.4 #183
Closed
WIP: Milestone 1.4 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: PhilWindle <[email protected]>
sirasistant
commented
Apr 5, 2023
| wasm.writeMemory(0, leafPreimage.toBuffer()); | ||
| await wasm.asyncCall('abis__compute_contract_leaf', 0, data.length); | ||
| return Buffer.from(wasm.getMemorySlice(data.length, data.length + 32)); | ||
| export async function computeContractLeaf(wasm: CircuitsWasm, newContractData: NewContractData) { |
There was a problem hiding this comment.
There seems to be an issue in the abis__compute_contract_leaf, if we use it, It won't match the rollup circuit value
LeilaWang
reviewed
Apr 5, 2023
LeilaWang
reviewed
Apr 5, 2023
…ackages into arv/milestone-1-4
…ackages into arv/milestone-1-4
ludamad
pushed a commit
that referenced
this pull request
Apr 14, 2023
* add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: re-usable rollup components * fix: hash_multiple -> hash_pair_native --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: re-usable rollup components * fix: hash_multiple -> hash_pair_native --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: re-usable rollup components * fix: hash_multiple -> hash_pair_native --------- Co-authored-by: Rahul Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist: