Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should generate real note nullifier. #168

Closed
LeilaWang opened this issue Apr 4, 2023 · 0 comments · Fixed by #1051
Closed

Should generate real note nullifier. #168

LeilaWang opened this issue Apr 4, 2023 · 0 comments · Fixed by #1051
Assignees
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).

Comments

@LeilaWang
Copy link
Collaborator

On receiving a note, AccountState should get the nullifier for the note by calling simulator with a view function abi.
And later when the same nullifier is included in a mined block, we know the note has been spent and can be deleted from db.

@iAmMichaelConnor iAmMichaelConnor added the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Apr 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 8, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 🙌 Editing & sharing others’ private states milestone Apr 8, 2023
ludamad pushed a commit that referenced this issue Apr 14, 2023
* initial version of merge rollup

* move previous rollup data from base to merge and update root

* fix ci

* add rollup subtree height

* add tests

* test: change expectd failure regex (#164)

* just use one type of public inputs for base/merge (#168)

* this better work and ignore wasm tests

---------

Co-authored-by: Lasse Herskind <[email protected]>
ludamad pushed a commit that referenced this issue Apr 14, 2023
* fix ci

* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: Reuse merge logic in root when possible

* fix: root enforce left -> right + test fix

* fix: unused right due to assert

* fix: fix unused computed_root

* chore: make loop bonobo friendly

* fix: use `get_sibling_path` in tree

---------

Co-authored-by: Rahul Kothari <[email protected]>
ludamad pushed a commit that referenced this issue Apr 14, 2023
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
* initial version of merge rollup

* move previous rollup data from base to merge and update root

* fix ci

* add rollup subtree height

* add tests

* test: change expectd failure regex (#164)

* just use one type of public inputs for base/merge (#168)

* this better work and ignore wasm tests

---------

Co-authored-by: Lasse Herskind <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
* fix ci

* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: Reuse merge logic in root when possible

* fix: root enforce left -> right + test fix

* fix: unused right due to assert

* fix: fix unused computed_root

* chore: make loop bonobo friendly

* fix: use `get_sibling_path` in tree

---------

Co-authored-by: Rahul Kothari <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
* initial version of merge rollup

* move previous rollup data from base to merge and update root

* fix ci

* add rollup subtree height

* add tests

* test: change expectd failure regex (#164)

* just use one type of public inputs for base/merge (#168)

* this better work and ignore wasm tests

---------

Co-authored-by: Lasse Herskind <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
* fix ci

* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: Reuse merge logic in root when possible

* fix: root enforce left -> right + test fix

* fix: unused right due to assert

* fix: fix unused computed_root

* chore: make loop bonobo friendly

* fix: use `get_sibling_path` in tree

---------

Co-authored-by: Rahul Kothari <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
* add rollup subtree height

* just use one type of public inputs for base/merge (#168)

* fix: re-usable rollup components

* fix: hash_multiple -> hash_pair_native

---------

Co-authored-by: Rahul Kothari <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 13, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants