-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should generate real note nullifier. #168
Labels
T-feature-request
Type: Adding a brand new feature (not to be confused with improving an existing feature).
Comments
iAmMichaelConnor
added
the
T-feature-request
Type: Adding a brand new feature (not to be confused with improving an existing feature).
label
Apr 8, 2023
ludamad
pushed a commit
that referenced
this issue
Apr 14, 2023
* initial version of merge rollup * move previous rollup data from base to merge and update root * fix ci * add rollup subtree height * add tests * test: change expectd failure regex (#164) * just use one type of public inputs for base/merge (#168) * this better work and ignore wasm tests --------- Co-authored-by: Lasse Herskind <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 14, 2023
* fix ci * add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: Reuse merge logic in root when possible * fix: root enforce left -> right + test fix * fix: unused right due to assert * fix: fix unused computed_root * chore: make loop bonobo friendly * fix: use `get_sibling_path` in tree --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 14, 2023
* add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: re-usable rollup components * fix: hash_multiple -> hash_pair_native --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 17, 2023
* initial version of merge rollup * move previous rollup data from base to merge and update root * fix ci * add rollup subtree height * add tests * test: change expectd failure regex (#164) * just use one type of public inputs for base/merge (#168) * this better work and ignore wasm tests --------- Co-authored-by: Lasse Herskind <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 17, 2023
* fix ci * add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: Reuse merge logic in root when possible * fix: root enforce left -> right + test fix * fix: unused right due to assert * fix: fix unused computed_root * chore: make loop bonobo friendly * fix: use `get_sibling_path` in tree --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 17, 2023
* add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: re-usable rollup components * fix: hash_multiple -> hash_pair_native --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 17, 2023
* initial version of merge rollup * move previous rollup data from base to merge and update root * fix ci * add rollup subtree height * add tests * test: change expectd failure regex (#164) * just use one type of public inputs for base/merge (#168) * this better work and ignore wasm tests --------- Co-authored-by: Lasse Herskind <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 17, 2023
* fix ci * add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: Reuse merge logic in root when possible * fix: root enforce left -> right + test fix * fix: unused right due to assert * fix: fix unused computed_root * chore: make loop bonobo friendly * fix: use `get_sibling_path` in tree --------- Co-authored-by: Rahul Kothari <[email protected]>
ludamad
pushed a commit
that referenced
this issue
Apr 17, 2023
* add rollup subtree height * just use one type of public inputs for base/merge (#168) * fix: re-usable rollup components * fix: hash_multiple -> hash_pair_native --------- Co-authored-by: Rahul Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-feature-request
Type: Adding a brand new feature (not to be confused with improving an existing feature).
On receiving a note,
AccountState
should get the nullifier for the note by calling simulator with a view function abi.And later when the same nullifier is included in a mined block, we know the note has been spent and can be deleted from db.
The text was updated successfully, but these errors were encountered: