Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some wasm-related tests + async / await #172

Merged
merged 4 commits into from
Apr 4, 2023
Merged

fix some wasm-related tests + async / await #172

merged 4 commits into from
Apr 4, 2023

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Apr 4, 2023 •
edited
Loading

Description

  • getDummyPreviousKernelData needs pedersen__init
  • don't use randomBytes in snapshot testing

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spypsy spypsy mentioned this pull request Apr 4, 2023
Merged
@spypsy spypsy merged commit 9f13f08 into master Apr 4, 2023
@spypsy spypsy deleted the sp/wasm-test-fixes branch April 4, 2023 14:55
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@phated @kevaundray
feat: Add equality and serialization to poly_triple (#172)
a950ec4 
* NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple

* Light formatting

* remove added newline

* change to default

* diff nit

---------

Co-authored-by: kevaundray <[email protected]>
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@phated @kevaundray
feat: Add equality and serialization to poly_triple (#172)
142b041 
* NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple

* Light formatting

* remove added newline

* change to default

* diff nit

---------

Co-authored-by: kevaundray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spypsy @spalladino