1452: Enabling some skipped tests #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmon
commented
Aug 16, 2023
| @@ -39,7 +39,7 @@ describe('abis wasm bindings', () => { | |||
|
|
|||
| // TODO: This test fails on CI since build-system is not updating the latest circuits wasm | |||
There was a problem hiding this comment.
@spalladino Do you know if build-system is now updating the circuits wasm? I had a green CI after re-enablement of this test but this does not mean it will remain so when circuits change.
There was a problem hiding this comment.
@jeanmon yeah, this should definitely be fixed now! This is from a moment where the CI was a lot flakier than it is now.
There was a problem hiding this comment.
@spalladino Great and thx for the reply. I will remove these comments then.
jeanmon
force-pushed
the
jm/1452-enable-skipped-tests
branch
from
4495f0f to
f254301
Compare
spalladino
approved these changes
Aug 16, 2023
jeanmon
force-pushed
the
jm/1452-enable-skipped-tests
branch
from
f254301 to
50aae08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1452
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.