Skip to content

Commit

Permalink
1452: Add links to dedicated new issues above the skipped tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jeanmon committed Aug 16, 2023
1 parent efd0f2e commit 4495f0f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions yarn-project/acir-simulator/src/public/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ describe('ACIR public execution simulator', () => {
// Contract storage reads and update requests are implemented as built-ins, which at the moment Noir does not
// now whether they have side-effects or not, so they get run even when their code path
// is not picked by a conditional. Once that's fixed, we should re-enable this test.
// Task to repair this test: https://github.com/AztecProtocol/aztec-packages/issues/1588
it.skip('should run the transfer function without enough sender balance', async () => {
const senderBalance = new Fr(10n);
const recipientBalance = new Fr(20n);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ describe('rollup/rollup_wasm_wrapper', () => {
return input;
};

// Task to repair this test: https://github.com/AztecProtocol/aztec-packages/issues/1586
it.skip('calls base_rollup__sim', () => {
const input = makeBaseRollupInputsForCircuit();

Expand Down Expand Up @@ -86,6 +87,7 @@ Refer to https://docs.aztec.network/aztec/protocol/errors for more information.`
}
});

// Task to repair this test: https://github.com/AztecProtocol/aztec-packages/issues/1586
it.skip('calls root_rollup__sim', () => {
const input = makeRootRollupInputs();
for (const rd of input.previousRollupData) {
Expand Down
3 changes: 3 additions & 0 deletions yarn-project/end-to-end/src/e2e_nested_contract.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ describe('e2e_nested_contract', () => {

// Fails with "solver opcode resolution error: cannot solve opcode: expression has too many unknowns %EXPR [ 0 ]%"
// See https://github.com/noir-lang/noir/issues/1347
// Task to repair this test: https://github.com/AztecProtocol/aztec-packages/issues/1587
it.skip('enqueues multiple public calls', async () => {
const tx = parentContract.methods
.enqueueCallToChildTwice(
Expand Down Expand Up @@ -130,6 +131,7 @@ describe('e2e_nested_contract', () => {

// Fails with "solver opcode resolution error: cannot solve opcode: expression has too many unknowns %EXPR [ 0 ]%"
// See https://github.com/noir-lang/noir/issues/1347
// Task to repair this test: https://github.com/AztecProtocol/aztec-packages/issues/1587
it.skip('enqueues multiple public calls with nested public calls', async () => {
const tx = parentContract.methods
.enqueueCallsToPubEntryPoint(
Expand All @@ -149,6 +151,7 @@ describe('e2e_nested_contract', () => {
// Regression for https://github.com/AztecProtocol/aztec-packages/issues/640
// Fails with "solver opcode resolution error: cannot solve opcode: expression has too many unknowns %EXPR [ 0 ]%"
// See https://github.com/noir-lang/noir/issues/1347
// Task to repair this test: https://github.com/AztecProtocol/aztec-packages/issues/1587
it.skip('reads fresh value after write within the same tx', async () => {
const tx = parentContract.methods
.pubEntryPointTwice(
Expand Down

0 comments on commit 4495f0f

Please sign in to comment.