Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aztec.js browser compatibility #1287

Merged
merged 27 commits into from
Aug 2, 2023
Merged

Aztec.js browser compatibility #1287

merged 27 commits into from
Aug 2, 2023

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Jul 31, 2023

Description

Fixes #1059

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spypsy spypsy marked this pull request as draft July 31, 2023 08:24
@LHerskind LHerskind mentioned this pull request Jul 31, 2023
Closed
@spypsy spypsy marked this pull request as ready for review August 1, 2023 19:27
ludamad
ludamad approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice stuff

benesjan
benesjan approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@spypsy spypsy merged commit 68bff29 into master Aug 2, 2023
@spypsy spypsy deleted the sp/aztec-js-browser branch August 2, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aztec.js browser compatibility
3 participants
@spypsy @ludamad @benesjan