Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aztec.js browser compatibility #1059

Closed
spypsy opened this issue Jul 13, 2023 · 0 comments · Fixed by #1287
Closed

Aztec.js browser compatibility #1059

spypsy opened this issue Jul 13, 2023 · 0 comments · Fixed by #1287
Assignees
@spypsy

Comments

@spypsy
Copy link
Member

spypsy commented Jul 13, 2023 •
edited
Loading

Need to consider web browser compatibility of aztec.js & its dependencies.
In the past we've used Buffer polyfills but these are infamously slow.
Would it be worth switching to a more modern JS API like TypedArray or ArrayBuffer?
Probably more cases of non browser-compatible code, Buffer is the most obvious one.
@spypsy spypsy added this to A3 Jul 13, 2023
@spypsy spypsy self-assigned this Jul 13, 2023
@spypsy spypsy converted this from a draft issue Jul 13, 2023
@spypsy spypsy mentioned this issue Jul 31, 2023
Merged
6 tasks
@PhilWindle PhilWindle moved this from Todo to In Progress in A3 Aug 1, 2023
spypsy added a commit that referenced this issue Aug 2, 2023
@spypsy
Aztec.js browser compatibility (#1287)
68bff29 
# Description

Fixes #1059 
# Checklist:

- [ ] I have reviewed my diff in github, line by line.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [ ] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aztec.js browser compatibility AztecProtocol/aztec-packages
3 participants
@spypsy @iAmMichaelConnor @PhilWindle