-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ci3 phase 1 #10042
Merged
chore: ci3 phase 1 #10042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Nov 22, 2024
.github/workflows/ci3.yml
Outdated
on: | ||
push: | ||
branches: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main => master :)
ludamad
requested review from
fcarreiro,
dbanks12,
jeanmon,
IlyasRidhuan and
Maddiaa0
as code owners
November 26, 2024 15:31
fcarreiro
removed request for
dbanks12,
fcarreiro,
IlyasRidhuan,
jeanmon and
Maddiaa0
November 26, 2024 17:00
ludamad
force-pushed
the
cl/ci3-fake-base
branch
from
November 27, 2024 21:36
ddfeea3
to
4ee8344
Compare
charlielye
added
trigger-workflow
Used by ci script to manually trigger CI3.
and removed
trigger-workflow
Used by ci script to manually trigger CI3.
labels
Nov 27, 2024
Co-authored-by: Charlie Lye <[email protected]>
ludamad
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI3 is a conceptual goal for uniting the CI flow and the dev flow as much as possible, adding more depth to the bootstrap and build scripts to be able to handle our needs.
This PR introduces all the work on CI3 so far, but still has an earthly caller shell to make sure we can minimize the number of variables that have changed at once.
There is a lot of changes in this PR.
See https://github.com/AztecProtocol/aztec-packages/pull/10711/files for a subset of the changes without yarn.lock etc noise.
The big picture:
bootstrap pattern, without fully moving off the earthly targets just
yet.
no persistent disk now supporting the build.
There is a global cache on S3, readable without auth, that caches them
for 10 days. We no longer think of the build in terms of docker/buildkit
layers but instead as chunks that have different rebuild patterns that
match files in the monorepo.
Niceties:
uploading by default
instead rely on our builder realizing there is no work to do / hitting a
timeout via shutdown -P
class of flake is gone.
Non-niceties:
their own one-layer builds. The earthly cache is fairly redundant, using
the S3 cache for most meaningful caching. (earthly will not be used in
ci.yml in the future)
rid of earthly helpers, build-system, etc
should move to ECR
issue was hit, will be fixed in a follow-up
WORKFLOW AFTER THIS PR:
full to force a full build
folder
Other useful ci.sh commands are gha-url to see the last github job associated with your branch.
test:e2e
.test
just runs the unit tests as per other projects.