Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from aztec-packages #6931

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: Sync from aztec-packages #6931

wants to merge 7 commits into from

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Jan 3, 2025

Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
chore: radix opcode - remove immediates (AztecProtocol/aztec-packages#10696)
END_COMMIT_OVERRIDE

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Changes to number of Brillig opcodes executed

Generated at commit: 1594db65bf782338b6e25be982df62441ad268b8, compared to commit: ebc4d2cf2b91658a10393733407f33d50a0faaf1

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
simple_radix +2 ❌ +2.90%
array_len +2 ❌ +1.07%
verify_honk_proof -28 ✅ -0.66%
double_verify_honk_proof -56 ✅ -0.75%

Full diff report 👇
Program Brillig opcodes (+/-) %
simple_radix 71 (+2) +2.90%
array_len 189 (+2) +1.07%
regression_4449 201,977 (+1,120) +0.56%
sha256_var_witness_const_regression 7,234 (+34) +0.47%
sha256 15,062 (+66) +0.44%
6 7,482 (+32) +0.43%
conditional_regression_short_circuit 7,560 (+32) +0.43%
array_dynamic_nested_blackbox_input 4,566 (+16) +0.35%
conditional_1 5,733 (+16) +0.28%
to_bytes_consistent 756 (+2) +0.27%
ecdsa_secp256k1 6,805 (+16) +0.24%
hash_to_field 910 (+2) +0.22%
sha256_var_size_regression 16,411 (+34) +0.21%
to_bytes_integration 2,069 (+4) +0.19%
array_dynamic_blackbox_input 18,241 (+32) +0.18%
to_le_bytes 1,154 (+2) +0.17%
sha256_brillig_performance_regression 23,226 (+32) +0.14%
keccak256 34,809 (+32) +0.09%
sha256_regression 118,802 (+98) +0.08%
to_be_bytes 2,454 (+2) +0.08%
7_function 2,539 (+2) +0.08%
simple_shield 2,873 (+2) +0.07%
brillig_cow_regression 519,440 (+354) +0.07%
ram_blowup_regression 779,178 (+528) +0.07%
sha2_byte 47,341 (+32) +0.07%
slices 3,367 (+2) +0.06%
merkle_insert 3,771 (+2) +0.05%
sha256_var_padding_regression 222,312 (+96) +0.04%
u128 24,966 (+4) +0.02%
verify_honk_proof 4,188 (-28) -0.66%
double_verify_honk_proof 7,419 (-56) -0.75%

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Changes to Brillig bytecode sizes

Generated at commit: 1594db65bf782338b6e25be982df62441ad268b8, compared to commit: ebc4d2cf2b91658a10393733407f33d50a0faaf1

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
to_bytes_integration +4 ❌ +4.55%
simple_radix +2 ❌ +2.70%
array_len +2 ❌ +2.08%
to_le_bytes +2 ❌ +1.64%

Full diff report 👇
Program Brillig opcodes (+/-) %
to_bytes_integration 92 (+4) +4.55%
simple_radix 76 (+2) +2.70%
array_len 98 (+2) +2.08%
to_le_bytes 124 (+2) +1.64%
to_bytes_consistent 137 (+2) +1.48%
hash_to_field 141 (+2) +1.44%
sha256_brillig_performance_regression 1,680 (+18) +1.08%
to_be_bytes 214 (+2) +0.94%
sha256_var_witness_const_regression 1,314 (+6) +0.46%
sha256 2,418 (+10) +0.42%
ram_blowup_regression 973 (+4) +0.41%
keccak256 2,205 (+8) +0.36%
sha256_var_size_regression 1,732 (+6) +0.35%
7_function 581 (+2) +0.35%
6 1,195 (+4) +0.34%
conditional_regression_short_circuit 1,268 (+4) +0.32%
brillig_cow_regression 2,173 (+6) +0.28%
regression_4449 753 (+2) +0.27%
merkle_insert 767 (+2) +0.26%
sha256_var_padding_regression 5,141 (+12) +0.23%
array_dynamic_nested_blackbox_input 903 (+2) +0.22%
ecdsa_secp256k1 910 (+2) +0.22%
simple_shield 910 (+2) +0.22%
sha256_regression 6,931 (+14) +0.20%
array_dynamic_blackbox_input 1,034 (+2) +0.19%
conditional_1 1,190 (+2) +0.17%
u128 2,761 (+4) +0.15%
sha2_byte 2,771 (+4) +0.14%
slices 2,188 (+2) +0.09%
bigint 2,197 (+2) +0.09%

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Compilation Report

Program Compilation Time %
sha256_regression 1.351s 0%
regression_4709 0.798s 1%
ram_blowup_regression 15.640s 2%
rollup-root 3.581s -2%
rollup-block-merge 3.598s -16%
rollup-base-public 113.573s -4%
rollup-base-private 96.988s 3%
private-kernel-tail 1.044s 2%
private-kernel-reset 7.203s -1%
private-kernel-inner 2.155s 0%
parity-root 0.792s 1%
noir-contracts 86.752s -1%

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.61M
workspace 123.78M
regression_4709 315.92M
ram_blowup_regression 512.47M
rollup-base-public 3.05G
rollup-base-private 2.97G
private-kernel-tail 181.15M
private-kernel-reset 255.23M
private-kernel-inner 214.34M
parity-root 155.76M

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Compilation Memory Report

Program Peak Memory
keccak256 78.48M
workspace 123.70M
regression_4709 422.91M
ram_blowup_regression 1.58G
rollup-base-public 10.47G
rollup-base-private 6.57G
private-kernel-tail 201.78M
private-kernel-reset 717.04M
private-kernel-inner 291.85M
parity-root 172.11M

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Execution Report

Program Execution Time %
sha256_regression 0.617s -1%
regression_4709 0.400s 5%
ram_blowup_regression 4.389s -1%
rollup-root 2.110s -7%
rollup-block-merge 2.144s -7%
rollup-base-public 36.308s -2%
rollup-base-private 33.077s -1%
private-kernel-tail 0.769s 2%
private-kernel-reset 2.197s -2%
private-kernel-inner 1.248s -1%
parity-root 0.527s -3%

Comment on lines +56 to +67
if args.show_program_hash {
let (mut context, crate_id) =
prepare_package(&workspace_file_manager, &parsed_files, package);
check_crate(&mut context, crate_id, &args.compile_options).unwrap();
let Some(main) = context.get_main_function(&crate_id) else {
continue;
};
let program = monomorphize(main, &mut context.def_interner).unwrap();
let hash = fxhash::hash64(&program);
println!("{}: {:x}", package.name, hash);
continue;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panics on any error... fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants