Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sequencer should handle claims correctly when there are empty epochs #8855

Closed
Tracked by #8679
just-mitch opened this issue Sep 27, 2024 · 0 comments
Closed
Tracked by #8679

fix: sequencer should handle claims correctly when there are empty epochs #8855

just-mitch opened this issue Sep 27, 2024 · 0 comments
Assignees
@just-mitch
Milestone
Sequencer & Prove...

Comments

@just-mitch
Copy link
Collaborator

just-mitch commented Sep 27, 2024 •
edited
Loading

See createProofClaimForPreviousEpoch in sequencer.ts. We should not compute epochToProve as the block's slot minus 1, but should ask the rollup (or compute from the rollup's data) what the epoch that needs proving is, and also read the rollup's value of proofClaim to see if a claim exists.

This is also an issue in the prover node: it submits quotes with the wrong epoch to prove when there are empty epochs.
@just-mitch just-mitch mentioned this issue Sep 27, 2024
Open
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 27, 2024
@just-mitch just-mitch changed the title fix: sequencer should get epoch to prove from rollup fix: sequencer should handle claims correctly when there are empty epochs Sep 27, 2024
@just-mitch just-mitch mentioned this issue Sep 27, 2024
Merged
@aminsammara aminsammara added this to the Sequencer & Prover Testnet milestone Oct 1, 2024
@just-mitch just-mitch self-assigned this Oct 20, 2024
@ludamad ludamad mentioned this issue Oct 21, 2024
Merged
ludamad added a commit that referenced this issue Oct 22, 2024
@ludamad
chore: test 4epochs in native-network (#9309)
ddb312a 
Reproduces #8855
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 23, 2024
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@just-mitch just-mitch

Labels
None yet
Projects
None yet
Milestone
Sequencer & Prover Testnet
Development

No branches or pull requests
2 participants
@just-mitch @aminsammara