Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle walltime properly #8325

Closed
Tracked by #7820
LHerskind opened this issue Sep 2, 2024 · 0 comments · Fixed by #8329
Closed
Tracked by #7820

feat: Handle walltime properly #8325

LHerskind opened this issue Sep 2, 2024 · 0 comments · Fixed by #8329
Assignees
@LHerskind
Milestone
Sequencer & Prove...

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 2, 2024 •
edited
Loading

We need to update the test using walltime to properly perform time jumps and not run the watcher. Also we should use salts to reduce the test times by speeding up the deployments.
@LHerskind LHerskind mentioned this issue Sep 2, 2024
Open
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 2, 2024
@LHerskind LHerskind mentioned this issue Sep 2, 2024
Open
@LHerskind LHerskind self-assigned this Sep 2, 2024
@LHerskind LHerskind added this to the Sequencer & Prover Testnet milestone Sep 2, 2024
@LHerskind LHerskind mentioned this issue Sep 2, 2024
Merged
LHerskind added a commit that referenced this issue Sep 3, 2024
@LHerskind
fix: address issues when using wall-time (#8329)
639fb3b 
Fixes #8325.

- Specifies a salt for `e2e_l1_with_wall_time` to speed up the test
- For `e2e_p2p` will set a salt and set a block time + update how the
validator set is specified. There seemed to be connection issues with
the initial sequencer, so found it useful to only use the new set.
Adding a transfer to self to ensure that we wait until the sets are
updated.
- Only start the `watcher` if we are not using walltime (e.g., when
`l1BlockTime` is not specified).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
Sequencer & Prover Testnet
Development

Successfully merging a pull request may close this issue.

fix: address issues when using wall-time AztecProtocol/aztec-packages
1 participant
@LHerskind