feat: adding aggregation to honk and rollup

[lucasxia01]

Closes AztecProtocol/barretenberg#1044.

Re-enables (most) aggregation code that was disabled in the Honk-rollup work. Adds a hack to the tube circuit that adds a default aggregation object, which will be fixed in a followup PR (probably #7582).

[AztecBot]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: 8a2a33e	Previous: 722df6a	Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20	5212.780299999991 ms/iter	4787.208167000017 ms/iter	1.09

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

[github-actions]

Changes to circuit sizes

Generated at commit: f8d505d9b33add049a06e8278de3847414668550, compared to commit: 840486e5ce6b41d6c873239de108b3731dd81101

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_empty	+48 ❌	+2.65%	+273 ❌	+0.03%
rollup_merge	+80 ❌	+2.96%	+496 ❌	+0.02%
rollup_root	+112 ❌	+2.74%	+720 ❌	+0.02%
parity_root	+144 ❌	+3.03%	+944 ❌	+0.02%
public_kernel_setup	+48 ❌	+0.03%	+256 ❌	+0.02%
public_kernel_teardown	+48 ❌	+0.02%	+256 ❌	+0.02%
rollup_base	+48 ❌	+0.01%	+256 ❌	+0.01%
public_kernel_tail	+42 ❌	+0.00%	+250 ❌	+0.01%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_empty	1,859 (+48)	+2.65%	1,042,094 (+273)	+0.03%
rollup_merge	2,782 (+80)	+2.96%	2,092,656 (+496)	+0.02%
rollup_root	4,193 (+112)	+2.74%	3,145,361 (+720)	+0.02%
parity_root	4,893 (+144)	+3.03%	4,172,738 (+944)	+0.02%
public_kernel_setup	183,243 (+48)	+0.03%	1,554,312 (+256)	+0.02%
public_kernel_teardown	241,778 (+48)	+0.02%	1,618,258 (+256)	+0.02%
rollup_base	341,394 (+48)	+0.01%	3,836,281 (+256)	+0.01%
public_kernel_tail	965,096 (+42)	+0.00%	4,645,098 (+250)	+0.01%

[codygunton]

In the past, to generate this file we had to manually cut out all of the public inputs from a proof generated through bb main. Now we cut out the non-aggregation object public inputs.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 4,023 (-17%)
• avm_simulation_time_ms (Token:transfer_public): 40.1 (+41%)
• avm_simulation_time_ms (Token:_increase_public_balance): 15.5 (-82%)
• protocol_circuit_witness_generation_time_in_ms (base-parity): 314 (-51%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,935 (+38%)
• protocol_circuit_num_public_inputs (base-parity): 19.0 (+533%)
• protocol_circuit_num_public_inputs (base-rollup): 44.0 (+57%)
• protocol_circuit_num_public_inputs (root-parity): 19.0 (+533%)
• protocol_circuit_num_public_inputs (root-rollup): 42.0 (+62%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,880 (+2%)	1,592 (+2%)	729 (+3%)	751	782 (+1%)
proof_construction_time_sha256_30_ms	12,307 (+4%)	3,276 (+3%)	1,487 (+5%)	1,487 (+3%)	1,514 (+2%)
proof_construction_time_sha256_100_ms	45,360 (+2%)	12,219 (+1%)	5,585 (+2%)	5,509 (+1%)	5,624 (+4%)
proof_construction_time_poseidon_hash_ms	80.0 (+3%)	35.0	36.0 (+6%)	60.0 (+3%)	90.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,557 (+2%)	424 (+1%)	202 (+1%)	228 (+3%)	272
proof_construction_time_poseidon_hash_100_ms	5,797 (+2%)	1,556 (+2%)	694 (+2%)	769 (+7%)	771 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,600	6,592	6,600
l1_rollup_execution_gas	583,062	583,205	583,364
l2_block_processing_time_in_ms	748 (-2%)	1,447 (+3%)	2,703
l2_block_building_time_in_ms	10,308	19,971	39,717 (+1%)
l2_block_rollup_simulation_time_in_ms	10,308	19,971	39,717 (+1%)
l2_block_public_tx_process_time_in_ms	8,588	18,071	37,763 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,080	10,242 (+3%)
node_database_size_in_bytes	12,726,352	16,904,272
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	93.8	405 (+9%)	21,744	54,085	N/A	N/A	N/A	N/A
private-kernel-inner	172 (+1%)	698 (+9%)	81,209	54,264	N/A	N/A	N/A	N/A
private-kernel-tail	370 (-12%)	869 (+7%)	61,565	62,127	N/A	N/A	N/A	N/A
base-parity	6.54 (+3%)	⚠️ 314 (-51%)	160	96.0	⚠️ 1,935 (+38%)	13,188 (+4%)	⚠️ 19.0 (+533%)	131,072
root-parity	111 (+5%)	113 (-7%)	66,908 (+3%)	96.0	28,021 (-8%)	13,188 (+4%)	⚠️ 19.0 (+533%)	4,194,304
base-rollup	3,252 (+1%)	5,082 (+6%)	181,595	632	40,752 (-6%)	13,988 (+4%)	⚠️ 44.0 (+57%)	4,194,304
root-rollup	156 (+3%)	111 (-9%)	52,797 (+3%)	652	25,661 (-7%)	13,924 (+4%)	⚠️ 42.0 (+62%)	4,194,304
public-kernel-setup	102 (+2%)	2,366 (+1%)	113,560	80,822	15,719 (-13%)	119,940	3,355	2,097,152
public-kernel-app-logic	106 (+1%)	3,265	113,560	80,822	8,961 (-11%)	119,940	3,355	1,048,576
public-kernel-tail	629 (+1%)	25,689 (-1%)	410,693	10,814	61,997 (-7%)	26,372 (+2%)	431 (+4%)	8,388,608
private-kernel-reset-tiny	232 (+4%)	942 (+9%)	77,005	53,954	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 4,023 (-17%)	1,393 (+7%)	773,216	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	91.7 (+2%)	3,369 (+3%)	113,560	80,822	16,211 (-15%)	119,940	3,355	2,097,152
merge-rollup	58.2 (+1%)	N/A	34,590 (+3%)	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	151,396 (-3%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	9,344	355 (+1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.4 (+3%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	567 (+2%)	N/A	N/A
GasToken:deploy	1,344	9,344	483 (+2%)	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	437 (+3%)	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	727 (+1%)	N/A	N/A
Token:privately_mint_private_note	1,248	9,344	531 (+7%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	105 (+8%)	N/A	N/A
Token:transfer	1,280	9,344	1,334 (+3%)	N/A	N/A
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	2,224 (+2%)
FPC:prepare_fee (avm)	22,670	N/A	N/A	95,456	2,358 (+7%)
Token:transfer_public (avm)	55,708	N/A	N/A	95,456	6,166
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,842 (+7%)
FPC:pay_refund (avm)	27,530	N/A	N/A	95,424	3,560
Benchmarking:create_note	1,312	9,344	419 (+2%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	42.2 (+3%)	N/A	N/A
Token:unshield	1,344	9,344	1,164 (+2%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,536 (+3%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	100 (+1%)	13,790
GasToken:set_portal	11.0 (-18%)	3,339
Token:constructor	125 (+2%)	23,692
FPC:constructor	105 (+13%)	13,592
GasToken:mint_public	83.3 (-1%)	10,158
Token:mint_public	269 (+10%)	19,034
Token:assert_minter_and_mint	87.1 (+4%)	12,925
AuthRegistry:set_authorized	46.6 (+6%)	7,812
FPC:prepare_fee	251 (-4%)	11,068
Token:transfer_public	⚠️ 40.1 (+41%)	44,012
FPC:pay_refund	79.9 (+12%)	15,961
Benchmarking:increment_balance	993 (+1%)	11,281
Token:_increase_public_balance	⚠️ 15.5 (-82%)	15,006
FPC:pay_refund_with_shielded_rebate	133 (+1%)	17,056

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.151 (-4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4 (+1%)	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.602 (+1%)	0.515	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4 (+1%)	75.8 (-1%)	130	248 (+1%)	467
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.494 (+1%)	0.466 (-1%)	0.448	0.449 (+1%)	0.436 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.1 (+1%)	111	182	363 (+3%)	690
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.508 (+1%)	0.500 (+1%)	0.477 (-1%)	0.491 (+3%)	0.474 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.6 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.523 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	77,362	668,542

Transaction size based on fee payment method

| Metric | |
| - | |