chore(aztec-macros): avm function return types are auto tagged as pub
#6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types auto-tagged as
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
changed the title
pubpub
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
dbanks12
requested review from
fcarreiro,
sirasistant and
Thunkar
and removed request for
fcarreiro
fcarreiro
approved these changes
May 7, 2024
| @@ -103,6 +103,8 @@ pub fn transform_function( | |||
| let return_type = create_return_type(&return_type_name); | |||
| func.def.return_type = return_type; | |||
| func.def.return_visibility = Visibility::Public; | |||
| } else { | |||
There was a problem hiding this comment.
Consider just doing it outside of the if, since both branches do it.
Thunkar
approved these changes
May 7, 2024
This was referenced May 7, 2024
TomAFrench
added a commit
that referenced
this pull request
May 8, 2024
* master: (25 commits) fix: Enable client proof tests (#6249) chore: update cspell for abi demonomorphizer (#6258) feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Pw/update merge check (#6201) chore(master): Release 0.37.1 (#6148) fix: Cl/split out e2e tests (#6242) feat: Typings generator with generics (#6235) chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226) chore: misc AVM migration prep changes (#6253) feat!: AES blackbox (#6016) chore(docs): Fix some typos in specs of private kernel initial (#6224) chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250) chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248) fix: registering PublicDataWitness in JsonRpcServer (#6243) feat: Sync from noir (#6234) feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188) ...
TomAFrench
added a commit
to noir-lang/noir
that referenced
this pull request
May 8, 2024
Automated pull of Noir development from [aztec-packages](https://github.com/AztecProtocol/aztec-packages). BEGIN_COMMIT_OVERRIDE feat!: AES blackbox (AztecProtocol/aztec-packages#6016) chore(aztec-macros): avm function return types are auto tagged as `pub` (AztecProtocol/aztec-packages#6250) refactor: nuking `GrumpkinScalar` (AztecProtocol/aztec-packages#6240) feat: `multi_scalar_mul` blackbox func (AztecProtocol/aztec-packages#6097) feat: Set aztec private functions to be recursive (AztecProtocol/aztec-packages#6192) feat: Parsing non-string assertion payloads in noir js (AztecProtocol/aztec-packages#6079) feat: `variable_base_scalar_mul` blackbox func (AztecProtocol/aztec-packages#6039) feat: Dynamic assertion payloads v2 (AztecProtocol/aztec-packages#5949) chore!: remove `Opcode::Brillig` from ACIR (AztecProtocol/aztec-packages#5995) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.