Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wire AVM gas used to public kernel #5740

Merged
merged 14 commits into from
Apr 16, 2024
Merged

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Apr 12, 2024

Starts wiring gas settings and usage across application and kernel circuits, tracking L2 gas used in the AVM first. This required the following changes to structs:

  • PublicCircuitPublicInputs now includes a gas_left to report how much was left at the end of their execution, as a means to report how much was used.
  • CallContext now includes a gas_left to inform the app circuit (private or public) how much gas it has available for execution.
  • TxRequest and TxExecutionRequest include a GasSettings so the user can specify their gas limits and max fees when creating a new tx.

Other changes:

  • Renamed GasUsed struct to just Gas since it's used for tracking gas used and for tracking gas left depending on the context.
  • FeePaymentMethod.getFunctionCalls now accepts a GasSettings instead of a flat MaxFee, though the max fee can be calculated from the gas settings.

@spalladino spalladino force-pushed the palla/wire-avm-gas-used branch 2 times, most recently from d2fef12 to fa4f88a Compare April 12, 2024 21:51
Comment on lines 172 to 228
pub fn update_revertible_gas_used(public_call: PublicCallData, circuit_outputs: &mut PublicKernelCircuitPublicInputsBuilder) {
circuit_outputs.end.gas_used = circuit_outputs.constants.gas_settings.get_gas_limits()
.sub(public_call.call_stack_item.public_inputs.gas_left)
.sub(circuit_outputs.end_non_revertible.gas_used);
}

pub fn update_non_revertible_gas_used(public_call: PublicCallData, circuit_outputs: &mut PublicKernelCircuitPublicInputsBuilder) {
circuit_outputs.end_non_revertible.gas_used = circuit_outputs.constants.gas_settings.get_gas_limits()
.sub(public_call.call_stack_item.public_inputs.gas_left)
.sub(circuit_outputs.end.gas_used);
}
Copy link
Collaborator Author

@spalladino spalladino Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only bit of actual logic across this entire PR 😢
(and needs unit tests!)

@spalladino spalladino force-pushed the palla/wire-avm-gas-used branch 5 times, most recently from 58870ac to d2a55a2 Compare April 15, 2024 16:54
@spalladino spalladino marked this pull request as ready for review April 15, 2024 17:18
@spalladino spalladino marked this pull request as draft April 15, 2024 17:18
@spalladino spalladino marked this pull request as ready for review April 15, 2024 21:22
@spalladino spalladino enabled auto-merge (squash) April 15, 2024 21:29
@spalladino spalladino requested review from LeilaWang and just-mitch and removed request for Maddiaa0 April 15, 2024 21:29
@AztecBot
Copy link
Collaborator

AztecBot commented Apr 15, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://661e67b803674400a8207de8--aztec-docs-dev.netlify.app

Copy link
Contributor

@just-mitch just-mitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me.

@@ -24,7 +24,7 @@ export class CombinedConstantData {
public txContext: TxContext,

/** Gas limits and max prices for this transaction as set by the sender. */
public readonly gasSettings: GasSettings,
public gasSettings: GasSettings,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We could keep this as readonly if we had a PrivateKernelTailCircuitPublicInputs.default() method right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly for testing purposes, but yeah, we should strive to make everything readonly. Still, every other field here isn't, so...

yarn-project/end-to-end/src/e2e_dapp_subscription.test.ts Outdated Show resolved Hide resolved
@spalladino spalladino merged commit 4f55d10 into master Apr 16, 2024
49 checks passed
@spalladino spalladino deleted the palla/wire-avm-gas-used branch April 16, 2024 12:05
TomAFrench added a commit that referenced this pull request Apr 16, 2024
* master:
  feat: Wire AVM gas used to public kernel (#5740)
  fix(ci,noir-projects): bring apt-get higher in cache (#5775)
  fix: e2e getStack, disable failing e2e (#5768)
  feat: Changing finite field arithmetic in wasm to 29 bits for multiplications (#5435)
  feat!: trap with revert data (#5732)
  feat: impl of missing functionality in new key store (#5750)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix(ci): 192 core spot runner (#5767)
  feat(acir)!: BrilligCall opcode  (#5709)
  fix(ci): speculative deploy fix
  fix(ci): don't fail if can't prune
  feat(ci): turn on new CI as mandatory (#5761)
rahul-kothari pushed a commit that referenced this pull request Apr 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.35.0</summary>

##
[0.35.0](aztec-package-v0.34.0...aztec-package-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* pay fee for account init
([#5601](#5601))

### Features

* Pay fee for account init
([#5601](#5601))
([aca804f](aca804f))
</details>

<details><summary>barretenberg.js: 0.35.0</summary>

##
[0.35.0](barretenberg.js-v0.34.0...barretenberg.js-v0.35.0)
(2024-04-16)


### Features

* Export poseidon2_permutation and add to foundation/crypto
([#5706](#5706))
([6b91e27](6b91e27))


### Miscellaneous

* Don't strip bb wasm
([#5743](#5743))
([d4cb410](d4cb410))
* TS hash wrappers cleanup
([#5691](#5691))
([7f8b09f](7f8b09f))
</details>

<details><summary>aztec-cli: 0.35.0</summary>

##
[0.35.0](aztec-cli-v0.34.0...aztec-cli-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* pay fee for account init
([#5601](#5601))

### Features

* Pay fee for account init
([#5601](#5601))
([aca804f](aca804f))
</details>

<details><summary>aztec-packages: 0.35.0</summary>

##
[0.35.0](aztec-packages-v0.34.0...aztec-packages-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* Use fixed size arrays in black box functions where sizes are known
([#5620](#5620))
* trap with revert data
([#5732](#5732))
* **acir:** BrilligCall opcode
([#5709](#5709))
* rename request_max_block_number
([#5675](#5675))
* pay fee for account init
([#5601](#5601))

### Features

* **acir:** BrilligCall opcode
([#5709](#5709))
([f06f64c](f06f64c))
* Add serialisation methods
([#5749](#5749))
([20d290c](20d290c))
* App siloing in new key store
([#5721](#5721))
([ae37d32](ae37d32)),
closes
[#5635](#5635)
* **avm-simulator:** Plumb noir assertion messages
([#5774](#5774))
([2cf11ac](2cf11ac))
* **avm:** CMOV opcode
([#5575](#5575))
([19dbe46](19dbe46)),
closes
[#5557](#5557)
* **avm:** Enable contract testing with bb binary
([#5584](#5584))
([d007d79](d007d79))
* **avm:** Enable range check on the ALU registers
([#5696](#5696))
([202fc1b](202fc1b))
* **avm:** Keccak as blackbox function
([#5722](#5722))
([6ea677a](6ea677a))
* **avm:** Poseidon2_permutation as black box
([#5707](#5707))
([5526b36](5526b36))
* **avm:** Sha256 as blackbox function
([#5727](#5727))
([cac9cba](cac9cba))
* **avm:** Take sizeOffset in CALL
([#5763](#5763))
([95eadd6](95eadd6))
* Brillig heterogeneous memory cells
([#5608](#5608))
([3287aa2](3287aa2))
* Change public nullifiers api
([#5660](#5660))
([986e7f9](986e7f9))
* Changing finite field arithmetic in wasm to 29 bits for
multiplications
([#5435](#5435))
([b2d9b9d](b2d9b9d))
* **ci:** Turn on new CI as mandatory
([#5761](#5761))
([bebed32](bebed32))
* **docs:** Merge yellow paper into docs protocol specs section
([#5668](#5668))
([66dc509](66dc509))
* E2e token contract can run in 2m with snapshots and test separation.
([#5526](#5526))
([b0037dd](b0037dd))
* Export poseidon2_permutation and add to foundation/crypto
([#5706](#5706))
([6b91e27](6b91e27))
* Get last mock oracles params
(noir-lang/noir#4789)
([825c455](825c455))
* Impl of missing functionality in new key store
([#5750](#5750))
([af49a29](af49a29))
* LT/LTE for AVM
([#5559](#5559))
([350abeb](350abeb))
* New key store
([#5653](#5653))
([3e44a58](3e44a58)),
closes
[#5607](#5607)
* Pay fee for account init
([#5601](#5601))
([aca804f](aca804f))
* Poseidon separator
([#5717](#5717))
([d5256d2](d5256d2))
* Proving the rollup circuits
([#5599](#5599))
([145cbcd](145cbcd))
* Public Kernel proving orchestration
([#5748](#5748))
([2ae0ee5](2ae0ee5))
* Rename request_max_block_number
([#5675](#5675))
([c695fcd](c695fcd))
* Separate nullfier_inclusion checks for private/public/avm
([#5657](#5657))
([e4d2df6](e4d2df6))
* Sequencer validates setup/teardown function selectors
([#5649](#5649))
([8f8ad56](8f8ad56)),
closes
[#5401](#5401)
* Shared mutable storage
([#5490](#5490))
([c4e41a9](c4e41a9))
* **simulator:** Fetch return values at circuit execution
([#5642](#5642))
([413a4e0](413a4e0))
* Split `backend_barretenburg` into prover and verifier classes
(noir-lang/noir#4769)
([825c455](825c455))
* Sync from aztec-packages (noir-lang/noir#4764)
([1eb288e](1eb288e))
* Sync from aztec-packages (noir-lang/noir#4787)
([825c455](825c455))
* Trap with revert data
([#5732](#5732))
([f849575](f849575))
* Unroll loops iteratively (noir-lang/noir#4779)
([1eb288e](1eb288e))
* Update circuits structs with gas info
([#5677](#5677))
([3db6dd1](3db6dd1))
* Use fixed size arrays in black box functions where sizes are known
([#5620](#5620))
([f50b180](f50b180))
* Variable length returns
([#5633](#5633))
([b4a6f17](b4a6f17))
* Wire AVM gas used to public kernel
([#5740](#5740))
([4f55d10](4f55d10))


### Bug Fixes

* "feat: Changing finite field arithmetic in wasm to 29 bits for
multiplications"
([#5779](#5779))
([bcfee97](bcfee97))
* Anvil start retry in case something bad. Fix colors.
([#5673](#5673))
([0b6b6f6](0b6b6f6))
* ArrayGet and Set are not pure
(noir-lang/noir#4783)
([825c455](825c455))
* Avoid get row in databus
([#5742](#5742))
([d67b6c8](d67b6c8))
* Avoid huge unrolling in hash_args
([#5703](#5703))
([10d9ad9](10d9ad9))
* **ci,noir-projects:** Bring apt-get higher in cache
([#5775](#5775))
([d37cbb9](d37cbb9))
* **ci:** 192 core spot runner
([#5767](#5767))
([37daac6](37daac6))
* **ci:** Bigger cache disk, cache+prune docker images, disable
ClientIvcTests.Full
([#5729](#5729))
([5dcbd75](5dcbd75))
* **ci:** Builder types
([#5711](#5711))
([b16f169](b16f169))
* **ci:** Cache size not honoured
([#5738](#5738))
([d4ff340](d4ff340))
* **ci:** Don't fail if can't prune
([d9bb2c7](d9bb2c7))
* **ci:** Error in spot
([#5745](#5745))
([4d754aa](4d754aa))
* **ci:** Fix arm e2e references, spot shutdown
([#5741](#5741))
([1c4667c](1c4667c))
* **ci:** Hotfix arm
([1ddb1c7](1ddb1c7))
* **ci:** Hotfix just one ARM task
([10f27ae](10f27ae))
* **ci:** Speculative deploy fix
([9a9eab6](9a9eab6))
* **ci:** Wait for mainnet fork deployment
([#5735](#5735))
([8f3794d](8f3794d))
* **ci:** Wait_for_fork env var
([#5780](#5780))
([d85267b](d85267b))
* Correct ICE panic messages in brillig `convert_black_box_call`
(noir-lang/noir#4761)
([1eb288e](1eb288e))
* Disable flakey vanilla recursion test
([#5672](#5672))
([f84f7b6](f84f7b6))
* Don't run e2e tests against wrong anvil
([#5686](#5686))
([9ff45f6](9ff45f6))
* Dont error in bench summary
([#5693](#5693))
([470b0f3](470b0f3))
* E2e getStack, disable failing e2e
([#5768](#5768))
([e5f3ece](e5f3ece))
* GA concurrency
([#5713](#5713))
([eac2585](eac2585))
* Generate_aztecnr_reference.js not getting generics or multi-line
params
([#5679](#5679))
([a22bc3d](a22bc3d))
* Hotfix submodule cache
([92b92b3](92b92b3))
* Hotfix underspec'd machine
([#5710](#5710))
([059e38e](059e38e))
* **hotfix:** CI ignore git safe.directory checks
([#5659](#5659))
([9fc3fe3](9fc3fe3))
* Less earthly cache
([#5690](#5690))
([8190dc7](8190dc7))
* Make earthly more parallel
([#5747](#5747))
([9734455](9734455))
* Primary_message typo in errors.rs
([#5646](#5646))
([1dfbe7b](1dfbe7b))
* Pull noir
([#5699](#5699))
([bf35464](bf35464))
* REDO dont error in bench summary
([#5695](#5695))
([8c1a7b9](8c1a7b9))
* Running e2e tests as part of build, requires forcing ip4 (not ip6)
when connecting to anvil
([#5744](#5744))
([66fc89f](66fc89f))
* Simplify ECCVM prover constructor and add a TODO
([#5681](#5681))
([8c151ea](8c151ea))
* Spot refcount
([#5746](#5746))
([9e18444](9e18444))
* Take a deep copy of circuit inputs for proving
([#5777](#5777))
([785591e](785591e))
* Temporarily disable the bench tests
([#5755](#5755))
([1d52ac5](1d52ac5))
* Update commit for noir-gates-diff
(noir-lang/noir#4773)
([1eb288e](1eb288e))
* Use entrypoint instead of pay_init_fee
([#5623](#5623))
([62ac765](62ac765))
* Watch less files.
([#5651](#5651))
([57a1d69](57a1d69))


### Miscellaneous

* Add missing aztec-address tests
([#5674](#5674))
([58aefba](58aefba))
* **avm:** Add a boolean to toggle proving in AVM unit tests
([#5667](#5667))
([ec122c9](ec122c9)),
closes
[#5663](#5663)
* **avm:** Hashing tests cleanup
([#5733](#5733))
([53d0102](53d0102))
* **avm:** Range checks negative tests
([#5770](#5770))
([2907142](2907142))
* **avm:** Split the negative test on range check for high 16-bit
registers
([#5785](#5785))
([8ebbe57](8ebbe57))
* **avm:** Split up AVM test contract as it was growing too large
([#5702](#5702))
([5b8e812](5b8e812))
* **aztec-nr:** Minor public interface changes
([#5776](#5776))
([91b8110](91b8110))
* **ci:** Break e2e-deploy into multiple test suites
([#5704](#5704))
([2522294](2522294))
* **ci:** Earthly in spot with persistent cache
([#5644](#5644))
([a39c2f6](a39c2f6))
* **ci:** Hotfix AMI's, workflow to stop personal spot runners
([#5712](#5712))
([5f18139](5f18139))
* **ci:** Only run ARM on master
([#5705](#5705))
([f77c142](f77c142))
* **ci:** Use 128 cores for x86 and add timeouts
([#5665](#5665))
([0c5dc0a](0c5dc0a))
* Compute_note_hash_and_nullifier - improve error message
([#5671](#5671))
([8942d69](8942d69))
* Create placeholder version of 0.26.0 docs
(noir-lang/noir#4782)
([1eb288e](1eb288e))
* **doc:** Fix broken docs links
(noir-lang/noir#4606)
([1eb288e](1eb288e))
* **docs:** Fix link in the Data Types page
(noir-lang/noir#4527)
([1eb288e](1eb288e))
* Don't strip bb wasm
([#5743](#5743))
([d4cb410](d4cb410))
* Fix master after merge issue related to validate_trace renaming
([#5676](#5676))
([44e0d8a](44e0d8a))
* Fix max-block-number and auth e2e tests
([#5694](#5694))
([f1bf314](f1bf314))
* Op queue
([#5648](#5648))
([822c7e6](822c7e6))
* **public:** Remove getNullifierMembershipWitness
([#5715](#5715))
([3be402c](3be402c))
* Re-enable e2e fees tests
([#5784](#5784))
([102e8b8](102e8b8))
* Release Noir(0.27.0) (noir-lang/noir#4632)
([1eb288e](1eb288e))
* Remove the old Value struct from the oracle docs
(noir-lang/noir#4738)
([1eb288e](1eb288e))
* Replace relative paths to noir-protocol-circuits
([fb2b298](fb2b298))
* Replace relative paths to noir-protocol-circuits
([e20920d](e20920d))
* Replace relative paths to noir-protocol-circuits
([6351dc5](6351dc5))
* Replace relative paths to noir-protocol-circuits
([fee13bf](fee13bf))
* Replacing unsafe::zeroed()
([#5685](#5685))
([ea3884e](ea3884e))
* Small logging changes
([#5654](#5654))
([25cc70d](25cc70d))
* Temporarily skip failing e2e fees test
([a3ac5ff](a3ac5ff))
* Testing that nargo fmt is idempotent
(noir-lang/noir#4765)
([825c455](825c455))
* TS hash wrappers cleanup
([#5691](#5691))
([7f8b09f](7f8b09f))
* Turn ENABLE_GAS where it is needed
([#5730](#5730))
([30a2edd](30a2edd))
* Update noir gates diff
([#5658](#5658))
([9816c1a](9816c1a))
* We can run 35 of our e2e tests just using jest.
([#5643](#5643))
([4fcaeae](4fcaeae))


### Documentation

* Fix yp typo control-flow.md
([#5638](#5638))
([363d227](363d227))
</details>

<details><summary>barretenberg: 0.35.0</summary>

##
[0.35.0](barretenberg-v0.34.0...barretenberg-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* Use fixed size arrays in black box functions where sizes are known
([#5620](#5620))
* trap with revert data
([#5732](#5732))
* **acir:** BrilligCall opcode
([#5709](#5709))

### Features

* **acir:** BrilligCall opcode
([#5709](#5709))
([f06f64c](f06f64c))
* **avm:** CMOV opcode
([#5575](#5575))
([19dbe46](19dbe46)),
closes
[#5557](#5557)
* **avm:** Enable contract testing with bb binary
([#5584](#5584))
([d007d79](d007d79))
* **avm:** Enable range check on the ALU registers
([#5696](#5696))
([202fc1b](202fc1b))
* Changing finite field arithmetic in wasm to 29 bits for
multiplications
([#5435](#5435))
([b2d9b9d](b2d9b9d))
* **ci:** Turn on new CI as mandatory
([#5761](#5761))
([bebed32](bebed32))
* Export poseidon2_permutation and add to foundation/crypto
([#5706](#5706))
([6b91e27](6b91e27))
* LT/LTE for AVM
([#5559](#5559))
([350abeb](350abeb))
* Trap with revert data
([#5732](#5732))
([f849575](f849575))
* Use fixed size arrays in black box functions where sizes are known
([#5620](#5620))
([f50b180](f50b180))


### Bug Fixes

* "feat: Changing finite field arithmetic in wasm to 29 bits for
multiplications"
([#5779](#5779))
([bcfee97](bcfee97))
* Avoid get row in databus
([#5742](#5742))
([d67b6c8](d67b6c8))
* **ci:** Bigger cache disk, cache+prune docker images, disable
ClientIvcTests.Full
([#5729](#5729))
([5dcbd75](5dcbd75))
* Disable flakey vanilla recursion test
([#5672](#5672))
([f84f7b6](f84f7b6))
* Less earthly cache
([#5690](#5690))
([8190dc7](8190dc7))
* Make earthly more parallel
([#5747](#5747))
([9734455](9734455))
* Simplify ECCVM prover constructor and add a TODO
([#5681](#5681))
([8c151ea](8c151ea))


### Miscellaneous

* **avm:** Add a boolean to toggle proving in AVM unit tests
([#5667](#5667))
([ec122c9](ec122c9)),
closes
[#5663](#5663)
* **avm:** Range checks negative tests
([#5770](#5770))
([2907142](2907142))
* **avm:** Split the negative test on range check for high 16-bit
registers
([#5785](#5785))
([8ebbe57](8ebbe57))
* **ci:** Use 128 cores for x86 and add timeouts
([#5665](#5665))
([0c5dc0a](0c5dc0a))
* Don't strip bb wasm
([#5743](#5743))
([d4cb410](d4cb410))
* Fix master after merge issue related to validate_trace renaming
([#5676](#5676))
([44e0d8a](44e0d8a))
* Op queue
([#5648](#5648))
([822c7e6](822c7e6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Apr 17, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.35.0</summary>

##
[0.35.0](AztecProtocol/aztec-packages@aztec-package-v0.34.0...aztec-package-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* pay fee for account init
([#5601](AztecProtocol/aztec-packages#5601))

### Features

* Pay fee for account init
([#5601](AztecProtocol/aztec-packages#5601))
([aca804f](AztecProtocol/aztec-packages@aca804f))
</details>

<details><summary>barretenberg.js: 0.35.0</summary>

##
[0.35.0](AztecProtocol/aztec-packages@barretenberg.js-v0.34.0...barretenberg.js-v0.35.0)
(2024-04-16)


### Features

* Export poseidon2_permutation and add to foundation/crypto
([#5706](AztecProtocol/aztec-packages#5706))
([6b91e27](AztecProtocol/aztec-packages@6b91e27))


### Miscellaneous

* Don't strip bb wasm
([#5743](AztecProtocol/aztec-packages#5743))
([d4cb410](AztecProtocol/aztec-packages@d4cb410))
* TS hash wrappers cleanup
([#5691](AztecProtocol/aztec-packages#5691))
([7f8b09f](AztecProtocol/aztec-packages@7f8b09f))
</details>

<details><summary>aztec-cli: 0.35.0</summary>

##
[0.35.0](AztecProtocol/aztec-packages@aztec-cli-v0.34.0...aztec-cli-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* pay fee for account init
([#5601](AztecProtocol/aztec-packages#5601))

### Features

* Pay fee for account init
([#5601](AztecProtocol/aztec-packages#5601))
([aca804f](AztecProtocol/aztec-packages@aca804f))
</details>

<details><summary>aztec-packages: 0.35.0</summary>

##
[0.35.0](AztecProtocol/aztec-packages@aztec-packages-v0.34.0...aztec-packages-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* Use fixed size arrays in black box functions where sizes are known
([#5620](AztecProtocol/aztec-packages#5620))
* trap with revert data
([#5732](AztecProtocol/aztec-packages#5732))
* **acir:** BrilligCall opcode
([#5709](AztecProtocol/aztec-packages#5709))
* rename request_max_block_number
([#5675](AztecProtocol/aztec-packages#5675))
* pay fee for account init
([#5601](AztecProtocol/aztec-packages#5601))

### Features

* **acir:** BrilligCall opcode
([#5709](AztecProtocol/aztec-packages#5709))
([f06f64c](AztecProtocol/aztec-packages@f06f64c))
* Add serialisation methods
([#5749](AztecProtocol/aztec-packages#5749))
([20d290c](AztecProtocol/aztec-packages@20d290c))
* App siloing in new key store
([#5721](AztecProtocol/aztec-packages#5721))
([ae37d32](AztecProtocol/aztec-packages@ae37d32)),
closes
[#5635](AztecProtocol/aztec-packages#5635)
* **avm-simulator:** Plumb noir assertion messages
([#5774](AztecProtocol/aztec-packages#5774))
([2cf11ac](AztecProtocol/aztec-packages@2cf11ac))
* **avm:** CMOV opcode
([#5575](AztecProtocol/aztec-packages#5575))
([19dbe46](AztecProtocol/aztec-packages@19dbe46)),
closes
[#5557](AztecProtocol/aztec-packages#5557)
* **avm:** Enable contract testing with bb binary
([#5584](AztecProtocol/aztec-packages#5584))
([d007d79](AztecProtocol/aztec-packages@d007d79))
* **avm:** Enable range check on the ALU registers
([#5696](AztecProtocol/aztec-packages#5696))
([202fc1b](AztecProtocol/aztec-packages@202fc1b))
* **avm:** Keccak as blackbox function
([#5722](AztecProtocol/aztec-packages#5722))
([6ea677a](AztecProtocol/aztec-packages@6ea677a))
* **avm:** Poseidon2_permutation as black box
([#5707](AztecProtocol/aztec-packages#5707))
([5526b36](AztecProtocol/aztec-packages@5526b36))
* **avm:** Sha256 as blackbox function
([#5727](AztecProtocol/aztec-packages#5727))
([cac9cba](AztecProtocol/aztec-packages@cac9cba))
* **avm:** Take sizeOffset in CALL
([#5763](AztecProtocol/aztec-packages#5763))
([95eadd6](AztecProtocol/aztec-packages@95eadd6))
* Brillig heterogeneous memory cells
([#5608](AztecProtocol/aztec-packages#5608))
([3287aa2](AztecProtocol/aztec-packages@3287aa2))
* Change public nullifiers api
([#5660](AztecProtocol/aztec-packages#5660))
([986e7f9](AztecProtocol/aztec-packages@986e7f9))
* Changing finite field arithmetic in wasm to 29 bits for
multiplications
([#5435](AztecProtocol/aztec-packages#5435))
([b2d9b9d](AztecProtocol/aztec-packages@b2d9b9d))
* **ci:** Turn on new CI as mandatory
([#5761](AztecProtocol/aztec-packages#5761))
([bebed32](AztecProtocol/aztec-packages@bebed32))
* **docs:** Merge yellow paper into docs protocol specs section
([#5668](AztecProtocol/aztec-packages#5668))
([66dc509](AztecProtocol/aztec-packages@66dc509))
* E2e token contract can run in 2m with snapshots and test separation.
([#5526](AztecProtocol/aztec-packages#5526))
([b0037dd](AztecProtocol/aztec-packages@b0037dd))
* Export poseidon2_permutation and add to foundation/crypto
([#5706](AztecProtocol/aztec-packages#5706))
([6b91e27](AztecProtocol/aztec-packages@6b91e27))
* Get last mock oracles params
(noir-lang/noir#4789)
([825c455](AztecProtocol/aztec-packages@825c455))
* Impl of missing functionality in new key store
([#5750](AztecProtocol/aztec-packages#5750))
([af49a29](AztecProtocol/aztec-packages@af49a29))
* LT/LTE for AVM
([#5559](AztecProtocol/aztec-packages#5559))
([350abeb](AztecProtocol/aztec-packages@350abeb))
* New key store
([#5653](AztecProtocol/aztec-packages#5653))
([3e44a58](AztecProtocol/aztec-packages@3e44a58)),
closes
[#5607](AztecProtocol/aztec-packages#5607)
* Pay fee for account init
([#5601](AztecProtocol/aztec-packages#5601))
([aca804f](AztecProtocol/aztec-packages@aca804f))
* Poseidon separator
([#5717](AztecProtocol/aztec-packages#5717))
([d5256d2](AztecProtocol/aztec-packages@d5256d2))
* Proving the rollup circuits
([#5599](AztecProtocol/aztec-packages#5599))
([145cbcd](AztecProtocol/aztec-packages@145cbcd))
* Public Kernel proving orchestration
([#5748](AztecProtocol/aztec-packages#5748))
([2ae0ee5](AztecProtocol/aztec-packages@2ae0ee5))
* Rename request_max_block_number
([#5675](AztecProtocol/aztec-packages#5675))
([c695fcd](AztecProtocol/aztec-packages@c695fcd))
* Separate nullfier_inclusion checks for private/public/avm
([#5657](AztecProtocol/aztec-packages#5657))
([e4d2df6](AztecProtocol/aztec-packages@e4d2df6))
* Sequencer validates setup/teardown function selectors
([#5649](AztecProtocol/aztec-packages#5649))
([8f8ad56](AztecProtocol/aztec-packages@8f8ad56)),
closes
[#5401](AztecProtocol/aztec-packages#5401)
* Shared mutable storage
([#5490](AztecProtocol/aztec-packages#5490))
([c4e41a9](AztecProtocol/aztec-packages@c4e41a9))
* **simulator:** Fetch return values at circuit execution
([#5642](AztecProtocol/aztec-packages#5642))
([413a4e0](AztecProtocol/aztec-packages@413a4e0))
* Split `backend_barretenburg` into prover and verifier classes
(noir-lang/noir#4769)
([825c455](AztecProtocol/aztec-packages@825c455))
* Sync from aztec-packages (noir-lang/noir#4764)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Sync from aztec-packages (noir-lang/noir#4787)
([825c455](AztecProtocol/aztec-packages@825c455))
* Trap with revert data
([#5732](AztecProtocol/aztec-packages#5732))
([f849575](AztecProtocol/aztec-packages@f849575))
* Unroll loops iteratively (noir-lang/noir#4779)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Update circuits structs with gas info
([#5677](AztecProtocol/aztec-packages#5677))
([3db6dd1](AztecProtocol/aztec-packages@3db6dd1))
* Use fixed size arrays in black box functions where sizes are known
([#5620](AztecProtocol/aztec-packages#5620))
([f50b180](AztecProtocol/aztec-packages@f50b180))
* Variable length returns
([#5633](AztecProtocol/aztec-packages#5633))
([b4a6f17](AztecProtocol/aztec-packages@b4a6f17))
* Wire AVM gas used to public kernel
([#5740](AztecProtocol/aztec-packages#5740))
([4f55d10](AztecProtocol/aztec-packages@4f55d10))


### Bug Fixes

* "feat: Changing finite field arithmetic in wasm to 29 bits for
multiplications"
([#5779](AztecProtocol/aztec-packages#5779))
([bcfee97](AztecProtocol/aztec-packages@bcfee97))
* Anvil start retry in case something bad. Fix colors.
([#5673](AztecProtocol/aztec-packages#5673))
([0b6b6f6](AztecProtocol/aztec-packages@0b6b6f6))
* ArrayGet and Set are not pure
(noir-lang/noir#4783)
([825c455](AztecProtocol/aztec-packages@825c455))
* Avoid get row in databus
([#5742](AztecProtocol/aztec-packages#5742))
([d67b6c8](AztecProtocol/aztec-packages@d67b6c8))
* Avoid huge unrolling in hash_args
([#5703](AztecProtocol/aztec-packages#5703))
([10d9ad9](AztecProtocol/aztec-packages@10d9ad9))
* **ci,noir-projects:** Bring apt-get higher in cache
([#5775](AztecProtocol/aztec-packages#5775))
([d37cbb9](AztecProtocol/aztec-packages@d37cbb9))
* **ci:** 192 core spot runner
([#5767](AztecProtocol/aztec-packages#5767))
([37daac6](AztecProtocol/aztec-packages@37daac6))
* **ci:** Bigger cache disk, cache+prune docker images, disable
ClientIvcTests.Full
([#5729](AztecProtocol/aztec-packages#5729))
([5dcbd75](AztecProtocol/aztec-packages@5dcbd75))
* **ci:** Builder types
([#5711](AztecProtocol/aztec-packages#5711))
([b16f169](AztecProtocol/aztec-packages@b16f169))
* **ci:** Cache size not honoured
([#5738](AztecProtocol/aztec-packages#5738))
([d4ff340](AztecProtocol/aztec-packages@d4ff340))
* **ci:** Don't fail if can't prune
([d9bb2c7](AztecProtocol/aztec-packages@d9bb2c7))
* **ci:** Error in spot
([#5745](AztecProtocol/aztec-packages#5745))
([4d754aa](AztecProtocol/aztec-packages@4d754aa))
* **ci:** Fix arm e2e references, spot shutdown
([#5741](AztecProtocol/aztec-packages#5741))
([1c4667c](AztecProtocol/aztec-packages@1c4667c))
* **ci:** Hotfix arm
([1ddb1c7](AztecProtocol/aztec-packages@1ddb1c7))
* **ci:** Hotfix just one ARM task
([10f27ae](AztecProtocol/aztec-packages@10f27ae))
* **ci:** Speculative deploy fix
([9a9eab6](AztecProtocol/aztec-packages@9a9eab6))
* **ci:** Wait for mainnet fork deployment
([#5735](AztecProtocol/aztec-packages#5735))
([8f3794d](AztecProtocol/aztec-packages@8f3794d))
* **ci:** Wait_for_fork env var
([#5780](AztecProtocol/aztec-packages#5780))
([d85267b](AztecProtocol/aztec-packages@d85267b))
* Correct ICE panic messages in brillig `convert_black_box_call`
(noir-lang/noir#4761)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Disable flakey vanilla recursion test
([#5672](AztecProtocol/aztec-packages#5672))
([f84f7b6](AztecProtocol/aztec-packages@f84f7b6))
* Don't run e2e tests against wrong anvil
([#5686](AztecProtocol/aztec-packages#5686))
([9ff45f6](AztecProtocol/aztec-packages@9ff45f6))
* Dont error in bench summary
([#5693](AztecProtocol/aztec-packages#5693))
([470b0f3](AztecProtocol/aztec-packages@470b0f3))
* E2e getStack, disable failing e2e
([#5768](AztecProtocol/aztec-packages#5768))
([e5f3ece](AztecProtocol/aztec-packages@e5f3ece))
* GA concurrency
([#5713](AztecProtocol/aztec-packages#5713))
([eac2585](AztecProtocol/aztec-packages@eac2585))
* Generate_aztecnr_reference.js not getting generics or multi-line
params
([#5679](AztecProtocol/aztec-packages#5679))
([a22bc3d](AztecProtocol/aztec-packages@a22bc3d))
* Hotfix submodule cache
([92b92b3](AztecProtocol/aztec-packages@92b92b3))
* Hotfix underspec'd machine
([#5710](AztecProtocol/aztec-packages#5710))
([059e38e](AztecProtocol/aztec-packages@059e38e))
* **hotfix:** CI ignore git safe.directory checks
([#5659](AztecProtocol/aztec-packages#5659))
([9fc3fe3](AztecProtocol/aztec-packages@9fc3fe3))
* Less earthly cache
([#5690](AztecProtocol/aztec-packages#5690))
([8190dc7](AztecProtocol/aztec-packages@8190dc7))
* Make earthly more parallel
([#5747](AztecProtocol/aztec-packages#5747))
([9734455](AztecProtocol/aztec-packages@9734455))
* Primary_message typo in errors.rs
([#5646](AztecProtocol/aztec-packages#5646))
([1dfbe7b](AztecProtocol/aztec-packages@1dfbe7b))
* Pull noir
([#5699](AztecProtocol/aztec-packages#5699))
([bf35464](AztecProtocol/aztec-packages@bf35464))
* REDO dont error in bench summary
([#5695](AztecProtocol/aztec-packages#5695))
([8c1a7b9](AztecProtocol/aztec-packages@8c1a7b9))
* Running e2e tests as part of build, requires forcing ip4 (not ip6)
when connecting to anvil
([#5744](AztecProtocol/aztec-packages#5744))
([66fc89f](AztecProtocol/aztec-packages@66fc89f))
* Simplify ECCVM prover constructor and add a TODO
([#5681](AztecProtocol/aztec-packages#5681))
([8c151ea](AztecProtocol/aztec-packages@8c151ea))
* Spot refcount
([#5746](AztecProtocol/aztec-packages#5746))
([9e18444](AztecProtocol/aztec-packages@9e18444))
* Take a deep copy of circuit inputs for proving
([#5777](AztecProtocol/aztec-packages#5777))
([785591e](AztecProtocol/aztec-packages@785591e))
* Temporarily disable the bench tests
([#5755](AztecProtocol/aztec-packages#5755))
([1d52ac5](AztecProtocol/aztec-packages@1d52ac5))
* Update commit for noir-gates-diff
(noir-lang/noir#4773)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Use entrypoint instead of pay_init_fee
([#5623](AztecProtocol/aztec-packages#5623))
([62ac765](AztecProtocol/aztec-packages@62ac765))
* Watch less files.
([#5651](AztecProtocol/aztec-packages#5651))
([57a1d69](AztecProtocol/aztec-packages@57a1d69))


### Miscellaneous

* Add missing aztec-address tests
([#5674](AztecProtocol/aztec-packages#5674))
([58aefba](AztecProtocol/aztec-packages@58aefba))
* **avm:** Add a boolean to toggle proving in AVM unit tests
([#5667](AztecProtocol/aztec-packages#5667))
([ec122c9](AztecProtocol/aztec-packages@ec122c9)),
closes
[#5663](AztecProtocol/aztec-packages#5663)
* **avm:** Hashing tests cleanup
([#5733](AztecProtocol/aztec-packages#5733))
([53d0102](AztecProtocol/aztec-packages@53d0102))
* **avm:** Range checks negative tests
([#5770](AztecProtocol/aztec-packages#5770))
([2907142](AztecProtocol/aztec-packages@2907142))
* **avm:** Split the negative test on range check for high 16-bit
registers
([#5785](AztecProtocol/aztec-packages#5785))
([8ebbe57](AztecProtocol/aztec-packages@8ebbe57))
* **avm:** Split up AVM test contract as it was growing too large
([#5702](AztecProtocol/aztec-packages#5702))
([5b8e812](AztecProtocol/aztec-packages@5b8e812))
* **aztec-nr:** Minor public interface changes
([#5776](AztecProtocol/aztec-packages#5776))
([91b8110](AztecProtocol/aztec-packages@91b8110))
* **ci:** Break e2e-deploy into multiple test suites
([#5704](AztecProtocol/aztec-packages#5704))
([2522294](AztecProtocol/aztec-packages@2522294))
* **ci:** Earthly in spot with persistent cache
([#5644](AztecProtocol/aztec-packages#5644))
([a39c2f6](AztecProtocol/aztec-packages@a39c2f6))
* **ci:** Hotfix AMI's, workflow to stop personal spot runners
([#5712](AztecProtocol/aztec-packages#5712))
([5f18139](AztecProtocol/aztec-packages@5f18139))
* **ci:** Only run ARM on master
([#5705](AztecProtocol/aztec-packages#5705))
([f77c142](AztecProtocol/aztec-packages@f77c142))
* **ci:** Use 128 cores for x86 and add timeouts
([#5665](AztecProtocol/aztec-packages#5665))
([0c5dc0a](AztecProtocol/aztec-packages@0c5dc0a))
* Compute_note_hash_and_nullifier - improve error message
([#5671](AztecProtocol/aztec-packages#5671))
([8942d69](AztecProtocol/aztec-packages@8942d69))
* Create placeholder version of 0.26.0 docs
(noir-lang/noir#4782)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* **doc:** Fix broken docs links
(noir-lang/noir#4606)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* **docs:** Fix link in the Data Types page
(noir-lang/noir#4527)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Don't strip bb wasm
([#5743](AztecProtocol/aztec-packages#5743))
([d4cb410](AztecProtocol/aztec-packages@d4cb410))
* Fix master after merge issue related to validate_trace renaming
([#5676](AztecProtocol/aztec-packages#5676))
([44e0d8a](AztecProtocol/aztec-packages@44e0d8a))
* Fix max-block-number and auth e2e tests
([#5694](AztecProtocol/aztec-packages#5694))
([f1bf314](AztecProtocol/aztec-packages@f1bf314))
* Op queue
([#5648](AztecProtocol/aztec-packages#5648))
([822c7e6](AztecProtocol/aztec-packages@822c7e6))
* **public:** Remove getNullifierMembershipWitness
([#5715](AztecProtocol/aztec-packages#5715))
([3be402c](AztecProtocol/aztec-packages@3be402c))
* Re-enable e2e fees tests
([#5784](AztecProtocol/aztec-packages#5784))
([102e8b8](AztecProtocol/aztec-packages@102e8b8))
* Release Noir(0.27.0) (noir-lang/noir#4632)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Remove the old Value struct from the oracle docs
(noir-lang/noir#4738)
([1eb288e](AztecProtocol/aztec-packages@1eb288e))
* Replace relative paths to noir-protocol-circuits
([fb2b298](AztecProtocol/aztec-packages@fb2b298))
* Replace relative paths to noir-protocol-circuits
([e20920d](AztecProtocol/aztec-packages@e20920d))
* Replace relative paths to noir-protocol-circuits
([6351dc5](AztecProtocol/aztec-packages@6351dc5))
* Replace relative paths to noir-protocol-circuits
([fee13bf](AztecProtocol/aztec-packages@fee13bf))
* Replacing unsafe::zeroed()
([#5685](AztecProtocol/aztec-packages#5685))
([ea3884e](AztecProtocol/aztec-packages@ea3884e))
* Small logging changes
([#5654](AztecProtocol/aztec-packages#5654))
([25cc70d](AztecProtocol/aztec-packages@25cc70d))
* Temporarily skip failing e2e fees test
([a3ac5ff](AztecProtocol/aztec-packages@a3ac5ff))
* Testing that nargo fmt is idempotent
(noir-lang/noir#4765)
([825c455](AztecProtocol/aztec-packages@825c455))
* TS hash wrappers cleanup
([#5691](AztecProtocol/aztec-packages#5691))
([7f8b09f](AztecProtocol/aztec-packages@7f8b09f))
* Turn ENABLE_GAS where it is needed
([#5730](AztecProtocol/aztec-packages#5730))
([30a2edd](AztecProtocol/aztec-packages@30a2edd))
* Update noir gates diff
([#5658](AztecProtocol/aztec-packages#5658))
([9816c1a](AztecProtocol/aztec-packages@9816c1a))
* We can run 35 of our e2e tests just using jest.
([#5643](AztecProtocol/aztec-packages#5643))
([4fcaeae](AztecProtocol/aztec-packages@4fcaeae))


### Documentation

* Fix yp typo control-flow.md
([#5638](AztecProtocol/aztec-packages#5638))
([363d227](AztecProtocol/aztec-packages@363d227))
</details>

<details><summary>barretenberg: 0.35.0</summary>

##
[0.35.0](AztecProtocol/aztec-packages@barretenberg-v0.34.0...barretenberg-v0.35.0)
(2024-04-16)


### ⚠ BREAKING CHANGES

* Use fixed size arrays in black box functions where sizes are known
([#5620](AztecProtocol/aztec-packages#5620))
* trap with revert data
([#5732](AztecProtocol/aztec-packages#5732))
* **acir:** BrilligCall opcode
([#5709](AztecProtocol/aztec-packages#5709))

### Features

* **acir:** BrilligCall opcode
([#5709](AztecProtocol/aztec-packages#5709))
([f06f64c](AztecProtocol/aztec-packages@f06f64c))
* **avm:** CMOV opcode
([#5575](AztecProtocol/aztec-packages#5575))
([19dbe46](AztecProtocol/aztec-packages@19dbe46)),
closes
[#5557](AztecProtocol/aztec-packages#5557)
* **avm:** Enable contract testing with bb binary
([#5584](AztecProtocol/aztec-packages#5584))
([d007d79](AztecProtocol/aztec-packages@d007d79))
* **avm:** Enable range check on the ALU registers
([#5696](AztecProtocol/aztec-packages#5696))
([202fc1b](AztecProtocol/aztec-packages@202fc1b))
* Changing finite field arithmetic in wasm to 29 bits for
multiplications
([#5435](AztecProtocol/aztec-packages#5435))
([b2d9b9d](AztecProtocol/aztec-packages@b2d9b9d))
* **ci:** Turn on new CI as mandatory
([#5761](AztecProtocol/aztec-packages#5761))
([bebed32](AztecProtocol/aztec-packages@bebed32))
* Export poseidon2_permutation and add to foundation/crypto
([#5706](AztecProtocol/aztec-packages#5706))
([6b91e27](AztecProtocol/aztec-packages@6b91e27))
* LT/LTE for AVM
([#5559](AztecProtocol/aztec-packages#5559))
([350abeb](AztecProtocol/aztec-packages@350abeb))
* Trap with revert data
([#5732](AztecProtocol/aztec-packages#5732))
([f849575](AztecProtocol/aztec-packages@f849575))
* Use fixed size arrays in black box functions where sizes are known
([#5620](AztecProtocol/aztec-packages#5620))
([f50b180](AztecProtocol/aztec-packages@f50b180))


### Bug Fixes

* "feat: Changing finite field arithmetic in wasm to 29 bits for
multiplications"
([#5779](AztecProtocol/aztec-packages#5779))
([bcfee97](AztecProtocol/aztec-packages@bcfee97))
* Avoid get row in databus
([#5742](AztecProtocol/aztec-packages#5742))
([d67b6c8](AztecProtocol/aztec-packages@d67b6c8))
* **ci:** Bigger cache disk, cache+prune docker images, disable
ClientIvcTests.Full
([#5729](AztecProtocol/aztec-packages#5729))
([5dcbd75](AztecProtocol/aztec-packages@5dcbd75))
* Disable flakey vanilla recursion test
([#5672](AztecProtocol/aztec-packages#5672))
([f84f7b6](AztecProtocol/aztec-packages@f84f7b6))
* Less earthly cache
([#5690](AztecProtocol/aztec-packages#5690))
([8190dc7](AztecProtocol/aztec-packages@8190dc7))
* Make earthly more parallel
([#5747](AztecProtocol/aztec-packages#5747))
([9734455](AztecProtocol/aztec-packages@9734455))
* Simplify ECCVM prover constructor and add a TODO
([#5681](AztecProtocol/aztec-packages#5681))
([8c151ea](AztecProtocol/aztec-packages@8c151ea))


### Miscellaneous

* **avm:** Add a boolean to toggle proving in AVM unit tests
([#5667](AztecProtocol/aztec-packages#5667))
([ec122c9](AztecProtocol/aztec-packages@ec122c9)),
closes
[#5663](AztecProtocol/aztec-packages#5663)
* **avm:** Range checks negative tests
([#5770](AztecProtocol/aztec-packages#5770))
([2907142](AztecProtocol/aztec-packages@2907142))
* **avm:** Split the negative test on range check for high 16-bit
registers
([#5785](AztecProtocol/aztec-packages#5785))
([8ebbe57](AztecProtocol/aztec-packages@8ebbe57))
* **ci:** Use 128 cores for x86 and add timeouts
([#5665](AztecProtocol/aztec-packages#5665))
([0c5dc0a](AztecProtocol/aztec-packages@0c5dc0a))
* Don't strip bb wasm
([#5743](AztecProtocol/aztec-packages#5743))
([d4cb410](AztecProtocol/aztec-packages@d4cb410))
* Fix master after merge issue related to validate_trace renaming
([#5676](AztecProtocol/aztec-packages#5676))
([44e0d8a](AztecProtocol/aztec-packages@44e0d8a))
* Op queue
([#5648](AztecProtocol/aztec-packages#5648))
([822c7e6](AztecProtocol/aztec-packages@822c7e6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants