Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-vm: implement inTag for all relevant instructions #4271

Closed
Tracked by #3383
dbanks12 opened this issue Jan 29, 2024 · 2 comments
Closed
Tracked by #3383

public-vm: implement inTag for all relevant instructions #4271

dbanks12 opened this issue Jan 29, 2024 · 2 comments
Assignees
@fcarreiro
Labels
C-avm Component: AVM related tickets (aka public VM)
Milestone
AVM Simulator Pha...

Comments

@dbanks12
Copy link
Contributor

dbanks12 commented Jan 29, 2024 •
edited
Loading

As part of this instruction, we should treat tags as different from operands and let them be 8 bits!
@dbanks12 dbanks12 mentioned this issue Jan 29, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 29, 2024
@dbanks12 dbanks12 added the C-avm Component: AVM related tickets (aka public VM) label Jan 29, 2024
@fcarreiro fcarreiro mentioned this issue Feb 2, 2024
Merged
fcarreiro added a commit that referenced this issue Feb 2, 2024
@fcarreiro
feat(avm): complete SET instruction (#4378)
013891f 
This pull request completes the implementation of the SET instruction
and adds handling for invalid tags. It also includes necessary tests for
the new functionality.

SET takes the given u128, casts it to the provided inTag type, and sets
the memory.

Ref: #4267, #4271.
@dbanks12
Copy link
Contributor Author

Is this done?

@fcarreiro
Copy link
Contributor

Yes. Double checked and all currently implemented ops in the transpiler handle tags.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 27, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@fcarreiro
feat(avm): complete SET instruction (AztecProtocol#4378)
adb2af6 
This pull request completes the implementation of the SET instruction
and adds handling for invalid tags. It also includes necessary tests for
the new functionality.

SET takes the given u128, casts it to the provided inTag type, and sets
the memory.

Ref: AztecProtocol#4267, AztecProtocol#4271.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcarreiro fcarreiro

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
AVM Simulator Phase 1 (partial)
Development

No branches or pull requests
2 participants
@fcarreiro @dbanks12