-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
public-vm: support all types for SET (u8, ..., u128) #4267
Comments
@dbanks12 what was the scope for this ticket? have the binary rep be u128 and cast, or decide the spec on what to do with other sizes? |
Let's do whatever's easiest for now (probably 128 binary rep + cast?). This ticket is basically "get them working with simulator and transpiler", although at the moment Noir doesn't actually tell us what type it's setting, so we might not really be able to flex this with real transpiled code at the moment. |
It's done now on the TS side, assuming a 128 bit constant in the wire format. As I mentioned in other comment, we have a few options for the wire format depending on wether we want fixed-size serialization or variable-size serialization.
cc: @jeanmon |
Current cpp code deserializes SET bytecode deducing the size of the constant from the inTag (fixed size based on tag) |
This pull request completes the implementation of the SET instruction and adds handling for invalid tags. It also includes necessary tests for the new functionality. SET takes the given u128, casts it to the provided inTag type, and sets the memory. Ref: AztecProtocol#4267, AztecProtocol#4271.
No description provided.
The text was updated successfully, but these errors were encountered: