feat(avm): bytecode avm control flow

[jeanmon]

Resolves #4209

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 80be57d6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,716	867,040	3,446,596
l1_rollup_execution_gas	314,203	984,780	3,666,253
l2_block_processing_time_in_ms	1,154	4,358	17,255 (-1%)
note_successful_decrypting_time_in_ms	255 (+1%)	888 (-1%)	3,339 (-3%)
note_trial_decrypting_time_in_ms	66.1 (+7%)	132 (-16%)	142 (-5%)
l2_block_building_time_in_ms	16,353	64,800	259,947
l2_block_rollup_simulation_time_in_ms	11,800	46,706	188,169
l2_block_public_tx_process_time_in_ms	4,525 (-1%)	17,947	71,445

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,119	27,290 (-1%)
note_history_successful_decrypting_time_in_ms	2,306 (+9%)	4,195 (-7%)
note_history_trial_decrypting_time_in_ms	113 (-59%)	177 (-24%)
node_database_size_in_bytes	17,293,392	33,165,392
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	220	44,777	26,073
private-kernel-ordering	178 (-1%)	44,393	14,809
base-rollup	1,260 (+1%)	128,850	881
root-rollup	87.1 (+6%)	4,088	677
private-kernel-inner	311	71,816	26,073
public-kernel-private-input	217	32,375	26,073
public-kernel-non-first-iteration	214	32,417	26,073
merge-rollup	7.86 (+2%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	10.9 (-7%)	12.6 (-1%)	17.8 (+5%)	22.7 (-1%)	63.8 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595	0.610 (-2%)	0.539	0.551 (+5%)	0.477 (-1%)	0.441	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.3 (-4%)	47.4	239	461	900	3,550 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.460 (-3%)	0.487	0.436	0.432	0.428	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	103 (-2%)	56.4	347 (-1%)	685 (-1%)	1,359	5,410
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.492 (-1%)	0.495	0.474	0.472	0.472	0.471
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.4	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.577	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,993

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	395	1,117

Metric	1 public data writes
tx_sequencer_processing_time_ms	557

[fcarreiro]

Just a general GTest comment (just in case): EXPECT_ should only be used to check what the test case if testing, and not be used to check preconditions for the test case to run correctly. (I'm not sure which case is here).

For example, if a test is

TestDivision() {
a = getnumber();
b = getnumber()
ASSERT_NEQ(b, 0);
c = div(a,b);

EXPECT_EQ(c, a/b);
}

Then the first assert should not be an EXPECT because it's a precondition check.

Another comment (related to the above): if an EXPECT fails, the test does not stop. But if an ASSERT fails, it does.

Another comment (related): ASSERTs on subroutines/helper functions do not work as expected. Some extra work is needed: https://github.com/google/googletest/blob/main/docs/advanced.md#asserting-on-subroutines

[jeanmon]

@fcarreiro Thanks for the pointer. The check_circuit() is part of the test rather than a precondition check in this context.

In the context of deterministic tests, I am not sure it matters so much. You will want to have everything green anyway. The ASSERT will allow you to save CPU time.

[dbanks12]

LGTM