fix: generic Honk dependencies

[codygunton]

The barretenberg_module honk, which actually only contains a handful of utilities used by the various flavors ultra_honk, eccvm, translator_vm and vm 🤦 , was not being correctly reflected in the bb module structure. I fix this by removing a whitespace character in the CMakeLists.txt file. While I'm at it I reduce its dependencies to the minimal set.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 80be57d6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,596	866,680	3,448,264
l1_rollup_execution_gas	314,083	984,420	3,667,921
l2_block_processing_time_in_ms	1,153	4,344	17,186 (-1%)
note_successful_decrypting_time_in_ms	259 (+3%)	888 (-1%)	3,329 (-3%)
note_trial_decrypting_time_in_ms	69.5 (+12%)	161 (+2%)	148 (-1%)
l2_block_building_time_in_ms	16,346	64,688	259,230
l2_block_rollup_simulation_time_in_ms	11,794	46,677	187,725
l2_block_public_tx_process_time_in_ms	4,524 (-1%)	17,922 (-1%)	71,221 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,537 (-5%)	25,964 (-6%)
note_history_successful_decrypting_time_in_ms	2,261 (+7%)	4,404 (-2%)
note_history_trial_decrypting_time_in_ms	82.6 (-70%)	215 (-8%)
node_database_size_in_bytes	17,317,968	32,968,784
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	220	44,777	26,073
private-kernel-ordering	179	44,393	14,809
base-rollup	1,251	128,850	881
root-rollup	82.1	4,088	677
private-kernel-inner	312	71,816	26,073
public-kernel-private-input	216	32,375	26,073
public-kernel-non-first-iteration	213	32,417	26,073
merge-rollup	7.76 (+1%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.7 (-1%)	12.6 (-1%)	16.9	22.8	63.8 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.594	0.650 (+4%)	0.538 (-1%)	0.522	0.478	0.441 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	78.9 (+2%)	47.6	242 (+1%)	462	898 (-1%)	3,546 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.487 (+3%)	0.488	0.442 (+1%)	0.432	0.428	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	109 (+4%)	57.0 (+1%)	348	690	1,361	5,385 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.510 (+3%)	0.499 (+1%)	0.474	0.474	0.473	0.470
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,993

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	399 (+1%)	1,121

Metric	1 public data writes
tx_sequencer_processing_time_ms	556

[ledwards2225]

Yep