Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs once merge rollup circuit errors "turned on" #368

Closed
dbanks12 opened this issue Apr 25, 2023 · 1 comment
Closed

Fix bugs once merge rollup circuit errors "turned on" #368

dbanks12 opened this issue Apr 25, 2023 · 1 comment

Comments

@dbanks12
Copy link
Collaborator

No description provided.

@dbanks12 dbanks12 converted this from a draft issue Apr 25, 2023
@dbanks12 dbanks12 moved this from Todo to Done in A3 May 9, 2023
@iAmMichaelConnor
Copy link
Contributor

Closing because moved to 'Done'

ludamad added a commit that referenced this issue Jul 14, 2023
@suyash67 @ludamad @codygunton
Pending bb work for aztec3 (#368)
4487114 
* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* c_binds and other ECDSA related fixes (#407)

* Add v to stdlib ecdsa.

* create an engine if its empty.

* Add ecdsa c_bind.

* print v as a uint32.

* Add secp256k1 cbind.

add c_bind.hpp

Change hpp to h.

remove hpp.

* Add ecdsa in cmakelists.

remove stdlib_ecdsa from build.

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage (#411)

* Update join_split test

* Tweaks to comments

* Add comment for the assertion in bigfield.

* Expanded on ecdsa comment.

---------

Co-authored-by: ludamad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Co-authored-by: codygunton <[email protected]>
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
codygunton added a commit that referenced this issue Jan 23, 2024
@suyash67 @ludamad @codygunton
Pending bb work for aztec3 (#368)
89946ae 
* update js vk (because we now use UP for merkle hashing)

* Helpers for ECDSA in A3 (#364)

* Add `stdlib_keccak` in cmake.

Correct an assertion in `to_byte_array` in bigfield.

* Add `random_element` to affine element.

* negate y conditionally.

* Change pedersen hash c_bind to use `pedersen_hash::lookup`.

* c_binds and other ECDSA related fixes (#407)

* Add v to stdlib ecdsa.

* create an engine if its empty.

* Add ecdsa c_bind.

* print v as a uint32.

* Add secp256k1 cbind.

add c_bind.hpp

Change hpp to h.

remove hpp.

* Add ecdsa in cmakelists.

remove stdlib_ecdsa from build.

* chore: align BARRETENBERG_CRYPTO_GENERATOR_PARAMETERS_HACK usage (#411)

* Update join_split test

* Tweaks to comments

* Add comment for the assertion in bigfield.

* Expanded on ecdsa comment.

---------

Co-authored-by: ludamad <[email protected]>
Co-authored-by: ludamad <[email protected]>
Co-authored-by: codygunton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iAmMichaelConnor @dbanks12