Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aztec-sandbox docker-compose.yml for canary testing #2917

Closed
spypsy opened this issue Oct 18, 2023 · 0 comments · Fixed by #2891
Closed

Use aztec-sandbox docker-compose.yml for canary testing #2917

spypsy opened this issue Oct 18, 2023 · 0 comments · Fixed by #2891
Assignees
@spypsy
Labels
A-devops Area: Devops. E.g. CI / build systems T-testing Type: Testing. More tests need to be added.

Comments

@spypsy
Copy link
Member

spypsy commented Oct 18, 2023 •
edited
Loading

Canary tests should be as close as possible to real-world usage. We've achieved this with canary tag deployments in NPM & Dockerhub, but we should also use the same docker-compose.yml file that users fetch when starting the sandbox.
We currently have a separate yml file which is very similar but this way we won't catch errors when changing the aztec-sandbox/docker-compose.yml file.
@spypsy spypsy added this to A3 Oct 18, 2023
@spypsy spypsy self-assigned this Oct 18, 2023
@spypsy spypsy converted this from a draft issue Oct 18, 2023
@spypsy spypsy added A-devops Area: Devops. E.g. CI / build systems T-testing Type: Testing. More tests need to be added. labels Oct 18, 2023
This was referenced Oct 18, 2023
Closed
Merged
spypsy added a commit that referenced this issue Oct 18, 2023
@spypsy
fix #2917
6661e67
@spypsy spypsy moved this from Todo to In Review in A3 Oct 19, 2023
PhilWindle pushed a commit that referenced this issue Oct 24, 2023
@spypsy
test: run all e2e tests against sandbox (#2891)
6c4e26c 
Fixes #2642 
Fixes #2917
Also: use `aztecprotocol/aztec-sandbox:canary` for canary tests

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
A-devops Area: Devops. E.g. CI / build systems T-testing Type: Testing. More tests need to be added.
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@spypsy