Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sandbox for all e2e tests #2642

Closed
spypsy opened this issue Oct 3, 2023 · 0 comments · Fixed by #2891
Closed

Use Sandbox for all e2e tests #2642

spypsy opened this issue Oct 3, 2023 · 0 comments · Fixed by #2891
Assignees
Labels
T-testing Type: Testing. More tests need to be added.

Comments

@spypsy
Copy link
Member

spypsy commented Oct 3, 2023

(where appropriate) instead of importing a pxe instance directly, we should be using the sandbox setup that we have for some of the tests in order to make env similar to real usage & reduce code dependencies

@spypsy spypsy added this to A3 Oct 3, 2023
@spypsy spypsy converted this from a draft issue Oct 3, 2023
@spypsy spypsy added the T-testing Type: Testing. More tests need to be added. label Oct 3, 2023
@spypsy spypsy self-assigned this Oct 10, 2023
@spypsy spypsy moved this from Todo to In Review in A3 Oct 19, 2023
PhilWindle pushed a commit that referenced this issue Oct 24, 2023
Fixes #2642 
Fixes #2917
Also: use `aztecprotocol/aztec-sandbox:canary` for canary tests

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-testing Type: Testing. More tests need to be added.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant