feat: contract ts interface to use only aztec.js imports #2876

rahul-kothari · 2023-10-16T14:53:07Z

Currently we expect users to have @aztec/foundation npm package imported when everything except ContractArtifact is also exported from aztec.js

Seems nice to just use 1 package!

Also lint it!

AztecBot · 2023-10-16T15:27:21Z

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit cb18f455 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	223,020	867,824	3,449,528
l1_rollup_execution_gas	842,107	3,594,932	22,204,897
l2_block_processing_time_in_ms	⚠️ 1,252 (+21%)	⚠️ 4,748 (+19%)	⚠️ 18,733 (+19%)
note_successful_decrypting_time_in_ms	⚠️ 386 (+17%)	⚠️ 1,229 (+21%)	⚠️ 4,598 (+22%)
note_trial_decrypting_time_in_ms	⚠️ 89.0 (+162%)	110 (+2%)	145 (+5%)
l2_block_building_time_in_ms	⚠️ 11,065 (+22%)	⚠️ 44,340 (+23%)	⚠️ 187,837 (+24%)
l2_block_rollup_simulation_time_in_ms	⚠️ 8,281 (+23%)	⚠️ 33,254 (+24%)	⚠️ 131,631 (+23%)
l2_block_public_tx_process_time_in_ms	⚠️ 2,738 (+20%)	⚠️ 10,936 (+19%)	⚠️ 55,358 (+26%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,214 (-1%)	30,272 (-2%)
note_history_successful_decrypting_time_in_ms	2,340 (-1%)	4,657 (-2%)
note_history_trial_decrypting_time_in_ms	124 (+2%)	146
node_database_size_in_bytes	1,650,279	1,195,533
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	48.2 (+10%)	56,577	14,745
private-kernel-ordering	⚠️ 23.8 (+11%)	20,137	8,089
base-rollup	⚠️ 947 (+11%)	631,605	811
root-rollup	41.0 (+8%)	4,072	1,097
private-kernel-inner	39.7 (+9%)	72,288	14,745
public-kernel-private-input	⚠️ 52.9 (+12%)	37,359	14,745
public-kernel-non-first-iteration	⚠️ 31.6 (+12%)	37,401	14,745
merge-rollup	⚠️ 1.01 (+14%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,094

benesjan

Looks good 👍

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.9.0</summary> ## [0.9.0](aztec-packages-v0.8.14...aztec-packages-v0.9.0) (2023-10-17) ### ⚠ BREAKING CHANGES * nuking `PublicToken` and `PrivateAirdropToken` ([#2873](#2873)) * Change blake3 to blake2 in private kernel ([#2861](#2861)) * nuking private token ([#2822](#2822)) ### Features * Contract ts interface to use only aztec.js imports ([#2876](#2876)) ([6952a1a](6952a1a)) * Faucet ([#2856](#2856)) ([5bad35f](5bad35f)) * Nuking `PublicToken` and `PrivateAirdropToken` ([#2873](#2873)) ([c74311d](c74311d)) * Nuking private token ([#2822](#2822)) ([5d93a47](5d93a47)), closes [#2350](#2350) ### Bug Fixes * Aztec node to save outbox adddress to config ([#2867](#2867)) ([b6418a6](b6418a6)) * Create data dir on node boot ([#2864](#2864)) ([2d498b3](2d498b3)) * Don't repeatedly scan for missing messages ([#2886](#2886)) ([3fe1cc8](3fe1cc8)) * Fix trailing pipe causing everything to rebuild. Sorry... ([d13ba75](d13ba75)) * Pad L1 to L2 messages upon retrieval from L1 ([#2879](#2879)) ([457669e](457669e)) * Sequencer aborts in-progress block ([#2883](#2883)) ([b0915a8](b0915a8)) ### Miscellaneous * Change blake3 to blake2 in private kernel ([#2861](#2861)) ([d629940](d629940)) * Making anvil silent again ([#2866](#2866)) ([90ae5dc](90ae5dc)) * Spell check on forbidden words. ([#2887](#2887)) ([06bc4f9](06bc4f9)) ### Documentation * Initial 'protocol description' toc ([#2844](#2844)) ([cb18f45](cb18f45)) </details> <details><summary>barretenberg.js: 0.9.0</summary> ## [0.9.0](barretenberg.js-v0.8.14...barretenberg.js-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.9.0</summary> ## [0.9.0](barretenberg-v0.8.14...barretenberg-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@aztec-packages-v0.8.14...aztec-packages-v0.9.0) (2023-10-17) ### ⚠ BREAKING CHANGES * nuking `PublicToken` and `PrivateAirdropToken` ([#2873](AztecProtocol/aztec-packages#2873)) * Change blake3 to blake2 in private kernel ([#2861](AztecProtocol/aztec-packages#2861)) * nuking private token ([#2822](AztecProtocol/aztec-packages#2822)) ### Features * Contract ts interface to use only aztec.js imports ([#2876](AztecProtocol/aztec-packages#2876)) ([6952a1a](AztecProtocol/aztec-packages@6952a1a)) * Faucet ([#2856](AztecProtocol/aztec-packages#2856)) ([5bad35f](AztecProtocol/aztec-packages@5bad35f)) * Nuking `PublicToken` and `PrivateAirdropToken` ([#2873](AztecProtocol/aztec-packages#2873)) ([c74311d](AztecProtocol/aztec-packages@c74311d)) * Nuking private token ([#2822](AztecProtocol/aztec-packages#2822)) ([5d93a47](AztecProtocol/aztec-packages@5d93a47)), closes [#2350](AztecProtocol/aztec-packages#2350) ### Bug Fixes * Aztec node to save outbox adddress to config ([#2867](AztecProtocol/aztec-packages#2867)) ([b6418a6](AztecProtocol/aztec-packages@b6418a6)) * Create data dir on node boot ([#2864](AztecProtocol/aztec-packages#2864)) ([2d498b3](AztecProtocol/aztec-packages@2d498b3)) * Don't repeatedly scan for missing messages ([#2886](AztecProtocol/aztec-packages#2886)) ([3fe1cc8](AztecProtocol/aztec-packages@3fe1cc8)) * Fix trailing pipe causing everything to rebuild. Sorry... ([d13ba75](AztecProtocol/aztec-packages@d13ba75)) * Pad L1 to L2 messages upon retrieval from L1 ([#2879](AztecProtocol/aztec-packages#2879)) ([457669e](AztecProtocol/aztec-packages@457669e)) * Sequencer aborts in-progress block ([#2883](AztecProtocol/aztec-packages#2883)) ([b0915a8](AztecProtocol/aztec-packages@b0915a8)) ### Miscellaneous * Change blake3 to blake2 in private kernel ([#2861](AztecProtocol/aztec-packages#2861)) ([d629940](AztecProtocol/aztec-packages@d629940)) * Making anvil silent again ([#2866](AztecProtocol/aztec-packages#2866)) ([90ae5dc](AztecProtocol/aztec-packages@90ae5dc)) * Spell check on forbidden words. ([#2887](AztecProtocol/aztec-packages#2887)) ([06bc4f9](AztecProtocol/aztec-packages@06bc4f9)) ### Documentation * Initial 'protocol description' toc ([#2844](AztecProtocol/aztec-packages#2844)) ([cb18f45](AztecProtocol/aztec-packages@cb18f45)) </details> <details><summary>barretenberg.js: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@barretenberg.js-v0.8.14...barretenberg.js-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.9.0</summary> ## [0.9.0](AztecProtocol/aztec-packages@barretenberg-v0.8.14...barretenberg-v0.9.0) (2023-10-17) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

use only aztec.js imports in ts interface

12c2f9c

rahul-kothari requested review from benesjan and LHerskind October 16, 2023 16:25

rahul-kothari enabled auto-merge (squash) October 17, 2023 09:25

benesjan approved these changes Oct 17, 2023

View reviewed changes

rahul-kothari merged commit 6952a1a into master Oct 17, 2023
3 checks passed

rahul-kothari deleted the rk/fix_ts_interface branch October 17, 2023 12:07

AztecBot mentioned this pull request Oct 17, 2023

chore(master): Release 0.9.0 #2865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: contract ts interface to use only aztec.js imports #2876

feat: contract ts interface to use only aztec.js imports #2876

rahul-kothari commented Oct 16, 2023 •

edited

Loading

AztecBot commented Oct 16, 2023

benesjan left a comment

feat: contract ts interface to use only aztec.js imports #2876

feat: contract ts interface to use only aztec.js imports #2876

Conversation

rahul-kothari commented Oct 16, 2023 • edited Loading

AztecBot commented Oct 16, 2023

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

benesjan left a comment

Choose a reason for hiding this comment

rahul-kothari commented Oct 16, 2023 •

edited

Loading